From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE829C4360F for ; Thu, 4 Apr 2019 16:30:02 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 8482F20882 for ; Thu, 4 Apr 2019 16:30:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8482F20882 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linutronix.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 4CF526B0269; Thu, 4 Apr 2019 12:30:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 47F046B026A; Thu, 4 Apr 2019 12:30:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3216C6B026B; Thu, 4 Apr 2019 12:30:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by kanga.kvack.org (Postfix) with ESMTP id D53296B0269 for ; Thu, 4 Apr 2019 12:30:00 -0400 (EDT) Received: by mail-wr1-f71.google.com with SMTP id t10so2293091wrp.3 for ; Thu, 04 Apr 2019 09:30:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-original-authentication-results:x-gm-message-state:date:from:to :cc:subject:in-reply-to:message-id:references:user-agent :mime-version; bh=rdu8TEDS1cDwlpdawiM/OWJMOY3nxO1tCZ1slcoIjc8=; b=G8bIYtr5pNNpZ5zVfc7ipbEolv+43Rzw2xMuSwlnChxWSzuwAoj9SUbrmQewCqNcxs v8i1/rUPnPDnpvYJ+YcMfzeAwoguo63ISyG4qwEVmbAgalbvzszYvb/NKIJv6ZGdD233 zjRJ2n5w4nRdlJ4nVOg5r07fzYyhsCVgcVrxAZVl/DnIBh+FWOC/SAP5D7ucHW45iXai Kr3v/zzrUo9X48v1zxcSNcMms+aK+7jhxU86eA/aZ3n4U6iOFmhR45q7/9AIEj+wXZVe +IXUp8RGAh1seY6ijZWR3IVVfDGJ7s/idE5E+XYVXT59tW8le0cXoyGJChCnf/WnATyM 1gTQ== X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of tglx@linutronix.de designates 2a01:7a0:2:106d:700::1 as permitted sender) smtp.mailfrom=tglx@linutronix.de X-Gm-Message-State: APjAAAXgz6+oAsaJwVXlv3eVjDvxHdWIg4v2BFHIDddWwr7RS2OBX0HP R8HdMphl47IrmnZtI9qA1vL07nM17/WH+0ptzlLdtm4DAqThrg4gympra9cbE+Fs0A2NEoeNgk+ II0Xanvcb+TA5diPDBBksq8L4tJ5tDhn/e/jOZs7vV72LJF9qlS9UirtzXA17k4G1hA== X-Received: by 2002:a1c:6455:: with SMTP id y82mr3270685wmb.104.1554395400405; Thu, 04 Apr 2019 09:30:00 -0700 (PDT) X-Google-Smtp-Source: APXvYqwfmo4AY50YLS4gezlKMuLdVLhOXTafvtFIZkovhg0QsNxFmD3NMbtDGlMDh3PcxTsox33T X-Received: by 2002:a1c:6455:: with SMTP id y82mr3270639wmb.104.1554395399644; Thu, 04 Apr 2019 09:29:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1554395399; cv=none; d=google.com; s=arc-20160816; b=Oc32YSR4Z0vSOq2tEXf/7L41twWadF3PcJxxGN+MsOEJD2JG/2ddVVBt17arePXIM6 kGYUrWEfVHwCBeqUjN8ZXt3fHDm/1Eki7DhlfeLFVQWrVBh8gOKi+EwtQQSXphMgeVeM 6xLlWRGNqNgp6dL0D0cV4megPXbW2BkxjPMtpkz6AyUhKcrspJbyoIdspS+5qDIECSrH m3qunjRe4UbhDlytGeZZlv8wCaEW1tZ3vDMlxi1C6LUg0vZlnIByxKHBMEpoFyL8HYf7 EyI3Gz39FVROZzIlM/4RFU1vFHrCcGsQ2vzblpa44NvOHdx+kColkPo6hsUnKkzMx1ic RCbA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:user-agent:references:message-id:in-reply-to:subject :cc:to:from:date; bh=rdu8TEDS1cDwlpdawiM/OWJMOY3nxO1tCZ1slcoIjc8=; b=ce++P3Lq2+axcgIrtUb/EuvZ8MTecUEJ4r3ogWlNbJzuegoRHOcmTAwyqzk5hHnvdG nVclxSI0iBNYa6Cb1LWeSi65Y60yLQJLxuXbtK6kr3v75i+mQ3W3VTZ7mwsD3IN6GHOh rGaWdgl4+gPico34VIgzY+NlroL2A4cGXEPtKZ+ZNdb+iHWkmzPn+y6AMsOIQ0FWJO0Z aQgGxdFN48DhXVt8Jmf1nPtXnDoRnYr4UwI6PCzA3e0VXTN901sYfjoYcFI73OStOCUl S+7rkfI3ajsNYMmv3VMumW3zA6iQJMNTj3umTsUardghK266Ql011nwwlZyf8Y5xKhdx PuXg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of tglx@linutronix.de designates 2a01:7a0:2:106d:700::1 as permitted sender) smtp.mailfrom=tglx@linutronix.de Received: from Galois.linutronix.de (Galois.linutronix.de. [2a01:7a0:2:106d:700::1]) by mx.google.com with ESMTPS id a10si12035327wme.136.2019.04.04.09.29.59 for (version=TLS1_2 cipher=AES128-SHA bits=128/128); Thu, 04 Apr 2019 09:29:59 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of tglx@linutronix.de designates 2a01:7a0:2:106d:700::1 as permitted sender) client-ip=2a01:7a0:2:106d:700::1; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of tglx@linutronix.de designates 2a01:7a0:2:106d:700::1 as permitted sender) smtp.mailfrom=tglx@linutronix.de Received: from p5492e2fc.dip0.t-ipconnect.de ([84.146.226.252] helo=nanos) by Galois.linutronix.de with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1hC5EV-0005jm-4g; Thu, 04 Apr 2019 18:28:55 +0200 Date: Thu, 4 Apr 2019 18:28:53 +0200 (CEST) From: Thomas Gleixner To: Tycho Andersen cc: Andy Lutomirski , Khalid Aziz , Juerg Haefliger , jsteckli@amazon.de, Andi Kleen , liran.alon@oracle.com, Kees Cook , Konrad Rzeszutek Wilk , deepa.srinivasan@oracle.com, chris hyser , Tyler Hicks , "Woodhouse, David" , Andrew Cooper , Jon Masters , Boris Ostrovsky , kanth.ghatraju@oracle.com, Joao Martins , Jim Mattson , pradeep.vincent@oracle.com, John Haxby , "Kirill A. Shutemov" , Christoph Hellwig , steven.sistare@oracle.com, Laura Abbott , Dave Hansen , Peter Zijlstra , Aaron Lu , Andrew Morton , alexander.h.duyck@linux.intel.com, Amir Goldstein , Andrey Konovalov , aneesh.kumar@linux.ibm.com, anthony.yznaga@oracle.com, Ard Biesheuvel , Arnd Bergmann , arunks@codeaurora.org, Ben Hutchings , Sebastian Andrzej Siewior , Borislav Petkov , brgl@bgdev.pl, Catalin Marinas , Jonathan Corbet , cpandya@codeaurora.org, Daniel Vetter , Dan Williams , Greg KH , Roman Gushchin , Johannes Weiner , "H. Peter Anvin" , Joonsoo Kim , James Morse , Jann Horn , Juergen Gross , Jiri Kosina , James Morris , Joe Perches , Souptick Joarder , Joerg Roedel , Keith Busch , Konstantin Khlebnikov , Logan Gunthorpe , marco.antonio.780@gmail.com, Mark Rutland , Mel Gorman , Michal Hocko , Michal Hocko , Mike Kravetz , Ingo Molnar , "Michael S. Tsirkin" , Marek Szyprowski , Nicholas Piggin , osalvador@suse.de, "Paul E. McKenney" , pavel.tatashin@microsoft.com, Randy Dunlap , richard.weiyang@gmail.com, "Serge E. Hallyn" , iommu@lists.linux-foundation.org, X86 ML , linux-arm-kernel , "open list:DOCUMENTATION" , LKML , Linux-MM , LSM List , Khalid Aziz Subject: Re: [RFC PATCH v9 02/13] x86: always set IF before oopsing from page fault In-Reply-To: <20190404154727.GA14030@cisco> Message-ID: References: <20190404013956.GA3365@cisco> <20190404154727.GA14030@cisco> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 4 Apr 2019, Tycho Andersen wrote: > leaq -PTREGS_SIZE(%rax), %rsp > UNWIND_HINT_FUNC sp_offset=PTREGS_SIZE > > + /* > + * If we oopsed in an interrupt handler, interrupts may be off. Let's turn > + * them back on before going back to "normal" code. > + */ > + sti That breaks the paravirt muck and tracing/lockdep. ENABLE_INTERRUPTS() is what you want plus TRACE_IRQ_ON to keep the tracer and lockdep happy. Thanks, tglx From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Gleixner Subject: Re: [RFC PATCH v9 02/13] x86: always set IF before oopsing from page fault Date: Thu, 4 Apr 2019 18:28:53 +0200 (CEST) Message-ID: References: <20190404013956.GA3365@cisco> <20190404154727.GA14030@cisco> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20190404154727.GA14030@cisco> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Tycho Andersen Cc: Mark Rutland , marco.antonio.780-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, Michal Hocko , LKML , Greg KH , Peter Zijlstra , Catalin Marinas , alexander.h.duyck-VuQAYsv1563Yd54FQh9/CA@public.gmane.org, Amir Goldstein , X86 ML , Keith Busch , Dave Hansen , Khalid Aziz , deepa.srinivasan-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org, steven.sistare-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org, cpandya-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, Borislav Petkov , Joao Martins , Christoph Hellwig , Michal Hocko , LSM List , Andi Kleen , "H. Peter Anvin" , "Michael S. Tsirkin" , Jonathan Corbet , aneesh.ku List-Id: iommu@lists.linux-foundation.org On Thu, 4 Apr 2019, Tycho Andersen wrote: > leaq -PTREGS_SIZE(%rax), %rsp > UNWIND_HINT_FUNC sp_offset=PTREGS_SIZE > > + /* > + * If we oopsed in an interrupt handler, interrupts may be off. Let's turn > + * them back on before going back to "normal" code. > + */ > + sti That breaks the paravirt muck and tracing/lockdep. ENABLE_INTERRUPTS() is what you want plus TRACE_IRQ_ON to keep the tracer and lockdep happy. Thanks, tglx