From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF990C10F0E for ; Thu, 18 Apr 2019 05:31:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9E5EF21479 for ; Thu, 18 Apr 2019 05:31:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732450AbfDRFbF (ORCPT ); Thu, 18 Apr 2019 01:31:05 -0400 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:28905 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725864AbfDRFbF (ORCPT ); Thu, 18 Apr 2019 01:31:05 -0400 X-IronPort-AV: E=Sophos;i="5.60,364,1549926000"; d="scan'208";a="379127868" Received: from abo-75-106-68.mrs.modulonet.fr (HELO hadrien) ([85.68.106.75]) by mail2-relais-roc.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Apr 2019 07:31:02 +0200 Date: Thu, 18 Apr 2019 07:31:02 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: Bjorn Helgaas cc: Sebastian Andrzej Siewior , kbuild-all@01.org, Kurt Schwemmer , Logan Gunthorpe , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Kirill Smelkov Subject: Re: [PATCH] pci/switchtec: fix stream_open.cocci warnings (fwd) In-Reply-To: <20190417215420.GV126710@google.com> Message-ID: References: <20190417215420.GV126710@google.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 17 Apr 2019, Bjorn Helgaas wrote: > On Sat, Apr 13, 2019 at 06:50:57PM +0200, Julia Lawall wrote: > > Hello, > > > > Kirill will explain about this issue. > > > > julia > > > > ---------- Forwarded message ---------- > > Date: Sat, 13 Apr 2019 11:22:51 +0800 > > From: kbuild test robot > > To: kbuild@01.org > > Cc: Julia Lawall > > Subject: [PATCH] pci/switchtec: fix stream_open.cocci warnings > > > > CC: kbuild-all@01.org > > TO: Sebastian Andrzej Siewior > > CC: Kurt Schwemmer > > CC: Logan Gunthorpe > > CC: Bjorn Helgaas > > CC: linux-pci@vger.kernel.org > > CC: linux-kernel@vger.kernel.org > > > > From: kbuild test robot > > > > drivers/pci/switch/switchtec.c:395:1-17: ERROR: switchtec_fops: .read() can deadlock .write(); change nonseekable_open -> stream_open to fix. > > > > Generated by: scripts/coccinelle/api/stream_open.cocci > > > > Fixes: 8a29a3bae2a2 ("pci/switchtec: Don't use completion's wait queue") > > Signed-off-by: kbuild test robot > > Based on Kirill's subsequent email saying this is already queued to > the merge window, I assume I need to do nothing here. > > I think a signed-off-by from a robot, i.e., not from a real person, is > meaningless, and I don't think I would personally accept it. It's > certainly OK to indicate that a patch was auto-generated, but I think > a real person still needs to take responsibility for it. > > Documentation/process/submitting-patches.rst says it must contain a > real name (no pseudonyms or anonymous contributions), and I don't > think a robot fits in the spirit of that. > > I see that > https://git.kernel.org/pub/scm/linux/kernel/git/rt/linux-rt-devel.git/commit/?id=8a29a3bae2a2 > (mentioned below) does have a good signed-off-by from Sebastian, but > that's not *this* patch, so I don't know what's what. Normally, for these robot generated patches, when I approve them, I put my own sign off, but under the robot one, since the robot has put a From line. In this case, I handed the problem off to Kirill, so I didn't do that. I agree that it would be good for Kirill to sign off on it. julia > > Bjorn > > > --- > > > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/rt/linux-rt-devel.git linux-5.0.y-rt-rebase > > head: 794c294ae4483c240429c25a0d18e272e92c94de > > commit: 8a29a3bae2a2dfb0116cd8791d9700515d6e765e [154/311] pci/switchtec: Don't use completion's wait queue > > :::::: branch date: 7 hours ago > > :::::: commit date: 7 hours ago > > > > Please take the patch only if it's a positive warning. Thanks! > > > > switchtec.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > --- a/drivers/pci/switch/switchtec.c > > +++ b/drivers/pci/switch/switchtec.c > > @@ -392,7 +392,7 @@ static int switchtec_dev_open(struct ino > > return PTR_ERR(stuser); > > > > filp->private_data = stuser; > > - nonseekable_open(inode, filp); > > + stream_open(inode, filp); > > > > dev_dbg(&stdev->dev, "%s: %p\n", __func__, stuser); > > >