From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA68DC04A6B for ; Mon, 29 Apr 2019 07:32:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C4D162063F for ; Mon, 29 Apr 2019 07:32:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727435AbfD2HcF (ORCPT ); Mon, 29 Apr 2019 03:32:05 -0400 Received: from Galois.linutronix.de ([146.0.238.70]:40722 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726846AbfD2HcE (ORCPT ); Mon, 29 Apr 2019 03:32:04 -0400 Received: from [5.158.153.52] (helo=nanos.tec.linutronix.de) by Galois.linutronix.de with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1hL0lK-00053O-Qd; Mon, 29 Apr 2019 09:31:43 +0200 Date: Mon, 29 Apr 2019 09:31:37 +0200 (CEST) From: Thomas Gleixner To: Xiaoyao Li cc: Fenghua Yu , Ingo Molnar , Borislav Petkov , H Peter Anvin , Paolo Bonzini , Dave Hansen , Ashok Raj , Peter Zijlstra , Ravi V Shankar , Christopherson Sean J , Kalle Valo , Michael Chan , linux-kernel , x86 , kvm@vger.kernel.org, netdev@vger.kernel.org, linux-wireless@vger.kernel.org Subject: Re: [PATCH v8 12/15] kvm/vmx: Emulate MSR TEST_CTL In-Reply-To: <87ef9a01-fc99-20be-ec20-2c65e6a012a1@linux.intel.com> Message-ID: References: <1556134382-58814-1-git-send-email-fenghua.yu@intel.com> <1556134382-58814-13-git-send-email-fenghua.yu@intel.com> <7395908840acfbf806146f5f20d3509342771a19.camel@linux.intel.com> <87ef9a01-fc99-20be-ec20-2c65e6a012a1@linux.intel.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Sun, 28 Apr 2019, Xiaoyao Li wrote: > On 4/28/2019 3:09 PM, Thomas Gleixner wrote: > > On Sat, 27 Apr 2019, Xiaoyao Li wrote: > > > Indeed, if we use split lock detection for protection purpose, when host > > > has it enabled we should directly pass it to guest and forbid guest from > > > disabling it. And only when host disables split lock detection, we can > > > expose it and allow the guest to turn it on. > > ? > > > If it is used for protection purpose, then it should follow what you said > > > and > > > this feature needs to be disabled by default. Because there are split lock > > > issues in old/current kernels and BIOS. That will cause the existing guest > > > booting failure and killed due to those split lock. > > > > Rightfully so. > > So, the patch 13 "Enable split lock detection by default" needs to be removed? Why? No. We enable it by default and everything which violates the rules gets what it deserves. If there is an issue, boot with ac_splitlock_off and be done with it. Thanks, tglx