From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E761C4321A for ; Tue, 11 Jun 2019 18:30:06 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F1DA920644 for ; Tue, 11 Jun 2019 18:30:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="U4cOokHa" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F1DA920644 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1halWm-0004Sn-1T; Tue, 11 Jun 2019 18:29:48 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1halWl-0004Sh-6j for xen-devel@lists.xenproject.org; Tue, 11 Jun 2019 18:29:47 +0000 X-Inumbo-ID: e313b6b4-8c76-11e9-a0d2-c766b889fd67 Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id e313b6b4-8c76-11e9-a0d2-c766b889fd67; Tue, 11 Jun 2019 18:29:45 +0000 (UTC) Received: from localhost (c-67-164-102-47.hsd1.ca.comcast.net [67.164.102.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E18E020644; Tue, 11 Jun 2019 18:29:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1560277785; bh=gBxapjcVP2zWsK6GIkvWR/M76Z3mpsDS1e4M/RjIovI=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=U4cOokHaBUFAXSLGferU+43wn1SAQfh+fSX5w/nRMhWzTde+JH8eDhe3N0bK11NxK MUYt8VZ66pNgpw+bSgyteTKsCHCJqp5YLBH0PBxmWYChgDKy46/m5femi8vKuoAc+t dDB3dSiWXU7E+ScX6clHolrx0OzYhttbrkUdEwGI= Date: Tue, 11 Jun 2019 11:29:44 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s To: Julien Grall In-Reply-To: <20190514123125.29086-4-julien.grall@arm.com> Message-ID: References: <20190514123125.29086-1-julien.grall@arm.com> <20190514123125.29086-4-julien.grall@arm.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Subject: Re: [Xen-devel] [PATCH MM-PART3 v2 03/12] xen/arm: mm: Move out of xen_pt_update() the logic to update an entry X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: xen-devel@lists.xenproject.org, Stefano Stabellini , Andrii Anisov , Oleksandr_Tyshchenko@epam.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" T24gVHVlLCAxNCBNYXkgMjAxOSwgSnVsaWVuIEdyYWxsIHdyb3RlOgo+IEluIHByZXBhcmF0aW9u IG9mIHJld29yayBvZiB0aGUgWGVuIFBULCB0aGUgbG9naWMgdG8gdXBkYXRlIGFuIGVudHJ5Cj4g aW4gbW92ZWQgb3V0IGluIGEgc2VwYXJhdGUgZnVuY3Rpb24uCj4gCj4gU2lnbmVkLW9mZi1ieTog SnVsaWVuIEdyYWxsIDxqdWxpZW4uZ3JhbGxAYXJtLmNvbT4KPiBSZXZpZXdlZC1ieTogQW5kcmlp IEFuaXNvdiA8YW5kcmlpX2FuaXNvdkBlcGFtLmNvbT4KClJldmlld2VkLWJ5OiBTdGVmYW5vIFN0 YWJlbGxpbmkgPHNzdGFiZWxsaW5pQGtlcm5lbC5vcmc+CgoKPiAtLS0KPiAgICAgQ2hhbmdlcyBp biB2MjoKPiAgICAgICAgIC0gQWRkIEFuZHJpaSdzIHJldmlld2VkLWJ5Cj4gLS0tCj4gIHhlbi9h cmNoL2FybS9tbS5jIHwgMTQwICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgNzQgaW5zZXJ0aW9ucygrKSwgNjYg ZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL3hlbi9hcmNoL2FybS9tbS5jIGIveGVuL2Fy Y2gvYXJtL21tLmMKPiBpbmRleCAzNmUyMmZjOWFkLi5mOTU2YWE2Mzk5IDEwMDY0NAo+IC0tLSBh L3hlbi9hcmNoL2FybS9tbS5jCj4gKysrIGIveGVuL2FyY2gvYXJtL21tLmMKPiBAQCAtOTY4LDYg Kzk2OCw3NiBAQCBlbnVtIHhlbm1hcF9vcGVyYXRpb24gewo+ICAgICAgUkVTRVJWRQo+ICB9Owo+ ICAKPiArc3RhdGljIGludCB4ZW5fcHRfdXBkYXRlX2VudHJ5KGVudW0geGVubWFwX29wZXJhdGlv biBvcCwgdW5zaWduZWQgbG9uZyBhZGRyLAo+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgbWZuX3QgbWZuLCB1bnNpZ25lZCBpbnQgZmxhZ3MpCj4gK3sKPiArICAgIGxwYWVfdCBwdGUs ICplbnRyeTsKPiArICAgIGxwYWVfdCAqdGhpcmQgPSBOVUxMOwo+ICsKPiArICAgIGVudHJ5ID0g Jnhlbl9zZWNvbmRbc2Vjb25kX2xpbmVhcl9vZmZzZXQoYWRkcildOwo+ICsgICAgaWYgKCAhbHBh ZV9pc192YWxpZCgqZW50cnkpIHx8ICFscGFlX2lzX3RhYmxlKCplbnRyeSwgMikgKQo+ICsgICAg ewo+ICsgICAgICAgIGludCByYyA9IGNyZWF0ZV94ZW5fdGFibGUoZW50cnkpOwo+ICsgICAgICAg IGlmICggcmMgPCAwICkgewo+ICsgICAgICAgICAgICBwcmludGsoIiVzOiBMMiBmYWlsZWRcbiIs IF9fZnVuY19fKTsKPiArICAgICAgICAgICAgcmV0dXJuIHJjOwo+ICsgICAgICAgIH0KPiArICAg IH0KPiArCj4gKyAgICBCVUdfT04oIWxwYWVfaXNfdmFsaWQoKmVudHJ5KSk7Cj4gKwo+ICsgICAg dGhpcmQgPSBtZm5fdG9fdmlydChscGFlX2dldF9tZm4oKmVudHJ5KSk7Cj4gKyAgICBlbnRyeSA9 ICZ0aGlyZFt0aGlyZF90YWJsZV9vZmZzZXQoYWRkcildOwo+ICsKPiArICAgIHN3aXRjaCAoIG9w ICkgewo+ICsgICAgICAgIGNhc2UgSU5TRVJUOgo+ICsgICAgICAgIGNhc2UgUkVTRVJWRToKPiAr ICAgICAgICAgICAgaWYgKCBscGFlX2lzX3ZhbGlkKCplbnRyeSkgKQo+ICsgICAgICAgICAgICB7 Cj4gKyAgICAgICAgICAgICAgICBwcmludGsoIiVzOiB0cnlpbmcgdG8gcmVwbGFjZSBhbiBleGlz dGluZyBtYXBwaW5nIGFkZHI9JWx4IG1mbj0lIlBSSV9tZm4iXG4iLAo+ICsgICAgICAgICAgICAg ICAgICAgICAgIF9fZnVuY19fLCBhZGRyLCBtZm5feChtZm4pKTsKPiArICAgICAgICAgICAgICAg IHJldHVybiAtRUlOVkFMOwo+ICsgICAgICAgICAgICB9Cj4gKyAgICAgICAgICAgIGlmICggb3Ag PT0gUkVTRVJWRSApCj4gKyAgICAgICAgICAgICAgICBicmVhazsKPiArICAgICAgICAgICAgcHRl ID0gbWZuX3RvX3hlbl9lbnRyeShtZm4sIFBBR0VfQUlfTUFTSyhmbGFncykpOwo+ICsgICAgICAg ICAgICBwdGUucHQucm8gPSBQQUdFX1JPX01BU0soZmxhZ3MpOwo+ICsgICAgICAgICAgICBwdGUu cHQueG4gPSBQQUdFX1hOX01BU0soZmxhZ3MpOwo+ICsgICAgICAgICAgICBCVUdfT04oIXB0ZS5w dC5ybyAmJiAhcHRlLnB0LnhuKTsKPiArICAgICAgICAgICAgcHRlLnB0LnRhYmxlID0gMTsKPiAr ICAgICAgICAgICAgd3JpdGVfcHRlKGVudHJ5LCBwdGUpOwo+ICsgICAgICAgICAgICBicmVhazsK PiArICAgICAgICBjYXNlIE1PRElGWToKPiArICAgICAgICBjYXNlIFJFTU9WRToKPiArICAgICAg ICAgICAgaWYgKCAhbHBhZV9pc192YWxpZCgqZW50cnkpICkKPiArICAgICAgICAgICAgewo+ICsg ICAgICAgICAgICAgICAgcHJpbnRrKCIlczogdHJ5aW5nIHRvICVzIGEgbm9uLWV4aXN0aW5nIG1h cHBpbmcgYWRkcj0lbHhcbiIsCj4gKyAgICAgICAgICAgICAgICAgICAgICAgX19mdW5jX18sIG9w ID09IFJFTU9WRSA/ICJyZW1vdmUiIDogIm1vZGlmeSIsIGFkZHIpOwo+ICsgICAgICAgICAgICAg ICAgcmV0dXJuIC1FSU5WQUw7Cj4gKyAgICAgICAgICAgIH0KPiArICAgICAgICAgICAgaWYgKCBv cCA9PSBSRU1PVkUgKQo+ICsgICAgICAgICAgICAgICAgcHRlLmJpdHMgPSAwOwo+ICsgICAgICAg ICAgICBlbHNlCj4gKyAgICAgICAgICAgIHsKPiArICAgICAgICAgICAgICAgIHB0ZSA9ICplbnRy eTsKPiArICAgICAgICAgICAgICAgIHB0ZS5wdC5ybyA9IFBBR0VfUk9fTUFTSyhmbGFncyk7Cj4g KyAgICAgICAgICAgICAgICBwdGUucHQueG4gPSBQQUdFX1hOX01BU0soZmxhZ3MpOwo+ICsgICAg ICAgICAgICAgICAgaWYgKCAhcHRlLnB0LnJvICYmICFwdGUucHQueG4gKQo+ICsgICAgICAgICAg ICAgICAgewo+ICsgICAgICAgICAgICAgICAgICAgIHByaW50aygiJXM6IEluY29ycmVjdCBjb21i aW5hdGlvbiBmb3IgYWRkcj0lbHhcbiIsCj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgIF9f ZnVuY19fLCBhZGRyKTsKPiArICAgICAgICAgICAgICAgICAgICByZXR1cm4gLUVJTlZBTDsKPiAr ICAgICAgICAgICAgICAgIH0KPiArICAgICAgICAgICAgfQo+ICsgICAgICAgICAgICB3cml0ZV9w dGUoZW50cnksIHB0ZSk7Cj4gKyAgICAgICAgICAgIGJyZWFrOwo+ICsgICAgICAgIGRlZmF1bHQ6 Cj4gKyAgICAgICAgICAgIEJVRygpOwo+ICsgICAgfQo+ICsKPiArICAgIHJldHVybiAwOwo+ICt9 Cj4gKwo+ICBzdGF0aWMgREVGSU5FX1NQSU5MT0NLKHhlbl9wdF9sb2NrKTsKPiAgCj4gIHN0YXRp YyBpbnQgeGVuX3B0X3VwZGF0ZShlbnVtIHhlbm1hcF9vcGVyYXRpb24gb3AsCj4gQEAgLTk3OCw3 OCArMTA0OCwxNiBAQCBzdGF0aWMgaW50IHhlbl9wdF91cGRhdGUoZW51bSB4ZW5tYXBfb3BlcmF0 aW9uIG9wLAo+ICB7Cj4gICAgICBpbnQgcmMgPSAwOwo+ICAgICAgdW5zaWduZWQgbG9uZyBhZGRy ID0gdmlydCwgYWRkcl9lbmQgPSBhZGRyICsgbnJfbWZucyAqIFBBR0VfU0laRTsKPiAtICAgIGxw YWVfdCBwdGUsICplbnRyeTsKPiAtICAgIGxwYWVfdCAqdGhpcmQgPSBOVUxMOwo+ICAKPiAgICAg IHNwaW5fbG9jaygmeGVuX3B0X2xvY2spOwo+ICAKPiAgICAgIGZvcig7IGFkZHIgPCBhZGRyX2Vu ZDsgYWRkciArPSBQQUdFX1NJWkUsIG1mbiA9IG1mbl9hZGQobWZuLCAxKSkKPiAgICAgIHsKPiAt ICAgICAgICBlbnRyeSA9ICZ4ZW5fc2Vjb25kW3NlY29uZF9saW5lYXJfb2Zmc2V0KGFkZHIpXTsK PiAtICAgICAgICBpZiAoICFscGFlX2lzX3ZhbGlkKCplbnRyeSkgfHwgIWxwYWVfaXNfdGFibGUo KmVudHJ5LCAyKSApCj4gLSAgICAgICAgewo+IC0gICAgICAgICAgICByYyA9IGNyZWF0ZV94ZW5f dGFibGUoZW50cnkpOwo+IC0gICAgICAgICAgICBpZiAoIHJjIDwgMCApIHsKPiAtICAgICAgICAg ICAgICAgIHByaW50aygiJXM6IEwyIGZhaWxlZFxuIiwgX19mdW5jX18pOwo+IC0gICAgICAgICAg ICAgICAgZ290byBvdXQ7Cj4gLSAgICAgICAgICAgIH0KPiAtICAgICAgICB9Cj4gLQo+IC0gICAg ICAgIEJVR19PTighbHBhZV9pc192YWxpZCgqZW50cnkpKTsKPiAtCj4gLSAgICAgICAgdGhpcmQg PSBtZm5fdG9fdmlydChscGFlX2dldF9tZm4oKmVudHJ5KSk7Cj4gLSAgICAgICAgZW50cnkgPSAm dGhpcmRbdGhpcmRfdGFibGVfb2Zmc2V0KGFkZHIpXTsKPiAtCj4gLSAgICAgICAgc3dpdGNoICgg b3AgKSB7Cj4gLSAgICAgICAgICAgIGNhc2UgSU5TRVJUOgo+IC0gICAgICAgICAgICBjYXNlIFJF U0VSVkU6Cj4gLSAgICAgICAgICAgICAgICBpZiAoIGxwYWVfaXNfdmFsaWQoKmVudHJ5KSApCj4g LSAgICAgICAgICAgICAgICB7Cj4gLSAgICAgICAgICAgICAgICAgICAgcHJpbnRrKCIlczogdHJ5 aW5nIHRvIHJlcGxhY2UgYW4gZXhpc3RpbmcgbWFwcGluZyBhZGRyPSVseCBtZm49JSJQUklfbWZu IlxuIiwKPiAtICAgICAgICAgICAgICAgICAgICAgICAgICAgX19mdW5jX18sIGFkZHIsIG1mbl94 KG1mbikpOwo+IC0gICAgICAgICAgICAgICAgICAgIHJjID0gLUVJTlZBTDsKPiAtICAgICAgICAg ICAgICAgICAgICBnb3RvIG91dDsKPiAtICAgICAgICAgICAgICAgIH0KPiAtICAgICAgICAgICAg ICAgIGlmICggb3AgPT0gUkVTRVJWRSApCj4gLSAgICAgICAgICAgICAgICAgICAgYnJlYWs7Cj4g LSAgICAgICAgICAgICAgICBwdGUgPSBtZm5fdG9feGVuX2VudHJ5KG1mbiwgUEFHRV9BSV9NQVNL KGZsYWdzKSk7Cj4gLSAgICAgICAgICAgICAgICBwdGUucHQucm8gPSBQQUdFX1JPX01BU0soZmxh Z3MpOwo+IC0gICAgICAgICAgICAgICAgcHRlLnB0LnhuID0gUEFHRV9YTl9NQVNLKGZsYWdzKTsK PiAtICAgICAgICAgICAgICAgIEJVR19PTighcHRlLnB0LnJvICYmICFwdGUucHQueG4pOwo+IC0g ICAgICAgICAgICAgICAgcHRlLnB0LnRhYmxlID0gMTsKPiAtICAgICAgICAgICAgICAgIHdyaXRl X3B0ZShlbnRyeSwgcHRlKTsKPiAtICAgICAgICAgICAgICAgIGJyZWFrOwo+IC0gICAgICAgICAg ICBjYXNlIE1PRElGWToKPiAtICAgICAgICAgICAgY2FzZSBSRU1PVkU6Cj4gLSAgICAgICAgICAg ICAgICBpZiAoICFscGFlX2lzX3ZhbGlkKCplbnRyeSkgKQo+IC0gICAgICAgICAgICAgICAgewo+ IC0gICAgICAgICAgICAgICAgICAgIHByaW50aygiJXM6IHRyeWluZyB0byAlcyBhIG5vbi1leGlz dGluZyBtYXBwaW5nIGFkZHI9JWx4XG4iLAo+IC0gICAgICAgICAgICAgICAgICAgICAgICAgICBf X2Z1bmNfXywgb3AgPT0gUkVNT1ZFID8gInJlbW92ZSIgOiAibW9kaWZ5IiwgYWRkcik7Cj4gLSAg ICAgICAgICAgICAgICAgICAgcmMgPSAtRUlOVkFMOwo+IC0gICAgICAgICAgICAgICAgICAgIGdv dG8gb3V0Owo+IC0gICAgICAgICAgICAgICAgfQo+IC0gICAgICAgICAgICAgICAgaWYgKCBvcCA9 PSBSRU1PVkUgKQo+IC0gICAgICAgICAgICAgICAgICAgIHB0ZS5iaXRzID0gMDsKPiAtICAgICAg ICAgICAgICAgIGVsc2UKPiAtICAgICAgICAgICAgICAgIHsKPiAtICAgICAgICAgICAgICAgICAg ICBwdGUgPSAqZW50cnk7Cj4gLSAgICAgICAgICAgICAgICAgICAgcHRlLnB0LnJvID0gUEFHRV9S T19NQVNLKGZsYWdzKTsKPiAtICAgICAgICAgICAgICAgICAgICBwdGUucHQueG4gPSBQQUdFX1hO X01BU0soZmxhZ3MpOwo+IC0gICAgICAgICAgICAgICAgICAgIGlmICggIXB0ZS5wdC5ybyAmJiAh cHRlLnB0LnhuICkKPiAtICAgICAgICAgICAgICAgICAgICB7Cj4gLSAgICAgICAgICAgICAgICAg ICAgICAgIHByaW50aygiJXM6IEluY29ycmVjdCBjb21iaW5hdGlvbiBmb3IgYWRkcj0lbHhcbiIs Cj4gLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBfX2Z1bmNfXywgYWRkcik7Cj4gLSAg ICAgICAgICAgICAgICAgICAgICAgIHJjID0gLUVJTlZBTDsKPiAtICAgICAgICAgICAgICAgICAg ICAgICAgZ290byBvdXQ7Cj4gLSAgICAgICAgICAgICAgICAgICAgfQo+IC0gICAgICAgICAgICAg ICAgfQo+IC0gICAgICAgICAgICAgICAgd3JpdGVfcHRlKGVudHJ5LCBwdGUpOwo+IC0gICAgICAg ICAgICAgICAgYnJlYWs7Cj4gLSAgICAgICAgICAgIGRlZmF1bHQ6Cj4gLSAgICAgICAgICAgICAg ICBCVUcoKTsKPiAtICAgICAgICB9Cj4gKyAgICAgICAgcmMgPSB4ZW5fcHRfdXBkYXRlX2VudHJ5 KG9wLCBhZGRyLCBtZm4sIGZsYWdzKTsKPiArICAgICAgICBpZiAoIHJjICkKPiArICAgICAgICAg ICAgYnJlYWs7Cj4gICAgICB9Cj4gLW91dDoKPiArCj4gICAgICAvKgo+ICAgICAgICogRmx1c2gg dGhlIFRMQnMgZXZlbiBpbiBjYXNlIG9mIGZhaWx1cmUgYmVjYXVzZSB3ZSBtYXkgaGF2ZQo+ICAg ICAgICogcGFydGlhbGx5IG1vZGlmaWVkIHRoZSBQVC4gVGhpcyB3aWxsIHByZXZlbnQgYW55IHVu ZXhwZWN0ZWQKPiAtLSAKPiAyLjExLjAKPiAKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fClhlbi1kZXZlbCBtYWlsaW5nIGxpc3QKWGVuLWRldmVsQGxpc3Rz LnhlbnByb2plY3Qub3JnCmh0dHBzOi8vbGlzdHMueGVucHJvamVjdC5vcmcvbWFpbG1hbi9saXN0 aW5mby94ZW4tZGV2ZWw=