From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8FF88C31E53 for ; Sun, 16 Jun 2019 08:50:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 69162216C8 for ; Sun, 16 Jun 2019 08:50:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726641AbfFPIpK (ORCPT ); Sun, 16 Jun 2019 04:45:10 -0400 Received: from Galois.linutronix.de ([146.0.238.70]:41623 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725990AbfFPIpK (ORCPT ); Sun, 16 Jun 2019 04:45:10 -0400 Received: from p5b06daab.dip0.t-ipconnect.de ([91.6.218.171] helo=nanos) by Galois.linutronix.de with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1hcQma-0007GQ-5m; Sun, 16 Jun 2019 10:45:00 +0200 Date: Sun, 16 Jun 2019 10:44:59 +0200 (CEST) From: Thomas Gleixner To: Miroslav Benes cc: jpoimboe@redhat.com, jikos@kernel.org, pmladek@suse.com, joe.lawrence@redhat.com, kamalesh@linux.vnet.ibm.com, live-patching@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 1/3] stacktrace: Remove weak version of save_stack_trace_tsk_reliable() In-Reply-To: <20190611141320.25359-2-mbenes@suse.cz> Message-ID: References: <20190611141320.25359-1-mbenes@suse.cz> <20190611141320.25359-2-mbenes@suse.cz> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 11 Jun 2019, Miroslav Benes wrote: > Recent rework of stack trace infrastructure introduced a new set of > helpers for common stack trace operations (commit e9b98e162aa5 > ("stacktrace: Provide helpers for common stack trace operations") and > related). As a result, save_stack_trace_tsk_reliable() is not directly > called anywhere. Livepatch, currently the only user of the reliable > stack trace feature, now calls stack_trace_save_tsk_reliable(). > > When CONFIG_HAVE_RELIABLE_STACKTRACE is set and depending on > CONFIG_ARCH_STACKWALK, stack_trace_save_tsk_reliable() calls either > arch_stack_walk_reliable() or mentioned save_stack_trace_tsk_reliable(). > x86_64 defines the former, ppc64le the latter. All other architectures > do not have HAVE_RELIABLE_STACKTRACE and include/linux/stacktrace.h > defines -ENOSYS returning version for them. > > In short, stack_trace_save_tsk_reliable() returning -ENOSYS defined in > include/linux/stacktrace.h serves the same purpose as the old weak > version of save_stack_trace_tsk_reliable() which is therefore no longer > needed. > > Cc: Thomas Gleixner > Signed-off-by: Miroslav Benes Reviewed-by: Thomas Gleixner