From: Thomas Gleixner <tglx@linutronix.de>
To: Hoan Tran OS <hoan@os.amperecomputing.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
Andrew Morton <akpm@linux-foundation.org>,
Michal Hocko <mhocko@suse.com>, Vlastimil Babka <vbabka@suse.cz>,
Oscar Salvador <osalvador@suse.de>,
Pavel Tatashin <pavel.tatashin@microsoft.com>,
Mike Rapoport <rppt@linux.ibm.com>,
Alexander Duyck <alexander.h.duyck@linux.intel.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
Michael Ellerman <mpe@ellerman.id.au>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
"H . Peter Anvin" <hpa@zytor.com>,
"David S . Miller" <davem@davemloft.net>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
Vasily Gorbik <gor@linux.ibm.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
"open list:MEMORY MANAGEMENT" <linux-mm@kvack.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-s390@vger.kernel.org" <linux-s390@vger.kernel.org>,
"sparclinux@vger.kernel.org" <sparclinux@vger.kernel.org>,
"x86@kernel.org" <x86@kernel.org>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Open Source Submission <patches@amperecomputing.com>
Subject: Re: [PATCH 3/5] x86: Kconfig: Remove CONFIG_NODES_SPAN_OTHER_NODES
Date: Wed, 10 Jul 2019 07:58:21 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.21.1907100755010.1758@nanos.tec.linutronix.de> (raw)
In-Reply-To: <1c5bc3a8-0c6f-dce3-95a2-8aec765408a2@os.amperecomputing.com>
Hoan,
On Wed, 10 Jul 2019, Hoan Tran OS wrote:
> On 6/25/19 3:45 PM, Thomas Gleixner wrote:
> > On Tue, 25 Jun 2019, Hoan Tran OS wrote:
> >> @@ -1567,15 +1567,6 @@ config X86_64_ACPI_NUMA
> >> ---help---
> >> Enable ACPI SRAT based node topology detection.
> >>
> >> -# Some NUMA nodes have memory ranges that span
> >> -# other nodes. Even though a pfn is valid and
> >> -# between a node's start and end pfns, it may not
> >> -# reside on that node. See memmap_init_zone()
> >> -# for details.
> >> -config NODES_SPAN_OTHER_NODES
> >> - def_bool y
> >> - depends on X86_64_ACPI_NUMA
> >
> > the changelog does not mention that this lifts the dependency on
> > X86_64_ACPI_NUMA and therefore enables that functionality for anything
> > which has NUMA enabled including 32bit.
> >
>
> I think this config is used for a NUMA layout which NUMA nodes addresses
> are spanned to other nodes. I think 32bit NUMA also have the same issue
> with that layout. Please correct me if I'm wrong.
I'm not saying you're wrong, but it's your duty to provide the analysis why
this is correct for everything which has NUMA enabled.
> > The core mm change gives no helpful information either. You just copied the
> > above comment text from some random Kconfig.
>
> Yes, as it's a correct comment and is used at multiple places.
Well it maybe correct in terms of explaining what this is about, it still
does not explain why this is needed by default on everything which has NUMA
enabled.
Thanks,
tglx
WARNING: multiple messages have this Message-ID (diff)
From: Thomas Gleixner <tglx@linutronix.de>
To: Hoan Tran OS <hoan@os.amperecomputing.com>
Cc: Michal Hocko <mhocko@suse.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
"open list:MEMORY MANAGEMENT" <linux-mm@kvack.org>,
Paul Mackerras <paulus@samba.org>,
"H . Peter Anvin" <hpa@zytor.com>,
"sparclinux@vger.kernel.org" <sparclinux@vger.kernel.org>,
Alexander Duyck <alexander.h.duyck@linux.intel.com>,
"linux-s390@vger.kernel.org" <linux-s390@vger.kernel.org>,
Michael Ellerman <mpe@ellerman.id.au>,
"x86@kernel.org" <x86@kernel.org>,
Mike Rapoport <rppt@linux.ibm.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
Ingo Molnar <mingo@redhat.com>, Vlastimil Babka <vbabka@suse.cz>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Open Source Submission <patches@amperecomputing.com>,
Pavel Tatashin <pavel.tatashin@microsoft.com>,
Vasily Gorbik <gor@linux.ibm.com>,
Will Deacon <will.deacon@arm.com>, Borislav Petkov <bp@alien8.de>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Oscar Salvador <osalvador@suse.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"David S . Miller" <davem@davemloft.net>
Subject: Re: [PATCH 3/5] x86: Kconfig: Remove CONFIG_NODES_SPAN_OTHER_NODES
Date: Wed, 10 Jul 2019 05:58:21 +0000 [thread overview]
Message-ID: <alpine.DEB.2.21.1907100755010.1758@nanos.tec.linutronix.de> (raw)
In-Reply-To: <1c5bc3a8-0c6f-dce3-95a2-8aec765408a2@os.amperecomputing.com>
Hoan,
On Wed, 10 Jul 2019, Hoan Tran OS wrote:
> On 6/25/19 3:45 PM, Thomas Gleixner wrote:
> > On Tue, 25 Jun 2019, Hoan Tran OS wrote:
> >> @@ -1567,15 +1567,6 @@ config X86_64_ACPI_NUMA
> >> ---help---
> >> Enable ACPI SRAT based node topology detection.
> >>
> >> -# Some NUMA nodes have memory ranges that span
> >> -# other nodes. Even though a pfn is valid and
> >> -# between a node's start and end pfns, it may not
> >> -# reside on that node. See memmap_init_zone()
> >> -# for details.
> >> -config NODES_SPAN_OTHER_NODES
> >> - def_bool y
> >> - depends on X86_64_ACPI_NUMA
> >
> > the changelog does not mention that this lifts the dependency on
> > X86_64_ACPI_NUMA and therefore enables that functionality for anything
> > which has NUMA enabled including 32bit.
> >
>
> I think this config is used for a NUMA layout which NUMA nodes addresses
> are spanned to other nodes. I think 32bit NUMA also have the same issue
> with that layout. Please correct me if I'm wrong.
I'm not saying you're wrong, but it's your duty to provide the analysis why
this is correct for everything which has NUMA enabled.
> > The core mm change gives no helpful information either. You just copied the
> > above comment text from some random Kconfig.
>
> Yes, as it's a correct comment and is used at multiple places.
Well it maybe correct in terms of explaining what this is about, it still
does not explain why this is needed by default on everything which has NUMA
enabled.
Thanks,
tglx
WARNING: multiple messages have this Message-ID (diff)
From: Thomas Gleixner <tglx@linutronix.de>
To: Hoan Tran OS <hoan@os.amperecomputing.com>
Cc: Michal Hocko <mhocko@suse.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
"open list:MEMORY MANAGEMENT" <linux-mm@kvack.org>,
Paul Mackerras <paulus@samba.org>,
"H . Peter Anvin" <hpa@zytor.com>,
"sparclinux@vger.kernel.org" <sparclinux@vger.kernel.org>,
Alexander Duyck <alexander.h.duyck@linux.intel.com>,
"linux-s390@vger.kernel.org" <linux-s390@vger.kernel.org>,
"x86@kernel.org" <x86@kernel.org>,
Mike Rapoport <rppt@linux.ibm.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
Ingo Molnar <mingo@redhat.com>, Vlastimil Babka <vbabka@suse.cz>,
Open Source Submission <patches@amperecomputing.com>,
Pavel Tatashin <pavel.tatashin@microsoft.com>,
Vasily Gorbik <gor@linux.ibm.com>,
Will Deacon <will.deacon@arm.com>, Borislav Petkov <bp@alien8.de>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Oscar Salvador <osalvador@suse.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"David S . Miller" <davem@davemloft.net>
Subject: Re: [PATCH 3/5] x86: Kconfig: Remove CONFIG_NODES_SPAN_OTHER_NODES
Date: Wed, 10 Jul 2019 07:58:21 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.21.1907100755010.1758@nanos.tec.linutronix.de> (raw)
In-Reply-To: <1c5bc3a8-0c6f-dce3-95a2-8aec765408a2@os.amperecomputing.com>
Hoan,
On Wed, 10 Jul 2019, Hoan Tran OS wrote:
> On 6/25/19 3:45 PM, Thomas Gleixner wrote:
> > On Tue, 25 Jun 2019, Hoan Tran OS wrote:
> >> @@ -1567,15 +1567,6 @@ config X86_64_ACPI_NUMA
> >> ---help---
> >> Enable ACPI SRAT based node topology detection.
> >>
> >> -# Some NUMA nodes have memory ranges that span
> >> -# other nodes. Even though a pfn is valid and
> >> -# between a node's start and end pfns, it may not
> >> -# reside on that node. See memmap_init_zone()
> >> -# for details.
> >> -config NODES_SPAN_OTHER_NODES
> >> - def_bool y
> >> - depends on X86_64_ACPI_NUMA
> >
> > the changelog does not mention that this lifts the dependency on
> > X86_64_ACPI_NUMA and therefore enables that functionality for anything
> > which has NUMA enabled including 32bit.
> >
>
> I think this config is used for a NUMA layout which NUMA nodes addresses
> are spanned to other nodes. I think 32bit NUMA also have the same issue
> with that layout. Please correct me if I'm wrong.
I'm not saying you're wrong, but it's your duty to provide the analysis why
this is correct for everything which has NUMA enabled.
> > The core mm change gives no helpful information either. You just copied the
> > above comment text from some random Kconfig.
>
> Yes, as it's a correct comment and is used at multiple places.
Well it maybe correct in terms of explaining what this is about, it still
does not explain why this is needed by default on everything which has NUMA
enabled.
Thanks,
tglx
WARNING: multiple messages have this Message-ID (diff)
From: Thomas Gleixner <tglx@linutronix.de>
To: Hoan Tran OS <hoan@os.amperecomputing.com>
Cc: Michal Hocko <mhocko@suse.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
"open list:MEMORY MANAGEMENT" <linux-mm@kvack.org>,
Paul Mackerras <paulus@samba.org>,
"H . Peter Anvin" <hpa@zytor.com>,
"sparclinux@vger.kernel.org" <sparclinux@vger.kernel.org>,
Alexander Duyck <alexander.h.duyck@linux.intel.com>,
"linux-s390@vger.kernel.org" <linux-s390@vger.kernel.org>,
Michael Ellerman <mpe@ellerman.id.au>,
"x86@kernel.org" <x86@kernel.org>,
Mike Rapoport <rppt@linux.ibm.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
Ingo Molnar <mingo@redhat.com>, Vlastimil Babka <vbabka@suse.cz>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Open Source Submission <patches@amperecomputing.com>,
Pavel Tatashin <pavel.tatashin@microsoft.com>,
Vasily Gorbik <gor@linux.ibm.com>,
Will Deacon <will.deacon@arm.com>, Borislav Petkov <bp@alien8.de>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Oscar Salvador <osalvador@suse.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"David S . Miller" <davem@davemloft.net>
Subject: Re: [PATCH 3/5] x86: Kconfig: Remove CONFIG_NODES_SPAN_OTHER_NODES
Date: Wed, 10 Jul 2019 07:58:21 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.21.1907100755010.1758@nanos.tec.linutronix.de> (raw)
In-Reply-To: <1c5bc3a8-0c6f-dce3-95a2-8aec765408a2@os.amperecomputing.com>
Hoan,
On Wed, 10 Jul 2019, Hoan Tran OS wrote:
> On 6/25/19 3:45 PM, Thomas Gleixner wrote:
> > On Tue, 25 Jun 2019, Hoan Tran OS wrote:
> >> @@ -1567,15 +1567,6 @@ config X86_64_ACPI_NUMA
> >> ---help---
> >> Enable ACPI SRAT based node topology detection.
> >>
> >> -# Some NUMA nodes have memory ranges that span
> >> -# other nodes. Even though a pfn is valid and
> >> -# between a node's start and end pfns, it may not
> >> -# reside on that node. See memmap_init_zone()
> >> -# for details.
> >> -config NODES_SPAN_OTHER_NODES
> >> - def_bool y
> >> - depends on X86_64_ACPI_NUMA
> >
> > the changelog does not mention that this lifts the dependency on
> > X86_64_ACPI_NUMA and therefore enables that functionality for anything
> > which has NUMA enabled including 32bit.
> >
>
> I think this config is used for a NUMA layout which NUMA nodes addresses
> are spanned to other nodes. I think 32bit NUMA also have the same issue
> with that layout. Please correct me if I'm wrong.
I'm not saying you're wrong, but it's your duty to provide the analysis why
this is correct for everything which has NUMA enabled.
> > The core mm change gives no helpful information either. You just copied the
> > above comment text from some random Kconfig.
>
> Yes, as it's a correct comment and is used at multiple places.
Well it maybe correct in terms of explaining what this is about, it still
does not explain why this is needed by default on everything which has NUMA
enabled.
Thanks,
tglx
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-07-10 5:59 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-25 22:30 [PATCH 0/5] Enable CONFIG_NODES_SPAN_OTHER_NODES by default for NUMA Hoan Tran OS
2019-06-25 22:30 ` Hoan Tran OS
2019-06-25 22:30 ` Hoan Tran OS
2019-06-25 22:30 ` Hoan Tran OS
2019-06-25 22:30 ` Hoan Tran OS
2019-06-25 22:30 ` [PATCH 1/5] mm: " Hoan Tran OS
2019-06-25 22:30 ` Hoan Tran OS
2019-06-25 22:30 ` Hoan Tran OS
2019-06-25 22:30 ` Hoan Tran OS
2019-06-25 22:30 ` Hoan Tran OS
2019-06-26 6:11 ` Michal Hocko
2019-06-26 6:11 ` Michal Hocko
2019-06-26 6:11 ` Michal Hocko
2019-06-26 6:11 ` Michal Hocko
2019-06-26 6:11 ` Michal Hocko
2019-06-25 22:30 ` [PATCH 2/5] powerpc: Kconfig: Remove CONFIG_NODES_SPAN_OTHER_NODES Hoan Tran OS
2019-06-25 22:30 ` Hoan Tran OS
2019-06-25 22:30 ` Hoan Tran OS
2019-06-25 22:30 ` Hoan Tran OS
2019-06-25 22:30 ` Hoan Tran OS
2019-06-25 22:30 ` [PATCH 3/5] x86: " Hoan Tran OS
2019-06-25 22:30 ` Hoan Tran OS
2019-06-25 22:30 ` Hoan Tran OS
2019-06-25 22:30 ` Hoan Tran OS
2019-06-25 22:30 ` Hoan Tran OS
2019-06-25 22:45 ` Thomas Gleixner
2019-06-25 22:45 ` Thomas Gleixner
2019-06-25 22:45 ` Thomas Gleixner
2019-06-25 22:45 ` Thomas Gleixner
2019-06-25 22:45 ` Thomas Gleixner
2019-06-25 22:45 ` Thomas Gleixner
2019-07-10 0:34 ` Hoan Tran OS
2019-07-10 0:34 ` Hoan Tran OS
2019-07-10 0:34 ` Hoan Tran OS
2019-07-10 0:34 ` Hoan Tran OS
2019-07-10 0:34 ` Hoan Tran OS
2019-07-10 5:58 ` Thomas Gleixner [this message]
2019-07-10 5:58 ` Thomas Gleixner
2019-07-10 5:58 ` Thomas Gleixner
2019-07-10 5:58 ` Thomas Gleixner
2019-07-10 5:58 ` Thomas Gleixner
2019-07-10 5:58 ` Thomas Gleixner
2019-07-10 6:14 ` Hoan Tran OS
2019-07-10 6:14 ` Hoan Tran OS
2019-07-10 6:14 ` Hoan Tran OS
2019-07-10 6:14 ` Hoan Tran OS
2019-07-10 6:14 ` Hoan Tran OS
2019-06-25 22:30 ` [PATCH 4/5] sparc: " Hoan Tran OS
2019-06-25 22:30 ` Hoan Tran OS
2019-06-25 22:30 ` Hoan Tran OS
2019-06-25 22:30 ` Hoan Tran OS
2019-06-25 22:30 ` Hoan Tran OS
2019-06-25 22:30 ` [PATCH 5/5] s390: " Hoan Tran OS
2019-06-25 22:30 ` Hoan Tran OS
2019-06-25 22:30 ` Hoan Tran OS
2019-06-25 22:30 ` Hoan Tran OS
2019-06-25 22:30 ` Hoan Tran OS
2019-06-26 0:28 ` [PATCH 0/5] Enable CONFIG_NODES_SPAN_OTHER_NODES by default for NUMA Linus Torvalds
2019-06-26 0:28 ` Linus Torvalds
2019-06-26 0:28 ` Linus Torvalds
2019-06-26 0:28 ` Linus Torvalds
2019-06-26 0:28 ` Linus Torvalds
2019-06-26 0:28 ` Linus Torvalds
2019-06-27 11:17 ` Aaron Lindsay OS
2019-06-27 11:17 ` Aaron Lindsay OS
2019-06-27 11:17 ` Aaron Lindsay OS
2019-06-27 11:17 ` Aaron Lindsay OS
2019-06-27 11:17 ` Aaron Lindsay OS
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.1907100755010.1758@nanos.tec.linutronix.de \
--to=tglx@linutronix.de \
--cc=akpm@linux-foundation.org \
--cc=alexander.h.duyck@linux.intel.com \
--cc=benh@kernel.crashing.org \
--cc=borntraeger@de.ibm.com \
--cc=bp@alien8.de \
--cc=catalin.marinas@arm.com \
--cc=davem@davemloft.net \
--cc=gor@linux.ibm.com \
--cc=heiko.carstens@de.ibm.com \
--cc=hoan@os.amperecomputing.com \
--cc=hpa@zytor.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-s390@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mhocko@suse.com \
--cc=mingo@redhat.com \
--cc=mpe@ellerman.id.au \
--cc=osalvador@suse.de \
--cc=patches@amperecomputing.com \
--cc=paulus@samba.org \
--cc=pavel.tatashin@microsoft.com \
--cc=rppt@linux.ibm.com \
--cc=sparclinux@vger.kernel.org \
--cc=vbabka@suse.cz \
--cc=will.deacon@arm.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.