From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9601C7618B for ; Thu, 25 Jul 2019 13:48:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A90AD22BEF for ; Thu, 25 Jul 2019 13:48:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390572AbfGYNsg (ORCPT ); Thu, 25 Jul 2019 09:48:36 -0400 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:54090 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389122AbfGYNsg (ORCPT ); Thu, 25 Jul 2019 09:48:36 -0400 X-IronPort-AV: E=Sophos;i="5.64,306,1559512800"; d="scan'208";a="393302470" Received: from c-73-22-29-55.hsd1.il.comcast.net (HELO hadrien) ([73.22.29.55]) by mail2-relais-roc.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Jul 2019 15:48:32 +0200 Date: Thu, 25 Jul 2019 08:48:30 -0500 (CDT) From: Julia Lawall X-X-Sender: jll@hadrien To: Markus Elfring cc: cocci@systeme.lip6.fr, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, David Laight , Joe Perches Subject: Re: [PATCH 1/2] string: Add stracpy and stracpy_pad mechanisms In-Reply-To: <7e489aa8-95ea-b3b0-9023-ba284212977f@web.de> Message-ID: References: <7e489aa8-95ea-b3b0-9023-ba284212977f@web.de> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 25 Jul 2019, Markus Elfring wrote: > > @r@ > > identifier f,i1,i2; > > struct i1 e1; > > expression e2; > > position p; > > @@ > > \(strscpy\|strlcpy\)(e1.f, e2, i2)@p > > I have got the impression that the replacement can work also > without an inherited position variable at the end. > How do you think about to omit this SmPL rule then? > > Can it be nicer to reduce duplicate SmPL code a bit? Huh? Rule 2 is important, to ensure that ths size is correct. Without rule 1, how can rule 2 be checked? julia From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julia Lawall Date: Thu, 25 Jul 2019 13:48:30 +0000 Subject: Re: [PATCH 1/2] string: Add stracpy and stracpy_pad mechanisms Message-Id: List-Id: References: <7e489aa8-95ea-b3b0-9023-ba284212977f@web.de> In-Reply-To: <7e489aa8-95ea-b3b0-9023-ba284212977f@web.de> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Markus Elfring Cc: Joe Perches , David Laight , kernel-janitors@vger.kernel.org, cocci@systeme.lip6.fr, linux-kernel@vger.kernel.org On Thu, 25 Jul 2019, Markus Elfring wrote: > > @r@ > > identifier f,i1,i2; > > struct i1 e1; > > expression e2; > > position p; > > @@ > > \(strscpy\|strlcpy\)(e1.f, e2, i2)@p > > I have got the impression that the replacement can work also > without an inherited position variable at the end. > How do you think about to omit this SmPL rule then? > > Can it be nicer to reduce duplicate SmPL code a bit? Huh? Rule 2 is important, to ensure that ths size is correct. Without rule 1, how can rule 2 be checked? julia From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D5FFC76194 for ; Thu, 25 Jul 2019 13:48:50 +0000 (UTC) Received: from isis.lip6.fr (isis.lip6.fr [132.227.60.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 08F0722BEF for ; Thu, 25 Jul 2019 13:48:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 08F0722BEF Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lip6.fr Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=cocci-bounces@systeme.lip6.fr Received: from systeme.lip6.fr (systeme.lip6.fr [132.227.104.7]) by isis.lip6.fr (8.15.2/8.15.2) with ESMTP id x6PDma9P000972; Thu, 25 Jul 2019 15:48:36 +0200 (CEST) Received: from systeme.lip6.fr (systeme.lip6.fr [127.0.0.1]) by systeme.lip6.fr (Postfix) with ESMTP id 64AAD777C; Thu, 25 Jul 2019 15:48:36 +0200 (CEST) Received: from isis.lip6.fr (isis.lip6.fr [132.227.60.2]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by systeme.lip6.fr (Postfix) with ESMTPS id B9D3D76BF for ; Thu, 25 Jul 2019 15:48:34 +0200 (CEST) Received: from mail2-relais-roc.national.inria.fr (mail2-relais-roc.national.inria.fr [192.134.164.83]) by isis.lip6.fr (8.15.2/8.15.2) with ESMTP id x6PDmYJC018781 for ; Thu, 25 Jul 2019 15:48:34 +0200 (CEST) X-IronPort-AV: E=Sophos;i="5.64,306,1559512800"; d="scan'208";a="393302470" Received: from c-73-22-29-55.hsd1.il.comcast.net (HELO hadrien) ([73.22.29.55]) by mail2-relais-roc.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Jul 2019 15:48:32 +0200 Date: Thu, 25 Jul 2019 08:48:30 -0500 (CDT) From: Julia Lawall X-X-Sender: jll@hadrien To: Markus Elfring In-Reply-To: <7e489aa8-95ea-b3b0-9023-ba284212977f@web.de> Message-ID: References: <7e489aa8-95ea-b3b0-9023-ba284212977f@web.de> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 X-Greylist: Sender IP whitelisted, Sender e-mail whitelisted, not delayed by milter-greylist-4.4.3 (isis.lip6.fr [132.227.60.2]); Thu, 25 Jul 2019 15:48:36 +0200 (CEST) X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.4.3 (isis.lip6.fr [132.227.60.2]); Thu, 25 Jul 2019 15:48:34 +0200 (CEST) X-Scanned-By: MIMEDefang 2.78 on 132.227.60.2 X-Scanned-By: MIMEDefang 2.78 on 132.227.60.2 Cc: Joe Perches , David Laight , kernel-janitors@vger.kernel.org, cocci@systeme.lip6.fr, linux-kernel@vger.kernel.org Subject: Re: [Cocci] [PATCH 1/2] string: Add stracpy and stracpy_pad mechanisms X-BeenThere: cocci@systeme.lip6.fr X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: cocci-bounces@systeme.lip6.fr Errors-To: cocci-bounces@systeme.lip6.fr On Thu, 25 Jul 2019, Markus Elfring wrote: > > @r@ > > identifier f,i1,i2; > > struct i1 e1; > > expression e2; > > position p; > > @@ > > \(strscpy\|strlcpy\)(e1.f, e2, i2)@p > > I have got the impression that the replacement can work also > without an inherited position variable at the end. > How do you think about to omit this SmPL rule then? > > Can it be nicer to reduce duplicate SmPL code a bit? Huh? Rule 2 is important, to ensure that ths size is correct. Without rule 1, how can rule 2 be checked? julia _______________________________________________ Cocci mailing list Cocci@systeme.lip6.fr https://systeme.lip6.fr/mailman/listinfo/cocci