All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Santosh Sivaraj <santosh@fossix.org>
Cc: x86@kernel.org, Linux Kernel <linux-kernel@vger.kernel.org>,
	"H. Peter Anvin" <hpa@zytor.com>,
	"Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com>
Subject: Re: [PATCH] x86/mce: Remove redundant irq work
Date: Tue, 30 Jul 2019 10:44:34 +0200 (CEST)	[thread overview]
Message-ID: <alpine.DEB.2.21.1907301042190.1738@nanos.tec.linutronix.de> (raw)
In-Reply-To: <20190730061520.19953-1-santosh@fossix.org>

On Tue, 30 Jul 2019, Santosh Sivaraj wrote:

> IRQ work currently only does a schedule work to process the mce
> events. Since irq work does no other function, remove it.

No. You _cannot call schedule_work() from MCE exception context as MCE can
interrupt even interrupt disabled context similar to NMI. irq work is
designed to work in those contexts.

Thanks,

	tglx

      parent reply	other threads:[~2019-07-30  8:44 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-30  6:15 [PATCH] x86/mce: Remove redundant irq work Santosh Sivaraj
2019-07-30  8:19 ` Peter Zijlstra
2019-07-30  8:44 ` Thomas Gleixner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.21.1907301042190.1738@nanos.tec.linutronix.de \
    --to=tglx@linutronix.de \
    --cc=aneesh.kumar@linux.ibm.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=santosh@fossix.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.