From: Thomas Gleixner <tglx@linutronix.de>
To: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
Cc: Michael Kelley <mikelley@microsoft.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"boqun.feng" <boqun.feng@gmail.com>,
kimbrownkd <kimbrownkd@gmail.com>
Subject: Re: [PATCH 1/1] genirq: Properly pair kobject_del with kobject_add
Date: Sat, 3 Aug 2019 09:43:01 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.21.1908030942180.4029@nanos.tec.linutronix.de> (raw)
In-Reply-To: <20190803071555.GB24757@kroah.com>
On Sat, 3 Aug 2019, gregkh@linuxfoundation.org wrote:
> On Fri, Aug 02, 2019 at 08:19:37PM +0000, Michael Kelley wrote:
> > > Relying on irq_kobj_base to be present or not seems like an odd test
> > > here.
> > >
> >
> > It's the same test that is used in irq_sysfs_add to decide whether to
> > call kobject_add. So it makes everything paired up and symmetrical.
>
> Ugh, that's a tangled mess and totally not obvious at all. I'm sure
> there's a good reason for all of that, and I really don't want to know
> :)
It's all your fault that the sysfs stuff does not work in very early boot.
/me runs
next prev parent reply other threads:[~2019-08-03 7:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1564703564-4116-1-git-send-email-mikelley@microsoft.com>
2019-08-02 6:34 ` [PATCH 1/1] genirq: Properly pair kobject_del with kobject_add gregkh
[not found] ` <MWHPR21MB078463AB854A336842118405D7D90@MWHPR21MB0784.namprd21.prod.outlook.com>
2019-08-03 7:15 ` gregkh
2019-08-03 7:43 ` Thomas Gleixner [this message]
2019-08-19 14:01 ` [tip:irq/urgent] genirq: Properly pair kobject_del() with kobject_add() tip-bot for Michael Kelley
[not found] ` <20190819212758.6D03D22CEC@mail.kernel.org>
2019-08-19 21:58 ` Michael Kelley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.1908030942180.4029@nanos.tec.linutronix.de \
--to=tglx@linutronix.de \
--cc=boqun.feng@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=kimbrownkd@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mikelley@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.