From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 917D3C3A589 for ; Tue, 20 Aug 2019 08:54:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 688BE22DBF for ; Tue, 20 Aug 2019 08:54:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729540AbfHTIyO (ORCPT ); Tue, 20 Aug 2019 04:54:14 -0400 Received: from Galois.linutronix.de ([193.142.43.55]:51162 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729342AbfHTIyL (ORCPT ); Tue, 20 Aug 2019 04:54:11 -0400 Received: from p5de0b6c5.dip0.t-ipconnect.de ([93.224.182.197] helo=nanos) by Galois.linutronix.de with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1hzztv-0007fA-Do; Tue, 20 Aug 2019 10:53:59 +0200 Date: Tue, 20 Aug 2019 10:53:58 +0200 (CEST) From: Thomas Gleixner To: Jisheng Zhang cc: Catalin Marinas , Jonathan Corbet , Will Deacon , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , "x86@kernel.org" , "Naveen N. Rao" , Anil S Keshavamurthy , "David S. Miller" , Masami Hiramatsu , "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH v2 1/3] kprobes/x86: use instruction_pointer and instruction_pointer_set In-Reply-To: <20190820114109.4624d56b@xhacker.debian> Message-ID: References: <20190820113928.1971900c@xhacker.debian> <20190820114109.4624d56b@xhacker.debian> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 20 Aug 2019, Jisheng Zhang wrote: > This is to make the x86 kprobe_ftrace_handler() more common so that > the code could be reused in future. While I agree with the change in general, I can't find anything which reuses that code. So the change log is pretty useless and I have no idea how this is related to the rest of the series. Thanks, tglx From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F070C3A589 for ; Tue, 20 Aug 2019 08:54:23 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 62A1822DCB for ; Tue, 20 Aug 2019 08:54:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="JNukjDUh" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 62A1822DCB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linutronix.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:Message-ID: In-Reply-To:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=npj58lVW8BQDtSKrbQBsC965qMlIfTPejbHitAnSalw=; b=JNukjDUhfJAZ4k ayDCV70j47LJdxvaNmEcTirbAfnt/vZO/3U/W+waM5xDcSe64ZBJ1YYnLiBR7jSJmQjJlCXT8XVKB XK3au4rkRubLbssLVXGvl9CnEpLWc32C0dPMBdOao2Jyy1DkE+z9p8/JmcbBV9dTBRYNUyvYLo9Wl mNCz8Nh+wnoYRJRDfkM6+Ofd01E/HfP0c3zNthgs8w+hzGlmKRdAc1BJQctGTmUojoyjicvPiCpiR wOpzfVQiMp4AeNex501HRzuIrHy0CHH3d4qTVtS1+W4Phi/FnptdRzo22PRxHw5Oi6Nu9XifH1dRZ q4l6d94P7qJLFVDtTrng==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hzzuD-0004Ex-6J; Tue, 20 Aug 2019 08:54:17 +0000 Received: from galois.linutronix.de ([2a0a:51c0:0:12e:550::1]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hzzu8-0004DA-GA for linux-arm-kernel@lists.infradead.org; Tue, 20 Aug 2019 08:54:14 +0000 Received: from p5de0b6c5.dip0.t-ipconnect.de ([93.224.182.197] helo=nanos) by Galois.linutronix.de with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1hzztv-0007fA-Do; Tue, 20 Aug 2019 10:53:59 +0200 Date: Tue, 20 Aug 2019 10:53:58 +0200 (CEST) From: Thomas Gleixner To: Jisheng Zhang Subject: Re: [PATCH v2 1/3] kprobes/x86: use instruction_pointer and instruction_pointer_set In-Reply-To: <20190820114109.4624d56b@xhacker.debian> Message-ID: References: <20190820113928.1971900c@xhacker.debian> <20190820114109.4624d56b@xhacker.debian> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1, SHORTCIRCUIT=-0.0001 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190820_015412_755020_8473A3BD X-CRM114-Status: GOOD ( 11.91 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jonathan Corbet , Catalin Marinas , "x86@kernel.org" , "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Anil S Keshavamurthy , Ingo Molnar , Borislav Petkov , Masami Hiramatsu , "H. Peter Anvin" , "Naveen N. Rao" , Will Deacon , "David S. Miller" , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 20 Aug 2019, Jisheng Zhang wrote: > This is to make the x86 kprobe_ftrace_handler() more common so that > the code could be reused in future. While I agree with the change in general, I can't find anything which reuses that code. So the change log is pretty useless and I have no idea how this is related to the rest of the series. Thanks, tglx _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel