All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: "Thomas Hellström (VMware)" <thomas_os@shipmail.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
	linux-kernel@vger.kernel.org, pv-drivers@vmware.com,
	Thomas Hellstrom <thellstrom@vmware.com>,
	Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
	"H. Peter Anvin" <hpa@zytor.com>,
	x86@kernel.org, Doug Covelli <dcovelli@vmware.com>
Subject: Re: [PATCH 2/4] x86/vmware: Add a header file for hypercall definitions
Date: Tue, 20 Aug 2019 21:23:01 +0200 (CEST)	[thread overview]
Message-ID: <alpine.DEB.2.21.1908202122420.2223@nanos.tec.linutronix.de> (raw)
In-Reply-To: <e7002524-2572-57af-176a-d6b924c98738@shipmail.org>

[-- Attachment #1: Type: text/plain, Size: 848 bytes --]

On Tue, 20 Aug 2019, Thomas Hellström (VMware) wrote:
> On 8/20/19 3:42 PM, Thomas Gleixner wrote:
> > > What confuses me a bit is, if it's clarity we're after, why don't people
> > > use
> > > 
> > > #define VMWARE_HYPERCALL 					\
> > > 	ALTERNATIVE_2("inl (%%dx)", 				\
> > > 		      "vmcall", X86_FEATURE_VMW_VMCALL,		\	
> > > 		      "vmmcall", X86_FEATURE_VMW_VMMCALL)
> > > 
> > > Seems to build fine here. Is it fear of old assemblers not supporting, for
> > > example vmmcall
> > The requirement for binutils is version >= 2.21. If 2.21 supports vmcall and
> > vmmcall all good.
> > 
> > Thanks,
> > 
> > 	tglx
> 
> So I tested 2.20.1 and 2.21.1 from ftp.gnu.org/gnu/binutils, and both seem to
> assemble (as-new) and disassemble (objdump -S) vmcall and vmmcall fine so I
> think we should be OK using the mnemonic format then.

Perfect!

  reply	other threads:[~2019-08-20 19:23 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-18 14:33 [PATCH 0/4] Add support for updated vmware hypercall instruction Thomas Hellström (VMware)
2019-08-18 14:33 ` [PATCH 1/4] x86/vmware: Update platform detection code for VMCALL/VMMCALL hypercalls Thomas Hellström (VMware)
2019-08-18 19:20   ` Thomas Gleixner
2019-08-18 19:46     ` Thomas Hellström (VMware)
2019-08-20 17:18     ` [Pv-drivers] " Darren Hart
2019-08-18 14:33 ` [PATCH 2/4] x86/vmware: Add a header file for hypercall definitions Thomas Hellström (VMware)
2019-08-18 20:19   ` Borislav Petkov
2019-08-18 20:39     ` Borislav Petkov
2019-08-18 22:28     ` Thomas Hellström (VMware)
2019-08-19  6:25       ` Borislav Petkov
2019-08-19  7:49         ` Thomas Hellström (VMware)
2019-08-20 11:32   ` Peter Zijlstra
2019-08-20 13:34     ` Thomas Hellström (VMware)
2019-08-20 13:42       ` Thomas Gleixner
2019-08-20 19:19         ` Thomas Hellström (VMware)
2019-08-20 19:23           ` Thomas Gleixner [this message]
2019-08-18 14:33 ` [PATCH 3/4] drm/vmwgfx: Update the backdoor call with support for new instructions Thomas Hellström (VMware)
2019-08-18 14:33 ` [PATCH 4/4] input/vmmouse: " Thomas Hellström (VMware)
2019-08-21  5:09   ` Dmitry Torokhov
2019-08-21 15:48     ` Thomas Hellström (VMware)
2019-08-21 16:03       ` Dmitry Torokhov
2019-08-18 18:09 ` [PATCH 0/4] Add support for updated vmware hypercall instruction Borislav Petkov
2019-08-18 19:02   ` Thomas Hellström (VMware)
2019-08-18 19:37     ` Borislav Petkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.21.1908202122420.2223@nanos.tec.linutronix.de \
    --to=tglx@linutronix.de \
    --cc=bp@alien8.de \
    --cc=dcovelli@vmware.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=pv-drivers@vmware.com \
    --cc=thellstrom@vmware.com \
    --cc=thomas_os@shipmail.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.