From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54F03C3A5A1 for ; Wed, 28 Aug 2019 18:09:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 28B9522CF8 for ; Wed, 28 Aug 2019 18:09:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1567015790; bh=pEW7d4+ki1j7cGrysUa/rs6+n6aWIK6WXN6/tbYAFzs=; h=Date:From:To:cc:Subject:In-Reply-To:References:List-ID:From; b=yoCZtG3l25hqZFJ1cYuh1iUIxlzubwOwiAQ0D39d03pLL7rsZg1fGgme7+MyP/6Re zA//ZGF4dzyOnhXhw0M5wQt1qwyWmIv9ME3RGQ578w3qMegv+Ckk5B1a/t58mn4OEB LhYRZEvMic+duUjAiu0rvuqFe0qnrlU4mm3gi6kw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726892AbfH1SJt (ORCPT ); Wed, 28 Aug 2019 14:09:49 -0400 Received: from mail.kernel.org ([198.145.29.99]:51990 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726554AbfH1SJs (ORCPT ); Wed, 28 Aug 2019 14:09:48 -0400 Received: from localhost (c-67-164-102-47.hsd1.ca.comcast.net [67.164.102.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0953F2053B; Wed, 28 Aug 2019 18:09:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1567015787; bh=pEW7d4+ki1j7cGrysUa/rs6+n6aWIK6WXN6/tbYAFzs=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=SPT3DChX1H83A9Qle/0AqSTbAk6v+FbOYww2pgDUZeRbOYCEyK/D4OEH5eWuzjVuC xDRQFHaR+yKsCIOSiA8B8PhK8UDu1KCgDFfj4b4ahORsC/TvPnQROWaAKyTMWTCALu t81UTiYo2w495kttG20MKcBuBREwFON4EDlYJMPY= Date: Wed, 28 Aug 2019 11:09:46 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s To: Peng Fan cc: Robin Murphy , "sstabellini@kernel.org" , "linux@armlinux.org.uk" , "linux-kernel@vger.kernel.org" , dl-linux-imx , "van.freenix@gmail.com" , "xen-devel@lists.xenproject.org" , "linux-arm-kernel@lists.infradead.org" Subject: RE: [PATCH] arm: xen: mm: use __GPF_DMA32 for arm64 In-Reply-To: Message-ID: References: <20190709083729.11135-1-peng.fan@nxp.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 28 Aug 2019, Peng Fan wrote: > Hi Robin, > > > Subject: Re: [PATCH] arm: xen: mm: use __GPF_DMA32 for arm64 > > > > On 09/07/2019 09:22, Peng Fan wrote: > > > arm64 shares some code under arch/arm/xen, including mm.c. > > > However ZONE_DMA is removed by commit > > > ad67f5a6545("arm64: replace ZONE_DMA with ZONE_DMA32"). > > > So to ARM64, need use __GFP_DMA32. Hi Peng, Sorry for being so late in replying, this email got lost in the noise. > > > Signed-off-by: Peng Fan > > > --- > > > arch/arm/xen/mm.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/arch/arm/xen/mm.c b/arch/arm/xen/mm.c index > > > e1d44b903dfc..a95e76d18bf9 100644 > > > --- a/arch/arm/xen/mm.c > > > +++ b/arch/arm/xen/mm.c > > > @@ -27,7 +27,7 @@ unsigned long xen_get_swiotlb_free_pages(unsigned > > > int order) > > > > > > for_each_memblock(memory, reg) { > > > if (reg->base < (phys_addr_t)0xffffffff) { > > > - flags |= __GFP_DMA; > > > + flags |= __GFP_DMA | __GFP_DMA32; > > > > Given the definition of GFP_ZONE_BAD, I'm not sure this combination of flags > > is strictly valid, but rather is implicitly reliant on only one of those zones ever > > actually existing. As such, it seems liable to blow up if the plans to add > > ZONE_DMA to arm64[1] go ahead. > > How about this, or do you have any suggestions? > diff --git a/arch/arm/xen/mm.c b/arch/arm/xen/mm.c > index d33b77e9add3..f61c29a4430f 100644 > --- a/arch/arm/xen/mm.c > +++ b/arch/arm/xen/mm.c > @@ -28,7 +28,11 @@ unsigned long xen_get_swiotlb_free_pages(unsigned int order) > > for_each_memblock(memory, reg) { > if (reg->base < (phys_addr_t)0xffffffff) { > +#ifdef CONFIG_ARM64 > + flags |= __GFP_DMA32; > +#else > flags |= __GFP_DMA; > +#endif > break; > } > } Yes I think this is the way to go, but we are trying not to add any #ifdef CONFIG_ARM64 under arch/arm. Maybe you could introduce a static inline function to set GFP_DMA: static inline void xen_set_gfp_dma(gfp_t *flags) it could be implemented under arch/arm/include/asm/xen/page.h for arm and under arch/arm64/include/asm/xen/page.h for arm64 using __GFP_DMA for the former and __GFP_DMA32 for the latter. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5B6DC3A5A1 for ; Wed, 28 Aug 2019 18:09:56 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BBCF72053B for ; Wed, 28 Aug 2019 18:09:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="XqRLC+bB"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="SPT3DChX" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BBCF72053B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:Message-ID: In-Reply-To:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=7LpsCK/QHXkVsm1Xae7hTxONzTgYOytJBve/xu+f8wc=; b=XqRLC+bBcupetT 3/Z8ekWWuG1tnn04oYjH+RVA9W+mHtnrzvi28rq1Nu0hyU+5TVBZgjIwQnOweRKM6NOWzQKRMqXGg yk5OsJTBQJkF5DH61KFxD/96xanK471tjQZsPKxnOrlnLYD7fTHjEq1wGiE9EduP3NMNdL4TzSWGy jLtQS+cfW8gu4QPl42rJ3yn2F3yDSw+Oyirdm56qz3FYaGPz2cgDSMxIe9n4VJ8XrJZ9SEo3cZXw2 czg7GR7BtSE9xInKYhxulwUYGkIUW1w2zEC6h9LkUeYBulVPxL01igHV/OhfGbClEFs7Z6iUQ9vQf 60FpZldXZzXlzZrLxEWA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1i32OE-0004f0-Ac; Wed, 28 Aug 2019 18:09:50 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1i32OB-0004ea-TU for linux-arm-kernel@lists.infradead.org; Wed, 28 Aug 2019 18:09:49 +0000 Received: from localhost (c-67-164-102-47.hsd1.ca.comcast.net [67.164.102.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0953F2053B; Wed, 28 Aug 2019 18:09:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1567015787; bh=pEW7d4+ki1j7cGrysUa/rs6+n6aWIK6WXN6/tbYAFzs=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=SPT3DChX1H83A9Qle/0AqSTbAk6v+FbOYww2pgDUZeRbOYCEyK/D4OEH5eWuzjVuC xDRQFHaR+yKsCIOSiA8B8PhK8UDu1KCgDFfj4b4ahORsC/TvPnQROWaAKyTMWTCALu t81UTiYo2w495kttG20MKcBuBREwFON4EDlYJMPY= Date: Wed, 28 Aug 2019 11:09:46 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s To: Peng Fan Subject: RE: [PATCH] arm: xen: mm: use __GPF_DMA32 for arm64 In-Reply-To: Message-ID: References: <20190709083729.11135-1-peng.fan@nxp.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190828_110947_997259_5C818EB2 X-CRM114-Status: GOOD ( 21.85 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "sstabellini@kernel.org" , "linux@armlinux.org.uk" , "linux-kernel@vger.kernel.org" , dl-linux-imx , "van.freenix@gmail.com" , "xen-devel@lists.xenproject.org" , Robin Murphy , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 28 Aug 2019, Peng Fan wrote: > Hi Robin, > > > Subject: Re: [PATCH] arm: xen: mm: use __GPF_DMA32 for arm64 > > > > On 09/07/2019 09:22, Peng Fan wrote: > > > arm64 shares some code under arch/arm/xen, including mm.c. > > > However ZONE_DMA is removed by commit > > > ad67f5a6545("arm64: replace ZONE_DMA with ZONE_DMA32"). > > > So to ARM64, need use __GFP_DMA32. Hi Peng, Sorry for being so late in replying, this email got lost in the noise. > > > Signed-off-by: Peng Fan > > > --- > > > arch/arm/xen/mm.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/arch/arm/xen/mm.c b/arch/arm/xen/mm.c index > > > e1d44b903dfc..a95e76d18bf9 100644 > > > --- a/arch/arm/xen/mm.c > > > +++ b/arch/arm/xen/mm.c > > > @@ -27,7 +27,7 @@ unsigned long xen_get_swiotlb_free_pages(unsigned > > > int order) > > > > > > for_each_memblock(memory, reg) { > > > if (reg->base < (phys_addr_t)0xffffffff) { > > > - flags |= __GFP_DMA; > > > + flags |= __GFP_DMA | __GFP_DMA32; > > > > Given the definition of GFP_ZONE_BAD, I'm not sure this combination of flags > > is strictly valid, but rather is implicitly reliant on only one of those zones ever > > actually existing. As such, it seems liable to blow up if the plans to add > > ZONE_DMA to arm64[1] go ahead. > > How about this, or do you have any suggestions? > diff --git a/arch/arm/xen/mm.c b/arch/arm/xen/mm.c > index d33b77e9add3..f61c29a4430f 100644 > --- a/arch/arm/xen/mm.c > +++ b/arch/arm/xen/mm.c > @@ -28,7 +28,11 @@ unsigned long xen_get_swiotlb_free_pages(unsigned int order) > > for_each_memblock(memory, reg) { > if (reg->base < (phys_addr_t)0xffffffff) { > +#ifdef CONFIG_ARM64 > + flags |= __GFP_DMA32; > +#else > flags |= __GFP_DMA; > +#endif > break; > } > } Yes I think this is the way to go, but we are trying not to add any #ifdef CONFIG_ARM64 under arch/arm. Maybe you could introduce a static inline function to set GFP_DMA: static inline void xen_set_gfp_dma(gfp_t *flags) it could be implemented under arch/arm/include/asm/xen/page.h for arm and under arch/arm64/include/asm/xen/page.h for arm64 using __GFP_DMA for the former and __GFP_DMA32 for the latter. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8BAFBC3A5A1 for ; Wed, 28 Aug 2019 18:10:10 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5B9732053B for ; Wed, 28 Aug 2019 18:10:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="SPT3DChX" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5B9732053B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1i32OD-0001V7-Qd; Wed, 28 Aug 2019 18:09:49 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1i32OC-0001UM-Qy for xen-devel@lists.xenproject.org; Wed, 28 Aug 2019 18:09:48 +0000 X-Inumbo-ID: 056cb172-c9bf-11e9-b95f-bc764e2007e4 Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 056cb172-c9bf-11e9-b95f-bc764e2007e4; Wed, 28 Aug 2019 18:09:48 +0000 (UTC) Received: from localhost (c-67-164-102-47.hsd1.ca.comcast.net [67.164.102.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0953F2053B; Wed, 28 Aug 2019 18:09:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1567015787; bh=pEW7d4+ki1j7cGrysUa/rs6+n6aWIK6WXN6/tbYAFzs=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=SPT3DChX1H83A9Qle/0AqSTbAk6v+FbOYww2pgDUZeRbOYCEyK/D4OEH5eWuzjVuC xDRQFHaR+yKsCIOSiA8B8PhK8UDu1KCgDFfj4b4ahORsC/TvPnQROWaAKyTMWTCALu t81UTiYo2w495kttG20MKcBuBREwFON4EDlYJMPY= Date: Wed, 28 Aug 2019 11:09:46 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s To: Peng Fan In-Reply-To: Message-ID: References: <20190709083729.11135-1-peng.fan@nxp.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Subject: Re: [Xen-devel] [PATCH] arm: xen: mm: use __GPF_DMA32 for arm64 X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: "sstabellini@kernel.org" , "linux@armlinux.org.uk" , "linux-kernel@vger.kernel.org" , dl-linux-imx , "van.freenix@gmail.com" , "xen-devel@lists.xenproject.org" , Robin Murphy , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" T24gV2VkLCAyOCBBdWcgMjAxOSwgUGVuZyBGYW4gd3JvdGU6Cj4gSGkgUm9iaW4sCj4gCj4gPiBT dWJqZWN0OiBSZTogW1BBVENIXSBhcm06IHhlbjogbW06IHVzZSBfX0dQRl9ETUEzMiBmb3IgYXJt NjQKPiA+IAo+ID4gT24gMDkvMDcvMjAxOSAwOToyMiwgUGVuZyBGYW4gd3JvdGU6Cj4gPiA+IGFy bTY0IHNoYXJlcyBzb21lIGNvZGUgdW5kZXIgYXJjaC9hcm0veGVuLCBpbmNsdWRpbmcgbW0uYy4K PiA+ID4gSG93ZXZlciBaT05FX0RNQSBpcyByZW1vdmVkIGJ5IGNvbW1pdAo+ID4gPiBhZDY3ZjVh NjU0NSgiYXJtNjQ6IHJlcGxhY2UgWk9ORV9ETUEgd2l0aCBaT05FX0RNQTMyIikuCj4gPiA+IFNv IHRvIEFSTTY0LCBuZWVkIHVzZSBfX0dGUF9ETUEzMi4KCkhpIFBlbmcsCgpTb3JyeSBmb3IgYmVp bmcgc28gbGF0ZSBpbiByZXBseWluZywgdGhpcyBlbWFpbCBnb3QgbG9zdCBpbiB0aGUgbm9pc2Uu CgoKPiA+ID4gU2lnbmVkLW9mZi1ieTogUGVuZyBGYW4gPHBlbmcuZmFuQG54cC5jb20+Cj4gPiA+ IC0tLQo+ID4gPiAgIGFyY2gvYXJtL3hlbi9tbS5jIHwgMiArLQo+ID4gPiAgIDEgZmlsZSBjaGFu Z2VkLCAxIGluc2VydGlvbigrKSwgMSBkZWxldGlvbigtKQo+ID4gPgo+ID4gPiBkaWZmIC0tZ2l0 IGEvYXJjaC9hcm0veGVuL21tLmMgYi9hcmNoL2FybS94ZW4vbW0uYyBpbmRleAo+ID4gPiBlMWQ0 NGI5MDNkZmMuLmE5NWU3NmQxOGJmOSAxMDA2NDQKPiA+ID4gLS0tIGEvYXJjaC9hcm0veGVuL21t LmMKPiA+ID4gKysrIGIvYXJjaC9hcm0veGVuL21tLmMKPiA+ID4gQEAgLTI3LDcgKzI3LDcgQEAg dW5zaWduZWQgbG9uZyB4ZW5fZ2V0X3N3aW90bGJfZnJlZV9wYWdlcyh1bnNpZ25lZAo+ID4gPiBp bnQgb3JkZXIpCj4gPiA+Cj4gPiA+ICAgCWZvcl9lYWNoX21lbWJsb2NrKG1lbW9yeSwgcmVnKSB7 Cj4gPiA+ICAgCQlpZiAocmVnLT5iYXNlIDwgKHBoeXNfYWRkcl90KTB4ZmZmZmZmZmYpIHsKPiA+ ID4gLQkJCWZsYWdzIHw9IF9fR0ZQX0RNQTsKPiA+ID4gKwkJCWZsYWdzIHw9IF9fR0ZQX0RNQSB8 IF9fR0ZQX0RNQTMyOwo+ID4gCj4gPiBHaXZlbiB0aGUgZGVmaW5pdGlvbiBvZiBHRlBfWk9ORV9C QUQsIEknbSBub3Qgc3VyZSB0aGlzIGNvbWJpbmF0aW9uIG9mIGZsYWdzCj4gPiBpcyBzdHJpY3Rs eSB2YWxpZCwgYnV0IHJhdGhlciBpcyBpbXBsaWNpdGx5IHJlbGlhbnQgb24gb25seSBvbmUgb2Yg dGhvc2Ugem9uZXMgZXZlcgo+ID4gYWN0dWFsbHkgZXhpc3RpbmcuIEFzIHN1Y2gsIGl0IHNlZW1z IGxpYWJsZSB0byBibG93IHVwIGlmIHRoZSBwbGFucyB0byBhZGQKPiA+IFpPTkVfRE1BIHRvIGFy bTY0WzFdIGdvIGFoZWFkLgo+IAo+IEhvdyBhYm91dCB0aGlzLCBvciBkbyB5b3UgaGF2ZSBhbnkg c3VnZ2VzdGlvbnM/Cj4gZGlmZiAtLWdpdCBhL2FyY2gvYXJtL3hlbi9tbS5jIGIvYXJjaC9hcm0v eGVuL21tLmMKPiBpbmRleCBkMzNiNzdlOWFkZDMuLmY2MWMyOWE0NDMwZiAxMDA2NDQKPiAtLS0g YS9hcmNoL2FybS94ZW4vbW0uYwo+ICsrKyBiL2FyY2gvYXJtL3hlbi9tbS5jCj4gQEAgLTI4LDcg KzI4LDExIEBAIHVuc2lnbmVkIGxvbmcgeGVuX2dldF9zd2lvdGxiX2ZyZWVfcGFnZXModW5zaWdu ZWQgaW50IG9yZGVyKQo+IAo+ICAgICAgICAgZm9yX2VhY2hfbWVtYmxvY2sobWVtb3J5LCByZWcp IHsKPiAgICAgICAgICAgICAgICAgaWYgKHJlZy0+YmFzZSA8IChwaHlzX2FkZHJfdCkweGZmZmZm ZmZmKSB7Cj4gKyNpZmRlZiBDT05GSUdfQVJNNjQKPiArICAgICAgICAgICAgICAgICAgICAgICBm bGFncyB8PSBfX0dGUF9ETUEzMjsKPiArI2Vsc2UKPiAgICAgICAgICAgICAgICAgICAgICAgICBm bGFncyB8PSBfX0dGUF9ETUE7Cj4gKyNlbmRpZgo+ICAgICAgICAgICAgICAgICAgICAgICAgIGJy ZWFrOwo+ICAgICAgICAgICAgICAgICB9Cj4gICAgICAgICB9CgpZZXMgSSB0aGluayB0aGlzIGlz IHRoZSB3YXkgdG8gZ28sIGJ1dCB3ZSBhcmUgdHJ5aW5nIG5vdCB0byBhZGQgYW55CiNpZmRlZiBD T05GSUdfQVJNNjQgdW5kZXIgYXJjaC9hcm0uIE1heWJlIHlvdSBjb3VsZCBpbnRyb2R1Y2UgYSBz dGF0aWMKaW5saW5lIGZ1bmN0aW9uIHRvIHNldCBHRlBfRE1BOgoKICBzdGF0aWMgaW5saW5lIHZv aWQgeGVuX3NldF9nZnBfZG1hKGdmcF90ICpmbGFncykKCml0IGNvdWxkIGJlIGltcGxlbWVudGVk IHVuZGVyIGFyY2gvYXJtL2luY2x1ZGUvYXNtL3hlbi9wYWdlLmggZm9yIGFybQphbmQgdW5kZXIg YXJjaC9hcm02NC9pbmNsdWRlL2FzbS94ZW4vcGFnZS5oIGZvciBhcm02NCB1c2luZyBfX0dGUF9E TUEKZm9yIHRoZSBmb3JtZXIgYW5kIF9fR0ZQX0RNQTMyIGZvciB0aGUgbGF0dGVyLgoKX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVsIG1haWxp bmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcKaHR0cHM6Ly9saXN0cy54ZW5w cm9qZWN0Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL3hlbi1kZXZlbA==