From: Julia Lawall <julia.lawall@lip6.fr>
To: "Javier F. Arias" <jarias.linux@gmail.com>
Cc: gregkh@linuxfoundation.org, outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] [PATCH v2] staging: rtl8723bs: Replace string with identifier
Date: Tue, 8 Oct 2019 07:46:47 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.21.1910080746110.2638@hadrien> (raw)
In-Reply-To: <20191008024316.rqpvni26uqoulru3@gmail.com>
On Mon, 7 Oct 2019, Javier F. Arias wrote:
> Replace the hardcoded function name with it's predefined identifier.
> Issue found by checkpatch.
>
> Signed-off-by: Javier F. Arias <jarias.linux@gmail.com>
> ---
> Changes in v2:
> - Fixed a typo in the commit message.
Sorry, but there's still another one: it's = it is, not the possessive
version of it. So "its".
julia
>
> drivers/staging/rtl8723bs/core/rtw_xmit.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/core/rtw_xmit.c b/drivers/staging/rtl8723bs/core/rtw_xmit.c
> index 6f7a63f53d4f..fef9f1f9ba2c 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_xmit.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_xmit.c
> @@ -2310,7 +2310,7 @@ s32 rtw_xmit(struct adapter *padapter, _pkt **ppkt)
>
> if (!pxmitframe) {
> drop_cnt++;
> - RT_TRACE(_module_xmit_osdep_c_, _drv_err_, ("rtw_xmit: no more pxmitframe\n"));
> + RT_TRACE(_module_xmit_osdep_c_, _drv_err_, ("%s: no more pxmitframe\n", __func__));
> DBG_COUNTER(padapter->tx_logs.core_tx_err_pxmitframe);
> return -1;
> }
> @@ -2318,7 +2318,7 @@ s32 rtw_xmit(struct adapter *padapter, _pkt **ppkt)
> res = update_attrib(padapter, *ppkt, &pxmitframe->attrib);
>
> if (res == _FAIL) {
> - RT_TRACE(_module_xmit_osdep_c_, _drv_err_, ("rtw_xmit: update attrib fail\n"));
> + RT_TRACE(_module_xmit_osdep_c_, _drv_err_, ("%s: update attrib fail\n", __func__));
> #ifdef DBG_TX_DROP_FRAME
> DBG_871X("DBG_TX_DROP_FRAME %s update attrib fail\n", __func__);
> #endif
> --
> 2.20.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20191008024316.rqpvni26uqoulru3%40gmail.com.
>
prev parent reply other threads:[~2019-10-08 5:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-08 2:43 [PATCH v2] staging: rtl8723bs: Replace string with identifier Javier F. Arias
2019-10-08 5:46 ` Julia Lawall [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.1910080746110.2638@hadrien \
--to=julia.lawall@lip6.fr \
--cc=gregkh@linuxfoundation.org \
--cc=jarias.linux@gmail.com \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.