From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linutronix.de (193.142.43.55:993) by crypto-ml.lab.linutronix.de with IMAP4-SSL for ; 21 Oct 2019 08:00:15 -0000 Received: from [5.158.153.52] (helo=nanos.tec.linutronix.de) by Galois.linutronix.de with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1iMSbu-0003fN-NZ for speck@linutronix.de; Mon, 21 Oct 2019 10:00:14 +0200 Date: Mon, 21 Oct 2019 10:00:14 +0200 (CEST) From: Thomas Gleixner Subject: Re: [PATCH v5 09/11] TAAv5 9 In-Reply-To: <20191011084548.GA1075470@kroah.com> Message-ID: References: <5d983ad2.1c69fb81.e6640.8f51SMTPIN_ADDED_BROKEN@mx.google.com> <20191006170646.GA147859@kroah.com> <20191008060156.GG5154@guptapadev.amr> <20191010213151.GJ11840@guptapadev.amr> <20191011084548.GA1075470@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII To: speck@linutronix.de List-ID: On Fri, 11 Oct 2019, speck for Greg KH wrote: > On Thu, Oct 10, 2019 at 02:31:51PM -0700, speck for Pawan Gupta wrote: > I'm sorry, but I do not understand what you are trying to state here. > > Look at the code, and the lock, and determine what it really is doing > and document that please. Right now I can't determine it and it looks > pointless to me, so I must be missing something. It's protecting the write to the global state along with the actual update function which writes the MSR on each CPU depending on that global state. That has to be one protected section for obvious reasons. Thanks, tglx