Re: [alsa-devel] [PATCH v6 3/9] ASoC: Intel: skl-hda-dsp-generic: use snd-hda-codec-hdmi

From: Kai Vehmanen <kai.vehmanen@linux.intel.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: libin.yang@intel.com, alsa-devel@alsa-project.org,
	pierre-louis.bossart@linux.intel.com,
	Kai Vehmanen <kai.vehmanen@linux.intel.com>
Subject: Re: [alsa-devel] [PATCH v6 3/9] ASoC: Intel: skl-hda-dsp-generic: use snd-hda-codec-hdmi
Date: Tue, 22 Oct 2019 14:15:46 +0300 (EEST)	[thread overview]
Message-ID: <alpine.DEB.2.21.1910221401580.16459@zeliteleevi> (raw)
In-Reply-To: <s5hk193iyoh.wl-tiwai@suse.de>

Hi,

On Thu, 17 Oct 2019, Takashi Iwai wrote:
> Kai Vehmanen wrote:
> > +static inline struct snd_pcm *hda_dsp_hdmi_pcm_handle(struct snd_soc_card *card,
> > +						      int hdmi_idx)
> > +{
[...]
> > +static inline int hda_dsp_hdmi_build_controls(struct snd_soc_card *card,
> > +					      struct snd_soc_component *comp)
>
> These additions look a bit too large for inline functions.
> Wouldn't it be difficult to make them non-inline?

ack, shouldn't be too difficult. I'll make the update and also rebase on 
top of Mark's tree.

My rationale for inlining was that these functions are used by machine 
drivers only, so each machine driver got a copy anyways in the end, plus 
I wanted to avoid modifying the Makefile rules for all the machine drivers
I touched. But neither is a hard requirement, so let's put the new helpers
into their own compilation unit.

Thanks for the review!

Br, Kai
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel