All of lore.kernel.org
 help / color / mirror / Atom feed
From: Julia Lawall <julia.lawall@lip6.fr>
To: Evan Chime <chime.evan.dri.devel@gmail.com>
Cc: gregkh@linuxfoundation.org, outreachy-kernel@googlegroups.com,
	 laurent.pinchart@ideasonboard.com, mchehab@kernel.org
Subject: Re: [Outreachy kernel] [PATCH v2 3/3] Staging: media: omap4iss: Add comment to memory barrier
Date: Sun, 3 Nov 2019 17:16:13 +0100 (CET)	[thread overview]
Message-ID: <alpine.DEB.2.21.1911031716020.2557@hadrien> (raw)
In-Reply-To: <62b034d416bc0b0f2fc2a10c225bcf1441b4eecc.1572797322.git.chime.evan.dri.devel@gmail.com>



On Sun, 3 Nov 2019, Evan Chime wrote:

> Fix "WARNING: memory barrier without comment" from checkpath. Add comment
> to memory barrier smp_wmb() on line 660
>
> Signed-off-by: Evan Chime <chime.evan.dri.devel@gmail.com>
> ---
>  drivers/staging/media/omap4iss/iss.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/media/omap4iss/iss.c b/drivers/staging/media/omap4iss/iss.c
> index ce34c19874c7..85b0d9cbaa14 100644
> --- a/drivers/staging/media/omap4iss/iss.c
> +++ b/drivers/staging/media/omap4iss/iss.c
> @@ -657,7 +657,7 @@ int omap4iss_module_sync_idle(struct media_entity *me, wait_queue_head_t *wait,
>  	if (!wait_event_timeout(*wait, !atomic_read(stopping),
>  				msecs_to_jiffies(1000))) {
>  		atomic_set(stopping, 0);
> -		smp_wmb();
> +		smp_wmb(); /* Prevent stores reordering across the barrier */

Which stores?

julia

>  		return -ETIMEDOUT;
>  	}
>
> --
> 2.17.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/62b034d416bc0b0f2fc2a10c225bcf1441b4eecc.1572797322.git.chime.evan.dri.devel%40gmail.com.
>


  reply	other threads:[~2019-11-03 16:16 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-03 16:13 [PATCH v2 0/3] Add comment to memory barrier Evan Chime
2019-11-03 16:14 ` [PATCH v2 1/3] Staging: media: omap4iss: " Evan Chime
2019-11-03 17:07   ` Greg KH
2019-11-03 17:26     ` evan chime
2019-11-03 16:14 ` [PATCH v2 2/3] " Evan Chime
2019-11-03 16:15 ` [PATCH v2 3/3] " Evan Chime
2019-11-03 16:16   ` Julia Lawall [this message]
2019-11-03 16:23     ` [Outreachy kernel] " evan chime
2019-11-03 16:18 ` [Outreachy kernel] [PATCH v2 0/3] " Julia Lawall
2019-11-03 16:27   ` evan chime
2019-11-04 13:26     ` evan chime
2019-11-04 18:54       ` evan chime
2019-11-05 16:40 ` ledepiele

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.21.1911031716020.2557@hadrien \
    --to=julia.lawall@lip6.fr \
    --cc=chime.evan.dri.devel@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=mchehab@kernel.org \
    --cc=outreachy-kernel@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.