From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3932BC5DF63 for ; Wed, 6 Nov 2019 17:02:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1230B2173E for ; Wed, 6 Nov 2019 17:02:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732394AbfKFRCs (ORCPT ); Wed, 6 Nov 2019 12:02:48 -0500 Received: from Galois.linutronix.de ([193.142.43.55]:44842 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728448AbfKFRCr (ORCPT ); Wed, 6 Nov 2019 12:02:47 -0500 Received: from p5b06da22.dip0.t-ipconnect.de ([91.6.218.34] helo=nanos) by Galois.linutronix.de with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1iSOhf-0000Cr-9F; Wed, 06 Nov 2019 18:02:43 +0100 Date: Wed, 6 Nov 2019 18:02:41 +0100 (CET) From: Thomas Gleixner To: Mohammad Nasirifar cc: Arnd Bergmann , Andrew Morton , Mohammad Nasirifar , Linux API , linux-arch , "linux-kernel@vger.kernel.org" , Valdis Kletnieks Subject: Re: [PATCH 1/1] syscalls: Fix references to filenames containing syscall defs In-Reply-To: <20191106164756.GA558585@gmail.com> Message-ID: References: <20191105022928.517526-1-farnasirim@gmail.com> <20191106164756.GA558585@gmail.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 6 Nov 2019, Mohammad Nasirifar wrote: > On Tue, Nov 05, 2019 at 10:49:12AM +0100, Arnd Bergmann wrote: > > On Tue, Nov 5, 2019 at 10:34 AM Thomas Gleixner wrote: > > > On Mon, 4 Nov 2019, Mohammad Nasirifar wrote: > > > > Fix stale references to files containing syscall definitions in > > > > 'include/linux/syscalls.h' and 'include/uapi/asm-generic/unistd.h', > > > > pointing to 'kernel/itimer.c', 'kernel/hrtimer.c', and 'kernel/time.c'. > > > > They are now under 'kernel/time'. > > > > > > > > Also definitions of 'getpid', 'getppid', 'getuid', 'geteuid', 'getgid', > > > > 'getegid', 'gettid', and 'sysinfo' are now in 'kernel/sys.c'. > > > > > > Can we please remove these file references completely. They are going > > > to be stale sooner than later again and they really do not provide > > > any value. > > I actually refer to them a lot when locating syscall implementations, > which is how I found out that they were stale in the first place. # git grep -n 'SYSCALL.*(nanosleep' kernel/time/hrtimer.c:1945:SYSCALL_DEFINE2(nanosleep, struct ... kernel/time/hrtimer.c:1965:SYSCALL_DEFINE2(nanosleep_time32, struct ... Gives you the always correct answer including the line number. So there is really no value in keeping those file references and have them outdated once a function or a file moves. It's just matter of fact that nobody ever fixes them up when a function or a file moves. Why? Because they have no connection. The compiler does not complain and there are no tools which could ever validate them. So removing them is the right thing to do. Thanks, tglx