From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23638C432C3 for ; Wed, 13 Nov 2019 21:56:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2FCE7206E5 for ; Wed, 13 Nov 2019 21:56:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726952AbfKMV45 (ORCPT ); Wed, 13 Nov 2019 16:56:57 -0500 Received: from Galois.linutronix.de ([193.142.43.55]:39226 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726162AbfKMV44 (ORCPT ); Wed, 13 Nov 2019 16:56:56 -0500 Received: from p5b06da22.dip0.t-ipconnect.de ([91.6.218.34] helo=nanos) by Galois.linutronix.de with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1iV0ch-00077n-F2; Wed, 13 Nov 2019 22:56:23 +0100 Date: Wed, 13 Nov 2019 22:56:22 +0100 (CET) From: Thomas Gleixner To: Arnd Bergmann cc: y2038@lists.linaro.org, Greentime Hu , Vincent Chen , Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , "David S. Miller" , Andy Lutomirski , Ingo Molnar , Borislav Petkov , x86@kernel.org, Jeff Dike , Richard Weinberger , Anton Ivanov , linux-kernel@vger.kernel.org, "H. Peter Anvin" , Vincenzo Frascino , Christophe Leroy , "Eric W. Biederman" , linuxppc-dev@lists.ozlabs.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org Subject: Re: [PATCH 03/23] y2038: vdso: change timeval to __kernel_old_timeval In-Reply-To: <20191108210824.1534248-3-arnd@arndb.de> Message-ID: References: <20191108210236.1296047-1-arnd@arndb.de> <20191108210824.1534248-3-arnd@arndb.de> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 8 Nov 2019, Arnd Bergmann wrote: > The gettimeofday() function in vdso uses the traditional 'timeval' > structure layout, which will be incompatible with future versions of > glibc on 32-bit architectures that use a 64-bit time_t. > > This interface is problematic for y2038, when time_t overflows on 32-bit > architectures, but the plan so far is that a libc with 64-bit time_t > will not call into the gettimeofday() vdso helper at all, and only > have a method for entering clock_gettime(). This means we don't have > to fix it here, though we probably want to add a new clock_gettime() > entry point using a 64-bit version of 'struct timespec' at some point. > > Changing the vdso code to use __kernel_old_timeval helps isolate > this usage from the other ones that still need to be fixed properly, > and it gets us closer to removing the 'timeval' definition from the > kernel sources. > > Signed-off-by: Arnd Bergmann Reviewed-by: Thomas Gleixner From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Gleixner Date: Wed, 13 Nov 2019 21:56:22 +0000 Subject: Re: [PATCH 03/23] y2038: vdso: change timeval to __kernel_old_timeval Message-Id: List-Id: References: <20191108210236.1296047-1-arnd@arndb.de> <20191108210824.1534248-3-arnd@arndb.de> In-Reply-To: <20191108210824.1534248-3-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Arnd Bergmann Cc: Paul Mackerras , "H. Peter Anvin" , sparclinux@vger.kernel.org, Vincenzo Frascino , Anton Ivanov , Vincent Chen , y2038@lists.linaro.org, Richard Weinberger , x86@kernel.org, Ingo Molnar , Jeff Dike , linux-um@lists.infradead.org, Borislav Petkov , Greentime Hu , Andy Lutomirski , linux-kernel@vger.kernel.org, "Eric W. Biederman" , linuxppc-dev@lists.ozlabs.org, "David S. Miller" On Fri, 8 Nov 2019, Arnd Bergmann wrote: > The gettimeofday() function in vdso uses the traditional 'timeval' > structure layout, which will be incompatible with future versions of > glibc on 32-bit architectures that use a 64-bit time_t. > > This interface is problematic for y2038, when time_t overflows on 32-bit > architectures, but the plan so far is that a libc with 64-bit time_t > will not call into the gettimeofday() vdso helper at all, and only > have a method for entering clock_gettime(). This means we don't have > to fix it here, though we probably want to add a new clock_gettime() > entry point using a 64-bit version of 'struct timespec' at some point. > > Changing the vdso code to use __kernel_old_timeval helps isolate > this usage from the other ones that still need to be fixed properly, > and it gets us closer to removing the 'timeval' definition from the > kernel sources. > > Signed-off-by: Arnd Bergmann Reviewed-by: Thomas Gleixner From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD324C432C3 for ; Wed, 13 Nov 2019 21:59:22 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5A5FB206E5 for ; Wed, 13 Nov 2019 21:59:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5A5FB206E5 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linutronix.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 47Cz6H4g6VzF4kT for ; Thu, 14 Nov 2019 08:59:19 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=linutronix.de (client-ip=2a0a:51c0:0:12e:550::1; helo=galois.linutronix.de; envelope-from=tglx@linutronix.de; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=linutronix.de Received: from Galois.linutronix.de (Galois.linutronix.de [IPv6:2a0a:51c0:0:12e:550::1]) (using TLSv1.2 with cipher DHE-RSA-AES256-SHA256 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 47Cz3T72JVzF7H6 for ; Thu, 14 Nov 2019 08:56:53 +1100 (AEDT) Received: from p5b06da22.dip0.t-ipconnect.de ([91.6.218.34] helo=nanos) by Galois.linutronix.de with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1iV0ch-00077n-F2; Wed, 13 Nov 2019 22:56:23 +0100 Date: Wed, 13 Nov 2019 22:56:22 +0100 (CET) From: Thomas Gleixner To: Arnd Bergmann Subject: Re: [PATCH 03/23] y2038: vdso: change timeval to __kernel_old_timeval In-Reply-To: <20191108210824.1534248-3-arnd@arndb.de> Message-ID: References: <20191108210236.1296047-1-arnd@arndb.de> <20191108210824.1534248-3-arnd@arndb.de> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1, SHORTCIRCUIT=-0.0001 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paul Mackerras , "H. Peter Anvin" , sparclinux@vger.kernel.org, Vincenzo Frascino , Anton Ivanov , Vincent Chen , y2038@lists.linaro.org, Richard Weinberger , x86@kernel.org, Ingo Molnar , Jeff Dike , linux-um@lists.infradead.org, Borislav Petkov , Greentime Hu , Andy Lutomirski , linux-kernel@vger.kernel.org, "Eric W. Biederman" , linuxppc-dev@lists.ozlabs.org, "David S. Miller" Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Fri, 8 Nov 2019, Arnd Bergmann wrote: > The gettimeofday() function in vdso uses the traditional 'timeval' > structure layout, which will be incompatible with future versions of > glibc on 32-bit architectures that use a 64-bit time_t. > > This interface is problematic for y2038, when time_t overflows on 32-bit > architectures, but the plan so far is that a libc with 64-bit time_t > will not call into the gettimeofday() vdso helper at all, and only > have a method for entering clock_gettime(). This means we don't have > to fix it here, though we probably want to add a new clock_gettime() > entry point using a 64-bit version of 'struct timespec' at some point. > > Changing the vdso code to use __kernel_old_timeval helps isolate > this usage from the other ones that still need to be fixed properly, > and it gets us closer to removing the 'timeval' definition from the > kernel sources. > > Signed-off-by: Arnd Bergmann Reviewed-by: Thomas Gleixner From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from galois.linutronix.de ([2a0a:51c0:0:12e:550::1]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iV0dK-0002r3-M7 for linux-um@lists.infradead.org; Wed, 13 Nov 2019 21:57:04 +0000 Date: Wed, 13 Nov 2019 22:56:22 +0100 (CET) From: Thomas Gleixner Subject: Re: [PATCH 03/23] y2038: vdso: change timeval to __kernel_old_timeval In-Reply-To: <20191108210824.1534248-3-arnd@arndb.de> Message-ID: References: <20191108210236.1296047-1-arnd@arndb.de> <20191108210824.1534248-3-arnd@arndb.de> MIME-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-um" Errors-To: linux-um-bounces+geert=linux-m68k.org@lists.infradead.org To: Arnd Bergmann Cc: Benjamin Herrenschmidt , Paul Mackerras , "H. Peter Anvin" , sparclinux@vger.kernel.org, Vincenzo Frascino , Anton Ivanov , Vincent Chen , y2038@lists.linaro.org, Richard Weinberger , x86@kernel.org, Ingo Molnar , Jeff Dike , linux-um@lists.infradead.org, Borislav Petkov , Greentime Hu , Andy Lutomirski , Christophe Leroy , linux-kernel@vger.kernel.org, "Eric W. Biederman" , Michael Ellerman , linuxppc-dev@lists.ozlabs.org, "David S. Miller" On Fri, 8 Nov 2019, Arnd Bergmann wrote: > The gettimeofday() function in vdso uses the traditional 'timeval' > structure layout, which will be incompatible with future versions of > glibc on 32-bit architectures that use a 64-bit time_t. > > This interface is problematic for y2038, when time_t overflows on 32-bit > architectures, but the plan so far is that a libc with 64-bit time_t > will not call into the gettimeofday() vdso helper at all, and only > have a method for entering clock_gettime(). This means we don't have > to fix it here, though we probably want to add a new clock_gettime() > entry point using a 64-bit version of 'struct timespec' at some point. > > Changing the vdso code to use __kernel_old_timeval helps isolate > this usage from the other ones that still need to be fixed properly, > and it gets us closer to removing the 'timeval' definition from the > kernel sources. > > Signed-off-by: Arnd Bergmann Reviewed-by: Thomas Gleixner _______________________________________________ linux-um mailing list linux-um@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-um