From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE43BC43141 for ; Thu, 14 Nov 2019 10:52:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 98E4C206F0 for ; Thu, 14 Nov 2019 10:52:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726812AbfKNKwI (ORCPT ); Thu, 14 Nov 2019 05:52:08 -0500 Received: from Galois.linutronix.de ([193.142.43.55]:40267 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725977AbfKNKwI (ORCPT ); Thu, 14 Nov 2019 05:52:08 -0500 Received: from [5.158.153.52] (helo=nanos.tec.linutronix.de) by Galois.linutronix.de with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1iVCjA-0008Ez-UZ; Thu, 14 Nov 2019 11:51:53 +0100 Date: Thu, 14 Nov 2019 11:51:52 +0100 (CET) From: Thomas Gleixner To: Ondrej Mosnacek cc: Arnd Bergmann , y2038 Mailman List , John Stultz , Paul Moore , Stephen Smalley , Eric Paris , Linux kernel mailing list , Stephen Boyd , Sebastian Andrzej Siewior , Ingo Molnar , Anna-Maria Gleixner , Al Viro , SElinux list Subject: Re: [PATCH 20/23] y2038: move itimer reset into itimer.c In-Reply-To: Message-ID: References: <20191108210236.1296047-1-arnd@arndb.de> <20191108211323.1806194-11-arnd@arndb.de> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 14 Nov 2019, Ondrej Mosnacek wrote: > On Mon, Nov 11, 2019 at 11:58 AM Arnd Bergmann wrote: > > I don't see that as a problem, we rarely put declarations inside of an #ifdef. > > The main effect that would have is forcing any file that includes linux/time.h > > to be rebuilt when selinux is turned on or off in the .config. > > OK, but with this patch if someone tries to use the function > elsewhere, the build will succeed if SELinux is enabled in the config, > but fail if it isn't. Is that intended? I would suggest at least > clearly documenting it above the declaration that the function isn't > supposed to be used by new users and doing so will cause build to fail > under CONFIG_SECURITY_SELINUX=n. Come on. We have enough functions in the kernel which are only available under a certain config option and if you (ab)use them elsewhere then the build fails. So what? The #ifdef documents the limited scope and intended use clearly. If something else really needs that function, then removing the #ifdef shouldn't be rocket science either. Thanks, tglx