From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68EBCC43215 for ; Sat, 23 Nov 2019 10:24:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 405B02072D for ; Sat, 23 Nov 2019 10:24:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726487AbfKWKYg (ORCPT ); Sat, 23 Nov 2019 05:24:36 -0500 Received: from mailbackend.panix.com ([166.84.1.89]:46612 "EHLO mailbackend.panix.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726481AbfKWKYg (ORCPT ); Sat, 23 Nov 2019 05:24:36 -0500 Received: from hp-x360n (c-73-241-154-233.hsd1.ca.comcast.net [73.241.154.233]) by mailbackend.panix.com (Postfix) with ESMTPSA id 47KqD12j3MzlGL; Sat, 23 Nov 2019 05:24:33 -0500 (EST) Date: Sat, 23 Nov 2019 02:24:32 -0800 (PST) From: "Kenneth R. Crudup" Reply-To: "Kenneth R. Crudup" To: "Rafael J. Wysocki" cc: Rafael Wysocki , Linux PM Subject: Re: Help me fix a regression caused by 56b9918490 (PM: sleep: Simplify suspend-to-idle control flow) In-Reply-To: Message-ID: References: User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On Fri, 22 Nov 2019, Rafael J. Wysocki wrote: > BTW, is the ec_no_wakeup=1 workaround still effective? OK, I was wrong the first time, at least from the new Linus' tip (as of merge commit 2027cabe6af anyway). So I did some testing, and I now have a matrix: If "sleep_no_lps0" == 1, the machine never goes fully to sleep; the power light stays on and the backlight goes off, but if I have external monitors connected they're still showing dmesg activity. This is independent of the state of "ec_no_wakeup". If "ec_no_wakeup" == 1, the system *at times* will go to sleep and never return (i.e. no power light comes on, it's totally unresponsive until I do a hard reset with a power-button long-press) whether I'm plugged in or not. This is new behavior. If "ec_no_wakeup" == 0, the system goes fully to sleep and either of the power button, lid opening or hitting a key resumes the laptop, but if I'm plugged in and actually charging when I suspend (and I suspect if I plug it in during suspend) it never returns, as in the case above. Help! What can I do to return to the behavior of right before the s0 rework? Where in the code could I start looking to try to find out where the machine goes dead? -Kenny -- Kenneth R. Crudup Sr. SW Engineer, Scott County Consulting, Silicon Valley