From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8698C33C9E for ; Sat, 11 Jan 2020 07:44:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A586E21569 for ; Sat, 11 Jan 2020 07:44:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728557AbgAKHok (ORCPT ); Sat, 11 Jan 2020 02:44:40 -0500 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:25507 "EHLO mail3-relais-sop.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728507AbgAKHoj (ORCPT ); Sat, 11 Jan 2020 02:44:39 -0500 X-IronPort-AV: E=Sophos;i="5.69,420,1571695200"; d="scan'208";a="335474693" Received: from abo-154-110-68.mrs.modulonet.fr (HELO hadrien) ([85.68.110.154]) by mail3-relais-sop.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Jan 2020 08:44:37 +0100 Date: Sat, 11 Jan 2020 08:44:36 +0100 (CET) From: Julia Lawall X-X-Sender: jll@hadrien To: Markus Elfring cc: Wen Yang , cocci@systeme.lip6.fr, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, Gilles Muller , Greg Kroah-Hartman , Masahiro Yamada , =?ISO-8859-15?Q?Matthias_M=E4nnich?= , Michal Marek , Nicolas Palix , Thomas Gleixner Subject: Re: [v3] coccinelle: semantic patch to check for inappropriate do_div() calls In-Reply-To: <5a9f1ad1-3881-2004-2a7b-d61f1d201cf9@web.de> Message-ID: References: <20200110131526.60180-1-wenyang@linux.alibaba.com> <91abb141-57b8-7659-25ec-8080e290d846@web.de> <5a9f1ad1-3881-2004-2a7b-d61f1d201cf9@web.de> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > +*do_div(f, \( l \| ul \| ul64 \| sl64 \) ); > > > > We agree with Julia: > > I don't se any point to this. > > Can the avoidance of duplicate source code (according to SmPL disjunctions) > trigger positive effects on run time characteristics and software maintenance? Markus. Please stop asking this question. You are bothering people with this advice, why don't _you_ figure out once and for all whether the change that you suggest has any "positive effects on the run time characteristics"? Hint: it will not. You don't even have to run Coccinelle to see that. Just use spatch --parse-cocci on your two suggestions and you will see that they expand to the same thing. Coccinelle has a pass that propagates disjunctions at the sub-statement level to the statement level. julia From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julia Lawall Date: Sat, 11 Jan 2020 07:44:36 +0000 Subject: Re: [v3] coccinelle: semantic patch to check for inappropriate do_div() calls Message-Id: List-Id: References: <20200110131526.60180-1-wenyang@linux.alibaba.com> <91abb141-57b8-7659-25ec-8080e290d846@web.de> <5a9f1ad1-3881-2004-2a7b-d61f1d201cf9@web.de> In-Reply-To: <5a9f1ad1-3881-2004-2a7b-d61f1d201cf9@web.de> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Markus Elfring Cc: Michal Marek , Wen Yang , Gilles Muller , Greg Kroah-Hartman , Nicolas Palix , kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, =?ISO-8859-15?Q?Matthias_M=E4nnich?= , Thomas Gleixner , cocci@systeme.lip6.fr > > +*do_div(f, \( l \| ul \| ul64 \| sl64 \) ); > > > > We agree with Julia: > > I don't se any point to this. > > Can the avoidance of duplicate source code (according to SmPL disjunctions) > trigger positive effects on run time characteristics and software maintenance? Markus. Please stop asking this question. You are bothering people with this advice, why don't _you_ figure out once and for all whether the change that you suggest has any "positive effects on the run time characteristics"? Hint: it will not. You don't even have to run Coccinelle to see that. Just use spatch --parse-cocci on your two suggestions and you will see that they expand to the same thing. Coccinelle has a pass that propagates disjunctions at the sub-statement level to the statement level. julia From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D13D1C33C9E for ; Sat, 11 Jan 2020 07:44:52 +0000 (UTC) Received: from isis.lip6.fr (isis.lip6.fr [132.227.60.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5E6562072E for ; Sat, 11 Jan 2020 07:44:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5E6562072E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=inria.fr Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=cocci-bounces@systeme.lip6.fr Received: from systeme.lip6.fr (systeme.lip6.fr [132.227.104.7]) by isis.lip6.fr (8.15.2/8.15.2) with ESMTP id 00B7ieXa020918; Sat, 11 Jan 2020 08:44:40 +0100 (CET) Received: from systeme.lip6.fr (systeme.lip6.fr [127.0.0.1]) by systeme.lip6.fr (Postfix) with ESMTP id 2CE2A77DF; Sat, 11 Jan 2020 08:44:40 +0100 (CET) Received: from isis.lip6.fr (isis.lip6.fr [132.227.60.2]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by systeme.lip6.fr (Postfix) with ESMTPS id 1AA407718 for ; Sat, 11 Jan 2020 08:44:38 +0100 (CET) Received: from mail3-relais-sop.national.inria.fr (mail3-relais-sop.national.inria.fr [192.134.164.104]) by isis.lip6.fr (8.15.2/8.15.2) with ESMTP id 00B7ibCY002605 for ; Sat, 11 Jan 2020 08:44:37 +0100 (CET) X-IronPort-AV: E=Sophos;i="5.69,420,1571695200"; d="scan'208";a="335474693" Received: from abo-154-110-68.mrs.modulonet.fr (HELO hadrien) ([85.68.110.154]) by mail3-relais-sop.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Jan 2020 08:44:37 +0100 Date: Sat, 11 Jan 2020 08:44:36 +0100 (CET) From: Julia Lawall X-X-Sender: jll@hadrien To: Markus Elfring In-Reply-To: <5a9f1ad1-3881-2004-2a7b-d61f1d201cf9@web.de> Message-ID: References: <20200110131526.60180-1-wenyang@linux.alibaba.com> <91abb141-57b8-7659-25ec-8080e290d846@web.de> <5a9f1ad1-3881-2004-2a7b-d61f1d201cf9@web.de> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 X-Greylist: Sender IP whitelisted, Sender e-mail whitelisted, not delayed by milter-greylist-4.4.3 (isis.lip6.fr [132.227.60.2]); Sat, 11 Jan 2020 08:44:40 +0100 (CET) X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.4.3 (isis.lip6.fr [132.227.60.2]); Sat, 11 Jan 2020 08:44:37 +0100 (CET) X-Scanned-By: MIMEDefang 2.78 on 132.227.60.2 X-Scanned-By: MIMEDefang 2.78 on 132.227.60.2 Cc: Michal Marek , Wen Yang , Gilles Muller , Greg Kroah-Hartman , Nicolas Palix , kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, =?ISO-8859-15?Q?Matthias_M=E4nnich?= , Thomas Gleixner , cocci@systeme.lip6.fr Subject: Re: [Cocci] [v3] coccinelle: semantic patch to check for inappropriate do_div() calls X-BeenThere: cocci@systeme.lip6.fr X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: cocci-bounces@systeme.lip6.fr Errors-To: cocci-bounces@systeme.lip6.fr > > +*do_div(f, \( l \| ul \| ul64 \| sl64 \) ); > > > > We agree with Julia: > > I don't se any point to this. > > Can the avoidance of duplicate source code (according to SmPL disjunctions) > trigger positive effects on run time characteristics and software maintenance? Markus. Please stop asking this question. You are bothering people with this advice, why don't _you_ figure out once and for all whether the change that you suggest has any "positive effects on the run time characteristics"? Hint: it will not. You don't even have to run Coccinelle to see that. Just use spatch --parse-cocci on your two suggestions and you will see that they expand to the same thing. Coccinelle has a pass that propagates disjunctions at the sub-statement level to the statement level. julia _______________________________________________ Cocci mailing list Cocci@systeme.lip6.fr https://systeme.lip6.fr/mailman/listinfo/cocci