From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0EB29C34024 for ; Mon, 17 Feb 2020 14:22:44 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 93BF724649 for ; Mon, 17 Feb 2020 14:22:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="WMItVeof" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 93BF724649 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id EA2B415E2; Mon, 17 Feb 2020 15:21:51 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz EA2B415E2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1581949362; bh=zOwdTJlUt9tcwaqWCUz1p2sDv9tk1KPl754U53U2wys=; h=Date:From:To:In-Reply-To:References:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=WMItVeofJOnaxgETlpKHjT6Q+IWICTKLtGILbQ/u4l0MVidl+e+FtRo0aKuB+MVso oTiFB1jSF2Tss9glLgPs4uQ9W1CKd95vP/GNCnn4f+vhLTVDx8Nyt6guQXusbNVQRC OztwKWoNcgJ7MQCD9pI5/Oz52UugsSVRDDUHqtHI= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 7BD52F8015E; Mon, 17 Feb 2020 15:21:51 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id CFE9FF80172; Mon, 17 Feb 2020 15:21:49 +0100 (CET) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id B16A2F800C4 for ; Mon, 17 Feb 2020 15:21:41 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz B16A2F800C4 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Feb 2020 06:21:40 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,453,1574150400"; d="scan'208";a="258281162" Received: from eliteleevi.tm.intel.com ([10.237.54.20]) by fmsmga004.fm.intel.com with ESMTP; 17 Feb 2020 06:21:38 -0800 Date: Mon, 17 Feb 2020 16:21:37 +0200 (EET) From: Kai Vehmanen X-X-Sender: kvehmane@eliteleevi.tm.intel.com To: Takashi Iwai In-Reply-To: Message-ID: References: <20200216203516.10869-1-tiwai@suse.de> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7 02160 Espoo MIME-Version: 1.0 Cc: alsa-devel@alsa-project.org, Mark Brown , Pierre-Louis Bossart , Kai Vehmanen , Ranjani Sridharan Subject: Re: [alsa-devel] [PATCH] ASoC: SOF: intel: Fix probe error without i915 graphics X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" Hey, On Mon, 17 Feb 2020, Takashi Iwai wrote: > On Mon, 17 Feb 2020 14:17:54 +0100, Kai Vehmanen wrote: > > snd_hdac_i915_exit() calls > > -> snd_hdac_acomp_exit(), which again calls > > -> component.c:component_master_del(dev, &hdac_component_master_ops); > > -> component.c:take_down_master() > > -> devres.c:devres_release_group(master->dev, NULL); > > > > ... now that is somewhat suprising. Basicly that goes on to release all > > devres resources for the hdac_bus device (not just those related to > > acomp!). > > Does it really? I thought it applies only to the group, and id=NULL > indicating that it's a local group that was created with id=NULL (by > address match). at least in my tests, acomp_exit() ended up releasing a bunch of devres allocations made with devm_kzalloc() that had no relation to acomp. I noted that in devres.c:find_group(), docs say: /* Find devres group with ID @id. If @id is NULL, look for the latest. */ static struct devres_group * find_group(struct device *dev, void *id) ... I don't see how it would be limiting a local group. Br, Kai _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org https://mailman.alsa-project.org/mailman/listinfo/alsa-devel