* [PATCH] [Outreachy kernel] staging: vt6655: remove line over 80 characters
@ 2020-03-09 17:15 Payal Kshirsagar
2020-03-09 21:07 ` Julia Lawall
0 siblings, 1 reply; 4+ messages in thread
From: Payal Kshirsagar @ 2020-03-09 17:15 UTC (permalink / raw)
To: forest, gregkh, outreachy-kernel; +Cc: Payal Kshirsagar
Fix line over 80 characters.
Signed-off-by: Payal Kshirsagar <payalskshirsagar1234@gmail.com>
---
drivers/staging/vt6655/mac.h | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/vt6655/mac.h b/drivers/staging/vt6655/mac.h
index c7888c4e96f2..eb56e16637f6 100644
--- a/drivers/staging/vt6655/mac.h
+++ b/drivers/staging/vt6655/mac.h
@@ -884,9 +884,11 @@ bool MACbIsIntDisable(struct vnt_private *priv);
void MACvSetShortRetryLimit(struct vnt_private *priv,
unsigned char byRetryLimit);
-void MACvSetLongRetryLimit(struct vnt_private *priv, unsigned char byRetryLimit);
+void MACvSetLongRetryLimit(struct vnt_private *priv,
+ unsigned char byRetryLimit);
-void MACvSetLoopbackMode(struct vnt_private *priv, unsigned char byLoopbackMode);
+void MACvSetLoopbackMode(struct vnt_private *priv,
+ unsigned char byLoopbackMode);
void MACvSaveContext(struct vnt_private *priv, unsigned char *pbyCxtBuf);
void MACvRestoreContext(struct vnt_private *priv, unsigned char *pbyCxtBuf);
@@ -913,7 +915,8 @@ void MACvSetCurrSyncDescAddrEx(struct vnt_private *priv,
void MACvSetCurrATIMDescAddrEx(struct vnt_private *priv,
u32 curr_desc_addr);
void MACvTimer0MicroSDelay(struct vnt_private *priv, unsigned int uDelay);
-void MACvOneShotTimer1MicroSec(struct vnt_private *priv, unsigned int uDelayTime);
+void MACvOneShotTimer1MicroSec(struct vnt_private *priv,
+ unsigned int uDelayTime);
void MACvSetMISCFifo(struct vnt_private *priv, unsigned short wOffset,
u32 dwData);
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] [Outreachy kernel] staging: vt6655: remove line over 80 characters
2020-03-09 17:15 [PATCH] [Outreachy kernel] staging: vt6655: remove line over 80 characters Payal Kshirsagar
@ 2020-03-09 21:07 ` Julia Lawall
0 siblings, 0 replies; 4+ messages in thread
From: Julia Lawall @ 2020-03-09 21:07 UTC (permalink / raw)
To: Payal Kshirsagar; +Cc: forest, gregkh, outreachy-kernel
On Mon, 9 Mar 2020, Payal Kshirsagar wrote:
> Fix line over 80 characters.
How could you describe what you have done without using "Fix"? Fix is not
very informative. Most patches fix something. One wants to know what was
done and why.
julia
>
> Signed-off-by: Payal Kshirsagar <payalskshirsagar1234@gmail.com>
> ---
> drivers/staging/vt6655/mac.h | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/vt6655/mac.h b/drivers/staging/vt6655/mac.h
> index c7888c4e96f2..eb56e16637f6 100644
> --- a/drivers/staging/vt6655/mac.h
> +++ b/drivers/staging/vt6655/mac.h
> @@ -884,9 +884,11 @@ bool MACbIsIntDisable(struct vnt_private *priv);
> void MACvSetShortRetryLimit(struct vnt_private *priv,
> unsigned char byRetryLimit);
>
> -void MACvSetLongRetryLimit(struct vnt_private *priv, unsigned char byRetryLimit);
> +void MACvSetLongRetryLimit(struct vnt_private *priv,
> + unsigned char byRetryLimit);
>
> -void MACvSetLoopbackMode(struct vnt_private *priv, unsigned char byLoopbackMode);
> +void MACvSetLoopbackMode(struct vnt_private *priv,
> + unsigned char byLoopbackMode);
>
> void MACvSaveContext(struct vnt_private *priv, unsigned char *pbyCxtBuf);
> void MACvRestoreContext(struct vnt_private *priv, unsigned char *pbyCxtBuf);
> @@ -913,7 +915,8 @@ void MACvSetCurrSyncDescAddrEx(struct vnt_private *priv,
> void MACvSetCurrATIMDescAddrEx(struct vnt_private *priv,
> u32 curr_desc_addr);
> void MACvTimer0MicroSDelay(struct vnt_private *priv, unsigned int uDelay);
> -void MACvOneShotTimer1MicroSec(struct vnt_private *priv, unsigned int uDelayTime);
> +void MACvOneShotTimer1MicroSec(struct vnt_private *priv,
> + unsigned int uDelayTime);
>
> void MACvSetMISCFifo(struct vnt_private *priv, unsigned short wOffset,
> u32 dwData);
> --
> 2.17.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20200309171531.6597-1-payalskshirsagar1234%40gmail.com.
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] [Outreachy kernel] staging: vt6655: remove line over 80 characters
2020-03-08 19:17 Payal Kshirsagar
@ 2020-03-08 19:39 ` Julia Lawall
0 siblings, 0 replies; 4+ messages in thread
From: Julia Lawall @ 2020-03-08 19:39 UTC (permalink / raw)
To: Payal Kshirsagar; +Cc: outreachy-kernel
On Mon, 9 Mar 2020, Payal Kshirsagar wrote:
> Fix line over 80 characters.
The change is fine. However, the patch should be sent to more people.
Search for get_maintainer in the tutorial.
>
> Signed-off-by: Payal Kshirsagar <payalskshirsagar1234@gmail.com>
> ---
> drivers/staging/vt6655/mac.h | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/vt6655/mac.h b/drivers/staging/vt6655/mac.h
> index c7888c4e96f2..eb56e16637f6 100644
> --- a/drivers/staging/vt6655/mac.h
> +++ b/drivers/staging/vt6655/mac.h
> @@ -884,9 +884,11 @@ bool MACbIsIntDisable(struct vnt_private *priv);
> void MACvSetShortRetryLimit(struct vnt_private *priv,
> unsigned char byRetryLimit);
>
> -void MACvSetLongRetryLimit(struct vnt_private *priv, unsigned char byRetryLimit);
> +void MACvSetLongRetryLimit(struct vnt_private *priv,
> + unsigned char byRetryLimit);
>
> -void MACvSetLoopbackMode(struct vnt_private *priv, unsigned char byLoopbackMode);
> +void MACvSetLoopbackMode(struct vnt_private *priv,
> + unsigned char byLoopbackMode);
>
> void MACvSaveContext(struct vnt_private *priv, unsigned char *pbyCxtBuf);
> void MACvRestoreContext(struct vnt_private *priv, unsigned char *pbyCxtBuf);
> @@ -913,7 +915,8 @@ void MACvSetCurrSyncDescAddrEx(struct vnt_private *priv,
> void MACvSetCurrATIMDescAddrEx(struct vnt_private *priv,
> u32 curr_desc_addr);
> void MACvTimer0MicroSDelay(struct vnt_private *priv, unsigned int uDelay);
> -void MACvOneShotTimer1MicroSec(struct vnt_private *priv, unsigned int uDelayTime);
> +void MACvOneShotTimer1MicroSec(struct vnt_private *priv,
> + unsigned int uDelayTime);
If you want to work more on this file, you could improve the naming of
variables. This code is starting variables with p when the variable has a
pointer type and u when the variable has an unsigned type. The kernel
doesn't follow that convention. Also, camel case should not be used.
This uDelayTime should be delay_time.
These are actually function prototypes. So you would change both the
function prototype shown here and the definition, which is probably in
some .c file.
julia
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] [Outreachy kernel] staging: vt6655: remove line over 80 characters
@ 2020-03-08 19:17 Payal Kshirsagar
2020-03-08 19:39 ` Julia Lawall
0 siblings, 1 reply; 4+ messages in thread
From: Payal Kshirsagar @ 2020-03-08 19:17 UTC (permalink / raw)
To: outreachy-kernel; +Cc: Payal Kshirsagar
Fix line over 80 characters.
Signed-off-by: Payal Kshirsagar <payalskshirsagar1234@gmail.com>
---
drivers/staging/vt6655/mac.h | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/vt6655/mac.h b/drivers/staging/vt6655/mac.h
index c7888c4e96f2..eb56e16637f6 100644
--- a/drivers/staging/vt6655/mac.h
+++ b/drivers/staging/vt6655/mac.h
@@ -884,9 +884,11 @@ bool MACbIsIntDisable(struct vnt_private *priv);
void MACvSetShortRetryLimit(struct vnt_private *priv,
unsigned char byRetryLimit);
-void MACvSetLongRetryLimit(struct vnt_private *priv, unsigned char byRetryLimit);
+void MACvSetLongRetryLimit(struct vnt_private *priv,
+ unsigned char byRetryLimit);
-void MACvSetLoopbackMode(struct vnt_private *priv, unsigned char byLoopbackMode);
+void MACvSetLoopbackMode(struct vnt_private *priv,
+ unsigned char byLoopbackMode);
void MACvSaveContext(struct vnt_private *priv, unsigned char *pbyCxtBuf);
void MACvRestoreContext(struct vnt_private *priv, unsigned char *pbyCxtBuf);
@@ -913,7 +915,8 @@ void MACvSetCurrSyncDescAddrEx(struct vnt_private *priv,
void MACvSetCurrATIMDescAddrEx(struct vnt_private *priv,
u32 curr_desc_addr);
void MACvTimer0MicroSDelay(struct vnt_private *priv, unsigned int uDelay);
-void MACvOneShotTimer1MicroSec(struct vnt_private *priv, unsigned int uDelayTime);
+void MACvOneShotTimer1MicroSec(struct vnt_private *priv,
+ unsigned int uDelayTime);
void MACvSetMISCFifo(struct vnt_private *priv, unsigned short wOffset,
u32 dwData);
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-03-09 21:07 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-09 17:15 [PATCH] [Outreachy kernel] staging: vt6655: remove line over 80 characters Payal Kshirsagar
2020-03-09 21:07 ` Julia Lawall
-- strict thread matches above, loose matches on Subject: below --
2020-03-08 19:17 Payal Kshirsagar
2020-03-08 19:39 ` Julia Lawall
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.