Re: [Outreachy kernel] [Outreachy][PATCH] staging: vt6655: Replace camel case variable names.

[Julia Lawall <julia.lawall@inria.fr>]

On Wed, 25 Mar 2020, Briana Oursler wrote:

> Replaces camel case variable names with snake case in baseband.h and
> dependencies.
>
> Signed-off-by: Briana Oursler <briana.oursler@gmail.com>
> ---
>  drivers/staging/vt6655/baseband.c    | 317 ++++++++++++++-------------
>  drivers/staging/vt6655/baseband.h    |  38 ++--
>  drivers/staging/vt6655/card.c        |  48 ++--
>  drivers/staging/vt6655/channel.c     |   4 +-
>  drivers/staging/vt6655/device_main.c |  20 +-
>  drivers/staging/vt6655/rf.c          |   4 +-
>  drivers/staging/vt6655/rxtx.c        |  62 +++---
>  7 files changed, 255 insertions(+), 238 deletions(-)
>
> diff --git a/drivers/staging/vt6655/baseband.c b/drivers/staging/vt6655/baseband.c
> index b4cdc0b7fee7..9909b9d51f7a 100644
> --- a/drivers/staging/vt6655/baseband.c
> +++ b/drivers/staging/vt6655/baseband.c
> @@ -12,12 +12,12 @@
>   * Date: Aug.22, 2002
>   *
>   * Functions:
> - *      BBuGetFrameTime        - Calculate data frame transmitting time
> + *      bb_u_get_frame_time        - Calculate data frame transmitting time
>   *      BBvCalculateParameter   - Calculate PhyLength, PhyService and Phy Signal
>   *                               parameter for baseband Tx
> - *      BBbReadEmbedded         - Embedded read baseband register via MAC
> - *      BBbWriteEmbedded        - Embedded write baseband register via MAC
> - *      BBbVT3253Init          - VIA VT3253 baseband chip init code
> + *      bb_b_read_embedded         - Embedded read baseband register via MAC
> + *      bb_b_write_embedded        - Embedded write baseband register via MAC
> + *      bb_b_vt3253_init          - VIA VT3253 baseband chip init code

The comments about the meaning of the variables should remain lines up.

[...]

> -	unsigned int uFrameTime;
> -	unsigned int uPreamble;
> -	unsigned int uTmp;
> -	unsigned int uRateIdx = (unsigned int)wRate;
> -	unsigned int uRate = 0;
> +	unsigned int u_frame_time;
> +	unsigned int u_preamble;
> +	unsigned int u_tmp;
> +	unsigned int u_rate_idx = (unsigned int)w_rate;
> +	unsigned int u_rate = 0;

All of these "u" names relate to the fact that the variable is unsigned,
which is a convention that the Linux kernel doesn't follow.  If you are
going to fix up the variable names, you may as well do it completely, ie
remove this problem as well.

julia