From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89A16C3A5A9 for ; Sat, 2 May 2020 23:05:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6DCA22072E for ; Sat, 2 May 2020 23:05:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728631AbgEBXFa (ORCPT ); Sat, 2 May 2020 19:05:30 -0400 Received: from gentwo.org ([3.19.106.255]:55972 "EHLO gentwo.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728587AbgEBXF3 (ORCPT ); Sat, 2 May 2020 19:05:29 -0400 Received: by gentwo.org (Postfix, from userid 1002) id DC6843E900; Sat, 2 May 2020 23:05:28 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by gentwo.org (Postfix) with ESMTP id DA7C53E817; Sat, 2 May 2020 23:05:28 +0000 (UTC) Date: Sat, 2 May 2020 23:05:28 +0000 (UTC) From: Christopher Lameter X-X-Sender: cl@www.lameter.com To: Srikar Dronamraju cc: Andrew Morton , linuxppc-dev@lists.ozlabs.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Michal Hocko , Mel Gorman , Vlastimil Babka , "Kirill A. Shutemov" , Michael Ellerman , Linus Torvalds , Gautham R Shenoy Subject: Re: [PATCH v3 3/3] mm/page_alloc: Keep memoryless cpuless node 0 offline In-Reply-To: <20200501031128.19584-4-srikar@linux.vnet.ibm.com> Message-ID: References: <20200501031128.19584-1-srikar@linux.vnet.ibm.com> <20200501031128.19584-4-srikar@linux.vnet.ibm.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 1 May 2020, Srikar Dronamraju wrote: > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -116,8 +116,10 @@ EXPORT_SYMBOL(latent_entropy); > */ > nodemask_t node_states[NR_NODE_STATES] __read_mostly = { > [N_POSSIBLE] = NODE_MASK_ALL, > +#ifdef CONFIG_NUMA > + [N_ONLINE] = NODE_MASK_NONE, Hmmm.... I would have expected that you would have added something early in boot that would mark the current node (whatever is is) online instead? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B00D7C3A5A9 for ; Sat, 2 May 2020 23:05:30 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 888302072E for ; Sat, 2 May 2020 23:05:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 888302072E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 210638E0005; Sat, 2 May 2020 19:05:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1C12E8E0001; Sat, 2 May 2020 19:05:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0FE838E0005; Sat, 2 May 2020 19:05:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0194.hostedemail.com [216.40.44.194]) by kanga.kvack.org (Postfix) with ESMTP id F013A8E0001 for ; Sat, 2 May 2020 19:05:29 -0400 (EDT) Received: from smtpin01.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id A824A52C1 for ; Sat, 2 May 2020 23:05:29 +0000 (UTC) X-FDA: 76773312378.01.cook05_6a242a180ee30 X-HE-Tag: cook05_6a242a180ee30 X-Filterd-Recvd-Size: 1937 Received: from gentwo.org (gentwo.org [3.19.106.255]) by imf13.hostedemail.com (Postfix) with ESMTP for ; Sat, 2 May 2020 23:05:29 +0000 (UTC) Received: by gentwo.org (Postfix, from userid 1002) id DC6843E900; Sat, 2 May 2020 23:05:28 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by gentwo.org (Postfix) with ESMTP id DA7C53E817; Sat, 2 May 2020 23:05:28 +0000 (UTC) Date: Sat, 2 May 2020 23:05:28 +0000 (UTC) From: Christopher Lameter X-X-Sender: cl@www.lameter.com To: Srikar Dronamraju cc: Andrew Morton , linuxppc-dev@lists.ozlabs.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Michal Hocko , Mel Gorman , Vlastimil Babka , "Kirill A. Shutemov" , Michael Ellerman , Linus Torvalds , Gautham R Shenoy Subject: Re: [PATCH v3 3/3] mm/page_alloc: Keep memoryless cpuless node 0 offline In-Reply-To: <20200501031128.19584-4-srikar@linux.vnet.ibm.com> Message-ID: References: <20200501031128.19584-1-srikar@linux.vnet.ibm.com> <20200501031128.19584-4-srikar@linux.vnet.ibm.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Bogosity: Ham, tests=bogofilter, spamicity=0.000038, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 1 May 2020, Srikar Dronamraju wrote: > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -116,8 +116,10 @@ EXPORT_SYMBOL(latent_entropy); > */ > nodemask_t node_states[NR_NODE_STATES] __read_mostly = { > [N_POSSIBLE] = NODE_MASK_ALL, > +#ifdef CONFIG_NUMA > + [N_ONLINE] = NODE_MASK_NONE, Hmmm.... I would have expected that you would have added something early in boot that would mark the current node (whatever is is) online instead? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 764D4C3A5A9 for ; Sat, 2 May 2020 23:08:08 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 27EBE2072E for ; Sat, 2 May 2020 23:08:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 27EBE2072E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 49F4Xk0X2wzDqh3 for ; Sun, 3 May 2020 09:08:06 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=softfail (domain owner discourages use of this host) smtp.mailfrom=linux.com (client-ip=3.19.106.255; helo=gentwo.org; envelope-from=cl@linux.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=linux.com Received: from gentwo.org (gentwo.org [3.19.106.255]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 49F4Tk70CkzDqZS for ; Sun, 3 May 2020 09:05:30 +1000 (AEST) Received: by gentwo.org (Postfix, from userid 1002) id DC6843E900; Sat, 2 May 2020 23:05:28 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by gentwo.org (Postfix) with ESMTP id DA7C53E817; Sat, 2 May 2020 23:05:28 +0000 (UTC) Date: Sat, 2 May 2020 23:05:28 +0000 (UTC) From: Christopher Lameter X-X-Sender: cl@www.lameter.com To: Srikar Dronamraju Subject: Re: [PATCH v3 3/3] mm/page_alloc: Keep memoryless cpuless node 0 offline In-Reply-To: <20200501031128.19584-4-srikar@linux.vnet.ibm.com> Message-ID: References: <20200501031128.19584-1-srikar@linux.vnet.ibm.com> <20200501031128.19584-4-srikar@linux.vnet.ibm.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Gautham R Shenoy , Michal Hocko , Linus Torvalds , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Mel Gorman , "Kirill A. Shutemov" , Andrew Morton , linuxppc-dev@lists.ozlabs.org, Vlastimil Babka Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Fri, 1 May 2020, Srikar Dronamraju wrote: > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -116,8 +116,10 @@ EXPORT_SYMBOL(latent_entropy); > */ > nodemask_t node_states[NR_NODE_STATES] __read_mostly = { > [N_POSSIBLE] = NODE_MASK_ALL, > +#ifdef CONFIG_NUMA > + [N_ONLINE] = NODE_MASK_NONE, Hmmm.... I would have expected that you would have added something early in boot that would mark the current node (whatever is is) online instead?