From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0290FC433DF for ; Thu, 4 Jun 2020 10:33:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CF6BA20738 for ; Thu, 4 Jun 2020 10:33:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725881AbgFDKd4 (ORCPT ); Thu, 4 Jun 2020 06:33:56 -0400 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:59193 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725601AbgFDKd4 (ORCPT ); Thu, 4 Jun 2020 06:33:56 -0400 X-IronPort-AV: E=Sophos;i="5.73,472,1583190000"; d="scan'208";a="452952018" Received: from abo-173-121-68.mrs.modulonet.fr (HELO hadrien) ([85.68.121.173]) by mail2-relais-roc.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Jun 2020 12:33:54 +0200 Date: Thu, 4 Jun 2020 12:33:53 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: Joe Perches cc: Dan Carpenter , Linus Walleij , Christophe JAILLET , Robert Jarzmik , Daniel Mack , Haojian Zhuang , Linux ARM , "open list:GPIO SUBSYSTEM" , "linux-kernel@vger.kernel.org" , kernel-janitors@vger.kernel.org Subject: Re: [PATCH] pinctrl: pxa: pxa2xx: Remove 'pxa2xx_pinctrl_exit()' which is unused and broken In-Reply-To: <32232229031e02edcc268b1074c9bac44012ee35.camel@perches.com> Message-ID: References: <20200531073716.593343-1-christophe.jaillet@wanadoo.fr> <87h7vvb1s3.fsf@belgarion.home> <20200601183102.GS30374@kadam> <20200604083120.GF22511@kadam> <2aa49a543e6f48a6f428a37b63a06f9149870225.camel@perches.com> <32232229031e02edcc268b1074c9bac44012ee35.camel@perches.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Thu, 4 Jun 2020, Joe Perches wrote: > On Thu, 2020-06-04 at 11:52 +0200, Julia Lawall wrote: > > Should Fixes also be used when the change will make it hard to port other > > fixes over it? > > If it's a logic defect or regression that's being fixed, > shouldn't the logic defect or regression be fixed as > reasonably soon as possible? Sure, but I recall seeing some patches that mentioned that the problem had existed since the beginning of git. Of course, it should be rare. > > The nature of the fix should ideally be optimal for > backporting, but I believe that should not stop any > consideration for the standalone fix itself. I'm not sure to follow this. Sometimes non-bug fixes that block backporting a bug fix have to be backported as well. So the fixes would again highlight the range of versions affected by the issue. julia > What do you think? > > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julia Lawall Date: Thu, 04 Jun 2020 10:33:53 +0000 Subject: Re: [PATCH] pinctrl: pxa: pxa2xx: Remove 'pxa2xx_pinctrl_exit()' which is unused and broken Message-Id: List-Id: References: <20200531073716.593343-1-christophe.jaillet@wanadoo.fr> <87h7vvb1s3.fsf@belgarion.home> <20200601183102.GS30374@kadam> <20200604083120.GF22511@kadam> <2aa49a543e6f48a6f428a37b63a06f9149870225.camel@perches.com> <32232229031e02edcc268b1074c9bac44012ee35.camel@perches.com> In-Reply-To: <32232229031e02edcc268b1074c9bac44012ee35.camel@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Joe Perches Cc: Linux ARM , Linus Walleij , kernel-janitors@vger.kernel.org, "linux-kernel@vger.kernel.org" , Haojian Zhuang , "open list:GPIO SUBSYSTEM" , Christophe JAILLET , Dan Carpenter , Robert Jarzmik , Daniel Mack On Thu, 4 Jun 2020, Joe Perches wrote: > On Thu, 2020-06-04 at 11:52 +0200, Julia Lawall wrote: > > Should Fixes also be used when the change will make it hard to port other > > fixes over it? > > If it's a logic defect or regression that's being fixed, > shouldn't the logic defect or regression be fixed as > reasonably soon as possible? Sure, but I recall seeing some patches that mentioned that the problem had existed since the beginning of git. Of course, it should be rare. > > The nature of the fix should ideally be optimal for > backporting, but I believe that should not stop any > consideration for the standalone fix itself. I'm not sure to follow this. Sometimes non-bug fixes that block backporting a bug fix have to be backported as well. So the fixes would again highlight the range of versions affected by the issue. julia > What do you think? > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EDDD2C433DF for ; Thu, 4 Jun 2020 10:33:59 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A64D62074B for ; Thu, 4 Jun 2020 10:33:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="dRh02FMZ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A64D62074B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=inria.fr Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:Message-ID: In-Reply-To:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=V7eUHWjCWwk/BmHcCAmjuE0gv07Go06STa+qcPyHcfM=; b=dRh02FMZaXyKcw 3JzzDoY5tFeax6tAOIP7JnZhOdiLGC9UAGDw9G4fFcltr1Uf6sXwXYnucqKQyX9kXgFHOVKsBc6VZ s1mhIxVo3ItOzBgiSOcCyhMrIdc1ZxH2lIYgrXLFN4MKU4B16+49eLs3t16g+geU8HoOvVGpsBzu5 WeSeMhTmRhYBbVenOEQfdaBiB963/bMg+2tBSMBoqfk2TnuB8lYxnDsaEQ+bkQAZLssvEwexk2h2s M04Hi47Yot6AkQpWG7PsAujvy9TLdHi5cltUwhMz4oT3FYI3kfaK4CbZ/dAeIATIHVouyqb6BlPUI QAINbsut5KKfQV6dKCpQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jgnCB-0005xp-6E; Thu, 04 Jun 2020 10:33:59 +0000 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jgnC8-0005xP-FW for linux-arm-kernel@lists.infradead.org; Thu, 04 Jun 2020 10:33:58 +0000 X-IronPort-AV: E=Sophos;i="5.73,472,1583190000"; d="scan'208";a="452952018" Received: from abo-173-121-68.mrs.modulonet.fr (HELO hadrien) ([85.68.121.173]) by mail2-relais-roc.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Jun 2020 12:33:54 +0200 Date: Thu, 4 Jun 2020 12:33:53 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: Joe Perches Subject: Re: [PATCH] pinctrl: pxa: pxa2xx: Remove 'pxa2xx_pinctrl_exit()' which is unused and broken In-Reply-To: <32232229031e02edcc268b1074c9bac44012ee35.camel@perches.com> Message-ID: References: <20200531073716.593343-1-christophe.jaillet@wanadoo.fr> <87h7vvb1s3.fsf@belgarion.home> <20200601183102.GS30374@kadam> <20200604083120.GF22511@kadam> <2aa49a543e6f48a6f428a37b63a06f9149870225.camel@perches.com> <32232229031e02edcc268b1074c9bac44012ee35.camel@perches.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200604_033356_791210_7BB6E1D4 X-CRM114-Status: GOOD ( 12.57 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Linux ARM , Linus Walleij , kernel-janitors@vger.kernel.org, "linux-kernel@vger.kernel.org" , Haojian Zhuang , "open list:GPIO SUBSYSTEM" , Christophe JAILLET , Dan Carpenter , Robert Jarzmik , Daniel Mack Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 4 Jun 2020, Joe Perches wrote: > On Thu, 2020-06-04 at 11:52 +0200, Julia Lawall wrote: > > Should Fixes also be used when the change will make it hard to port other > > fixes over it? > > If it's a logic defect or regression that's being fixed, > shouldn't the logic defect or regression be fixed as > reasonably soon as possible? Sure, but I recall seeing some patches that mentioned that the problem had existed since the beginning of git. Of course, it should be rare. > > The nature of the fix should ideally be optimal for > backporting, but I believe that should not stop any > consideration for the standalone fix itself. I'm not sure to follow this. Sometimes non-bug fixes that block backporting a bug fix have to be backported as well. So the fixes would again highlight the range of versions affected by the issue. julia > What do you think? > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel