All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lukas Bulwahn <lukas.bulwahn@gmail.com>
To: Ayush <ayush@disroot.org>
Cc: linux-kernel-mentees@lists.linuxfoundation.org
Subject: Re: [Linux-kernel-mentees] [PATCH v2] checkpatch: handle line break between commit and hash value
Date: Sat, 12 Sep 2020 16:15:15 +0200 (CEST)	[thread overview]
Message-ID: <alpine.DEB.2.21.2009121608490.22523@felia> (raw)
In-Reply-To: <20200912094826.150170-1-ayush@disroot.org>



On Sat, 12 Sep 2020, Ayush wrote:

> 
> Before applying this patch, checkpatch.pl reported 342 errors of type
> GIT_COMMIT_ID. After applying patch, errors reduced to 284.
>

I could not reproduce those numbers.

Can you share exactly what you are running? And can you share the list of 
differences in your report?

I have seen that the line number now has also changed in some cases.

We can check if the script really improves the detection or not.

>  my ${CONFIG_} = "CONFIG_";
> -
> +my $c_count = 0;

Why do you think this variable definition is supposed to be placed here?

Where are other variables with similar use defined in the checkpatch.pl 
script?

Lukas
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees

  parent reply	other threads:[~2020-09-12 14:15 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-12  9:48 [Linux-kernel-mentees] [PATCH v2] checkpatch: handle line break between commit and hash value Ayush
2020-09-12 11:17 ` Lukas Bulwahn
2020-09-12 12:42 ` Lukas Bulwahn
2020-09-12 13:34 ` Ayush
2020-09-12 14:15 ` Lukas Bulwahn [this message]
2020-09-12 15:38 ` Ayush
2020-09-12 19:37 ` Ayush
2020-09-13 11:01   ` Lukas Bulwahn
2020-09-13 12:06   ` Ayush
2020-09-13 18:09     ` Lukas Bulwahn
2020-09-13 20:53     ` Ayush
2020-09-14  5:12       ` Lukas Bulwahn
2020-09-17 14:53       ` Ayush
2020-09-17 15:17         ` Lukas Bulwahn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.21.2009121608490.22523@felia \
    --to=lukas.bulwahn@gmail.com \
    --cc=ayush@disroot.org \
    --cc=linux-kernel-mentees@lists.linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.