From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6FCDC63777 for ; Mon, 30 Nov 2020 21:25:19 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 57AD62076A for ; Mon, 30 Nov 2020 21:25:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="oYeuId2/" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 57AD62076A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.41471.74634 (Exim 4.92) (envelope-from ) id 1kjqfQ-00039W-Pl; Mon, 30 Nov 2020 21:25:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 41471.74634; Mon, 30 Nov 2020 21:25:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kjqfQ-00039P-Lq; Mon, 30 Nov 2020 21:25:04 +0000 Received: by outflank-mailman (input) for mailman id 41471; Mon, 30 Nov 2020 21:25:03 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kjqfP-00039K-HM for xen-devel@lists.xenproject.org; Mon, 30 Nov 2020 21:25:03 +0000 Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 99a77342-8768-4009-9563-bc1d3d4ffbc2; Mon, 30 Nov 2020 21:25:01 +0000 (UTC) Received: from sstabellini-ThinkPad-T480s (c-24-130-65-46.hsd1.ca.comcast.net [24.130.65.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4718A2076A; Mon, 30 Nov 2020 21:25:00 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 99a77342-8768-4009-9563-bc1d3d4ffbc2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1606771500; bh=e540j0UGjlJbQMyrXi4CmNfYK65m/QwHyK8BV8E9HeQ=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=oYeuId2/wXss50ZBVp9lxYjQ7qc2/XAmsERie0V7XWJmsSKk/fT7/N+cxiqua7Tzn dQm8HHCsPSxtSOFByoTITNOiMOBRe5gbCIGeOHKDAl54pXkQ0f4Y4+724uI+A2PTk5 ksoqwEWbZv8j2Q/a1EeemCjf5Ke/HBvhecmvGbkc= Date: Mon, 30 Nov 2020 13:24:59 -0800 (PST) From: Stefano Stabellini X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s To: Bertrand Marquis cc: Jan Beulich , Rahul Singh , Andrew Cooper , George Dunlap , Ian Jackson , Julien Grall , Stefano Stabellini , Wei Liu , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH v4 3/3] ns16550: Gate all PCI code with CONFIG_X86 In-Reply-To: Message-ID: References: <6d64bb35a6ce247faaa3df2ebae27b6bfa1d969e.1606326929.git.rahul.singh@arm.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Fri, 27 Nov 2020, Bertrand Marquis wrote: > Hi Jan, > > > On 27 Nov 2020, at 13:58, Jan Beulich wrote: > > > > On 25.11.2020 19:16, Rahul Singh wrote: > >> --- a/xen/drivers/char/ns16550.c > >> +++ b/xen/drivers/char/ns16550.c > >> @@ -16,7 +16,7 @@ > >> #include > >> #include > >> #include > >> -#ifdef CONFIG_HAS_PCI > >> +#if defined(CONFIG_X86) && defined(CONFIG_HAS_PCI) > >> #include > >> #include > >> #include > >> @@ -51,7 +51,7 @@ static struct ns16550 { > >> unsigned int timeout_ms; > >> bool_t intr_works; > >> bool_t dw_usr_bsy; > >> -#ifdef CONFIG_HAS_PCI > >> +#if defined(CONFIG_X86) && defined(CONFIG_HAS_PCI) > > > > I'm sorry to be picky, but this being a hack wants, imo, also calling > > it so, by way of a code comment. Clearly this should go at one of the > > first instances, yet neither of the two above are really suitable imo. > > Hence I'm coming back to my prior suggestion of introducing a > > consolidated #define without this becoming a Kconfig setting: > > > > /* > > * The PCI part of the code in this file currently is only known to > > * work on x86. Undo this hack once the logic has been suitably > > * abstracted. > > */ > > #if defined(CONFIG_HAS_PCI) && defined(CONFIG_X86) > > # define NS16550_PCI > > #endif > > > > And then use NS16550_PCI everywhere. I'd be fine making this > > adjustment while committing, if I knew that (a) you're okay with it > > and (b) the R-b and A-b you've already got can be kept. > > > > Sounds ok to me so you can keep my R-b if you go this way. I am OK with that too