From: Stefano Stabellini <sstabellini@kernel.org>
To: Oleksandr Tyshchenko <olekstysh@gmail.com>
Cc: xen-devel@lists.xenproject.org,
Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
Stefano Stabellini <sstabellini@kernel.org>,
Julien Grall <julien@xen.org>,
Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: Re: [PATCH] iommu/arm: ipmmu-vmsa: Use 1U << 31 rather than 1 << 31
Date: Mon, 11 Jan 2021 16:31:58 -0800 (PST) [thread overview]
Message-ID: <alpine.DEB.2.21.2101111631460.2495@sstabellini-ThinkPad-T480s> (raw)
In-Reply-To: <1610361235-32697-1-git-send-email-olekstysh@gmail.com>
On Mon, 11 Jan 2021, Oleksandr Tyshchenko wrote:
> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
>
> Replace all the use of 1 << 31 with 1U << 31 to prevent undefined
> behavior in the IPMMU-VMSA driver.
>
> Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
> ---
> This is a follow-up to
> https://patchew.org/Xen/20201224152419.22453-1-julien@xen.org/
> ---
> xen/drivers/passthrough/arm/ipmmu-vmsa.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/xen/drivers/passthrough/arm/ipmmu-vmsa.c b/xen/drivers/passthrough/arm/ipmmu-vmsa.c
> index 346165c..aef358d 100644
> --- a/xen/drivers/passthrough/arm/ipmmu-vmsa.c
> +++ b/xen/drivers/passthrough/arm/ipmmu-vmsa.c
> @@ -187,7 +187,7 @@ static DEFINE_SPINLOCK(ipmmu_devices_lock);
> #define IMCAAR 0x0004
>
> #define IMTTBCR 0x0008
> -#define IMTTBCR_EAE (1 << 31)
> +#define IMTTBCR_EAE (1U << 31)
> #define IMTTBCR_PMB (1 << 30)
> #define IMTTBCR_SH1_NON_SHAREABLE (0 << 28)
> #define IMTTBCR_SH1_OUTER_SHAREABLE (2 << 28)
> @@ -251,7 +251,7 @@ static DEFINE_SPINLOCK(ipmmu_devices_lock);
> #define IMUCTR(n) ((n) < 32 ? IMUCTR0(n) : IMUCTR32(n))
> #define IMUCTR0(n) (0x0300 + ((n) * 16))
> #define IMUCTR32(n) (0x0600 + (((n) - 32) * 16))
> -#define IMUCTR_FIXADDEN (1 << 31)
> +#define IMUCTR_FIXADDEN (1U << 31)
> #define IMUCTR_FIXADD_MASK (0xff << 16)
> #define IMUCTR_FIXADD_SHIFT 16
> #define IMUCTR_TTSEL_MMU(n) ((n) << 4)
> --
> 2.7.4
>
next prev parent reply other threads:[~2021-01-12 0:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-11 10:33 [PATCH] iommu/arm: ipmmu-vmsa: Use 1U << 31 rather than 1 << 31 Oleksandr Tyshchenko
2021-01-12 0:31 ` Stefano Stabellini [this message]
2021-01-12 9:51 ` Bertrand Marquis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.2101111631460.2495@sstabellini-ThinkPad-T480s \
--to=sstabellini@kernel.org \
--cc=Volodymyr_Babchuk@epam.com \
--cc=julien@xen.org \
--cc=oleksandr_tyshchenko@epam.com \
--cc=olekstysh@gmail.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.