From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F12A8C433E0 for ; Thu, 28 Jan 2021 17:14:09 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 891A964E21 for ; Thu, 28 Jan 2021 17:14:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 891A964E21 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.77290.139900 (Exim 4.92) (envelope-from ) id 1l5Arp-0001Rx-9b; Thu, 28 Jan 2021 17:14:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 77290.139900; Thu, 28 Jan 2021 17:14:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1l5Arp-0001Rq-5w; Thu, 28 Jan 2021 17:14:01 +0000 Received: by outflank-mailman (input) for mailman id 77290; Thu, 28 Jan 2021 17:14:00 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1l5Aro-0001Rj-3J for xen-devel@lists.xenproject.org; Thu, 28 Jan 2021 17:14:00 +0000 Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 882ed516-7f10-4cf6-ab65-97ef0d46b27a; Thu, 28 Jan 2021 17:13:59 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 9CB8664E21; Thu, 28 Jan 2021 17:13:57 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 882ed516-7f10-4cf6-ab65-97ef0d46b27a DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1611854038; bh=J3hC5Chiv1hO4uAwSJ+X1mfIKbQWk+GfB+EETNgggDQ=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=Eq0FV48P5lHzKa7PbVwfuOt0nes/i2FzhLnj/tLqKJWqgf18OriZDDldPD7c/7IY4 WouudFRmiqmMfnMPbxx0y/lDQazzPGn1DMbd4vkrVtQz8CGPHtMK6QSlRwIPpZRiXb CO8qQA+b3FHQ3fOLfUfHO2yLtdXLT1EwcV7Bbg0U1HvtVZ+WglKJsvdqMty36q0u2W OlIQ91/6e3325hr+gWCMh+4N8SmTVduNZ3nmDjaW6Kt2KXJrZ8+sRQHXpJQEOVMuxA INzmmkg1aUj3QWilOPWFjuppQCqjoh3UxzLpqtVK4VZBerGQ7Upg9jSRFXOe28ax+n 0Fn595zDz+FNg== Date: Thu, 28 Jan 2021 09:13:56 -0800 (PST) From: Stefano Stabellini X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s To: Oleksandr cc: Jan Beulich , Julien Grall , xen-devel , Oleksandr Tyshchenko , Andrew Cooper , George Dunlap , Ian Jackson , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Paul Durrant , Jun Nakajima , Kevin Tian , Tim Deegan , Julien Grall , Stefano Stabellini , Julien Grall Subject: Re: [PATCH V5 04/22] xen/ioreq: Make x86's IOREQ feature common In-Reply-To: Message-ID: References: <1611601709-28361-1-git-send-email-olekstysh@gmail.com> <1611601709-28361-5-git-send-email-olekstysh@gmail.com> <20270711-36bc-6d7d-16cb-4572cace47ed@gmail.com> <1156e356-5762-a196-ec16-bb6614912394@gmail.com> <0785367a-9349-ae0c-2622-9412297773fc@suse.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="8323329-1293718514-1611854038=:9684" This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-1293718514-1611854038=:9684 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT On Thu, 28 Jan 2021, Oleksandr wrote: > On 28.01.21 13:21, Jan Beulich wrote: > > On 28.01.2021 12:01, Oleksandr wrote: > > > On 27.01.21 22:46, Stefano Stabellini wrote: > > > > On Wed, 27 Jan 2021, Oleksandr wrote: > > > > > Thank you. I got a request to make a possibility for user to select > > > > > IOREQ via > > > > > the menuconfig on Arm. Saying tech preview do you mean that I also > > > > > need to put > > > > > it under CONFIG_EXPERT on Arm? > > > > Normally I would say that unless it actually takes an expert to enable > > > > the feature, it is better to make it depend on CONFIG_UNSUPPORTED [1]. > > > > > > > > However, in this case, it might actually take an expert :-) > > > > Additional patches are still required to enable the feature at the > > > > toolstack level, and also the user needs to build a userspace ioreq > > > > server. So in this case I am fine either way. I'll leave it up to you > > > > and Julien to pick the best one. > > > > > > > > Either way, please add "(EXPERT)" or "(UNSUPPORTED)" in the one-line > > > > kconfig description for ARM if possible. > > > > > > > > > > > > [1] https://marc.info/?l=xen-devel&m=161168780401884 > > > Thank you for the explanation, personally I would prefer EXPERT, but... > > > > > > It would be really nice if we could agreed regarding that *common* > > > Kconfig option before I submit V6 (which would probably avoid me to send > > > V7 I hope). > > > > > > Now I see it as following (please note, it is a subject for new patch in > > > this series, which should come last): > > > > > > +++ b/xen/common/Kconfig > > > @@ -137,7 +137,13 @@ config HYPFS_CONFIG > > >           want to hide the .config contents from dom0. > > > > > >  config IOREQ_SERVER > > > -       bool > > > +       bool "IOREQ support" if EXPERT || X86 > > This would make the prompt visible for x86, which we don't > > want. > > Hmm, I missed that point. > > > > But I guess Stefano was anyway after ... > > > > > +       default X86 > > > +       depends on HVM > > > +       ---help--- > > > +         Enables generic mechanism for providing emulated devices to > > > the guests. > > > + > > > +         If unsure, say Y. > > config IOREQ_SERVER > > bool "IOREQ support (EXPERT)" if EXPERT && !X86 > > default X86 > > depends on HVM > > > > As the prompt should be invisible this way on x86, the (EXPERT) > > doesn't need further qualifying, except maybe in the help text > > (just to avoid this being taken as a possible mistake). > > Yes, this works as my initial version *but* is invisible on x86, > > what is more that indeed the *EXPERT* tag for IOREQ on x86 will look quite > odd... > > Perfect, thank you. Yep, perfect --8323329-1293718514-1611854038=:9684--