From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8851BC433DB for ; Sat, 13 Feb 2021 15:18:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5B92264E3F for ; Sat, 13 Feb 2021 15:18:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229710AbhBMPSf (ORCPT ); Sat, 13 Feb 2021 10:18:35 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44886 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229649AbhBMPSc (ORCPT ); Sat, 13 Feb 2021 10:18:32 -0500 Received: from angie.orcam.me.uk (angie.orcam.me.uk [IPv6:2001:4190:8020::4]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id C2BADC061574; Sat, 13 Feb 2021 07:17:51 -0800 (PST) Received: by angie.orcam.me.uk (Postfix, from userid 500) id 499989200BF; Sat, 13 Feb 2021 16:17:50 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by angie.orcam.me.uk (Postfix) with ESMTP id 464369200BC; Sat, 13 Feb 2021 16:17:50 +0100 (CET) Date: Sat, 13 Feb 2021 16:17:50 +0100 (CET) From: "Maciej W. Rozycki" To: Jiaxun Yang cc: Jinyang He , Thomas Bogendoerfer , Steven Rostedt , Ingo Molnar , Wu Zhangjin , "linux-mips@vger.kernel.org" , linux-kernel@vger.kernel.org, Huacai Chen , Tiezhu Yang Subject: Re: [PATCH 1/3] MIPS: ftrace: Fix N32 save registers In-Reply-To: <83e49b6e-9c9d-407e-8ac1-f3fad63df915@www.fastmail.com> Message-ID: References: <1612080878-5426-1-git-send-email-hejinyang@loongson.cn> <83e49b6e-9c9d-407e-8ac1-f3fad63df915@www.fastmail.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 1 Feb 2021, Jiaxun Yang wrote: > > Thank you for your reply, and now I know. Before that, I saw the macro > > from arch/mips/include/asm/regdef.h and thought it needed to be modified > > here. But that seems have no sence. > > Please ignore this patch. > > I guess that's for uapi consideration. Nope, it's not under arch/mips/include/uapi/, but this is a common MIPS header used across many projects (see the copyright notices at the top going back to 1985), so there has been no sense to make Linux-specific changes to it just for the sake of it given that it works as it stands. Don't fix what ain't broke. Don't make changes just because you can. Maciej