From: Stefano Stabellini <sstabellini@kernel.org>
To: Julien Grall <julien@xen.org>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
Bertrand Marquis <Bertrand.Marquis@arm.com>,
"xen-devel@lists.xenproject.org"
<xen-devel@lists.xenproject.org>,
"iwj@xenproject.org" <iwj@xenproject.org>,
Julien Grall <jgrall@amazon.com>,
Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
dfaggioli@suse.com, George.Dunlap@citrix.com
Subject: Re: [PATCH for-4.15] xen/vgic: Implement write to ISPENDR in vGICv{2, 3}
Date: Tue, 23 Feb 2021 12:40:27 -0800 (PST) [thread overview]
Message-ID: <alpine.DEB.2.21.2102231237410.3234@sstabellini-ThinkPad-T480s> (raw)
In-Reply-To: <767e2028-ca86-bd0f-e936-c386066c11c8@xen.org>
On Tue, 23 Feb 2021, Julien Grall wrote:
> Hi Stefano,
>
> On 23/02/2021 01:24, Stefano Stabellini wrote:
> > On Mon, 22 Feb 2021, Bertrand Marquis wrote:
> > > > On 20 Feb 2021, at 14:04, Julien Grall <julien@xen.org> wrote:
> > The consequence of this patch is that a guest can cause vcpu_unblock(v),
> > hence vcpu_wake(v), to be called for its own vcpu, which basically
> > always changes v to RUNSTATE_runnable. However, that alone shouldn't
> > allow v to always come up ahead of any other vcpus in the queue, right?
> > It should be safe. I just wanted a second opinion on this :-)
>
> vcpu_wake() only tells the scheduler that the vCPU can be run, it is then up
> to the scheduler to decide what to do. AFAIU, for credit{1, 2}, each vCPU will
> have some credit. If you run out of credit, then you vCPU will not be
> descheduled if there is work do it.
OK, great, it matches my understanding. Thanks for checking.
Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
next prev parent reply other threads:[~2021-02-23 20:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-20 14:04 [PATCH for-4.15] xen/vgic: Implement write to ISPENDR in vGICv{2, 3} Julien Grall
2021-02-22 11:10 ` Ian Jackson
2021-02-22 13:45 ` Bertrand Marquis
2021-02-23 1:24 ` Stefano Stabellini
2021-02-23 10:31 ` Julien Grall
2021-02-23 20:40 ` Stefano Stabellini [this message]
2021-02-25 12:22 ` Julien Grall
2021-02-25 21:27 ` Stefano Stabellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.2102231237410.3234@sstabellini-ThinkPad-T480s \
--to=sstabellini@kernel.org \
--cc=Bertrand.Marquis@arm.com \
--cc=George.Dunlap@citrix.com \
--cc=Volodymyr_Babchuk@epam.com \
--cc=dfaggioli@suse.com \
--cc=iwj@xenproject.org \
--cc=jgrall@amazon.com \
--cc=julien@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.