From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA19BC433E0 for ; Fri, 19 Mar 2021 00:13:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9105E64EB9 for ; Fri, 19 Mar 2021 00:13:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230478AbhCSAND (ORCPT ); Thu, 18 Mar 2021 20:13:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40478 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230477AbhCSAMo (ORCPT ); Thu, 18 Mar 2021 20:12:44 -0400 Received: from angie.orcam.me.uk (angie.orcam.me.uk [IPv6:2001:4190:8020::4]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id CA976C06174A; Thu, 18 Mar 2021 17:12:43 -0700 (PDT) Received: by angie.orcam.me.uk (Postfix, from userid 500) id 0DF1592009C; Fri, 19 Mar 2021 01:12:38 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by angie.orcam.me.uk (Postfix) with ESMTP id F30ED92009B; Fri, 19 Mar 2021 01:12:38 +0100 (CET) Date: Fri, 19 Mar 2021 01:12:38 +0100 (CET) From: "Maciej W. Rozycki" To: Christoph Hellwig cc: "David S. Miller" , Jens Axboe , Geert Uytterhoeven , Richard Henderson , Ivan Kokshaysky , Matt Turner , Russell King , Thomas Bogendoerfer , Michael Ellerman , linux-ide@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH 04/10] MIPS: disable CONFIG_IDE in sb1250_swarm_defconfig In-Reply-To: <20210318045706.200458-5-hch@lst.de> Message-ID: References: <20210318045706.200458-1-hch@lst.de> <20210318045706.200458-5-hch@lst.de> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org On Thu, 18 Mar 2021, Christoph Hellwig wrote: > sb1250_swarm_defconfig enables CONFIG_IDE but no actual host controller > driver, so just drop CONFIG_IDE, CONFIG_BLK_DEV_IDECD and > CONFIG_BLK_DEV_IDETAPE as they are useless. Actually BLK_DEV_PLATFORM would handle the SWARM's platform driver as an IDE device, however the driver has supported libata ever since commit 2fef357cf391 ("IDE: Fix platform device registration in Swarm IDE driver (v2)") back in 2008, so this is good to go. We should probably enable PATA_PLATFORM in the defconfig instead. The printed name of the driver could be improved I suppose though: scsi host0: pata_platform ata1: PATA max PIO0 mmio cmd 0x100b3e00 ctl 0x100b7ec0 irq 36 (PIO3 is actually hardwired; it's an odd interface and people reported issues with it, but I have never had any myself be it with IDE or libata). Acked-by: Maciej W. Rozycki Maciej From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A79CC433E0 for ; Fri, 19 Mar 2021 02:26:25 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1363064DE2 for ; Fri, 19 Mar 2021 02:26:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1363064DE2 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=orcam.me.uk Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4F1nnp4fZ4z3cFd for ; Fri, 19 Mar 2021 13:26:22 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=orcam.me.uk (client-ip=157.25.102.26; helo=angie.orcam.me.uk; envelope-from=macro@orcam.me.uk; receiver=) X-Greylist: delayed 376 seconds by postgrey-1.36 at boromir; Fri, 19 Mar 2021 11:19:08 AEDT Received: from angie.orcam.me.uk (angie.orcam.me.uk [157.25.102.26]) by lists.ozlabs.org (Postfix) with ESMTP id 4F1kz01zyRz30NB for ; Fri, 19 Mar 2021 11:19:08 +1100 (AEDT) Received: by angie.orcam.me.uk (Postfix, from userid 500) id 0DF1592009C; Fri, 19 Mar 2021 01:12:38 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by angie.orcam.me.uk (Postfix) with ESMTP id F30ED92009B; Fri, 19 Mar 2021 01:12:38 +0100 (CET) Date: Fri, 19 Mar 2021 01:12:38 +0100 (CET) From: "Maciej W. Rozycki" To: Christoph Hellwig Subject: Re: [PATCH 04/10] MIPS: disable CONFIG_IDE in sb1250_swarm_defconfig In-Reply-To: <20210318045706.200458-5-hch@lst.de> Message-ID: References: <20210318045706.200458-1-hch@lst.de> <20210318045706.200458-5-hch@lst.de> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Mailman-Approved-At: Fri, 19 Mar 2021 13:25:13 +1100 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jens Axboe , Thomas Bogendoerfer , linux-doc@vger.kernel.org, Russell King , linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org, linux-m68k@lists.linux-m68k.org, Ivan Kokshaysky , linux-alpha@vger.kernel.org, Geert Uytterhoeven , Matt Turner , linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, "David S. Miller" , linux-arm-kernel@lists.infradead.org, Richard Henderson Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Thu, 18 Mar 2021, Christoph Hellwig wrote: > sb1250_swarm_defconfig enables CONFIG_IDE but no actual host controller > driver, so just drop CONFIG_IDE, CONFIG_BLK_DEV_IDECD and > CONFIG_BLK_DEV_IDETAPE as they are useless. Actually BLK_DEV_PLATFORM would handle the SWARM's platform driver as an IDE device, however the driver has supported libata ever since commit 2fef357cf391 ("IDE: Fix platform device registration in Swarm IDE driver (v2)") back in 2008, so this is good to go. We should probably enable PATA_PLATFORM in the defconfig instead. The printed name of the driver could be improved I suppose though: scsi host0: pata_platform ata1: PATA max PIO0 mmio cmd 0x100b3e00 ctl 0x100b7ec0 irq 36 (PIO3 is actually hardwired; it's an odd interface and people reported issues with it, but I have never had any myself be it with IDE or libata). Acked-by: Maciej W. Rozycki Maciej From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6FBF1C433DB for ; Fri, 19 Mar 2021 00:14:23 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0855564F1B for ; Fri, 19 Mar 2021 00:14:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0855564F1B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=orcam.me.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:Message-ID:In-Reply-To: Subject:cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ojh9GQf7QjjgS+if3XIRfboElCdhBuDSIs9BRGGPOXo=; b=FUFdGMUWVcWd60oXQQi85LeyL +DlfyyybGMCyYEkFTQNLMgdDVXEdQ9MQvU8fphxImNJU2iSIlkBm5r+fyn29QVSE6Ua4jpXq8G2oo ovEs7SeohgQZWiGNxBz3GNNJ4kIjQIgld8hFMAHGl4Fu5fdqMzXC27EtjvaXs70bp9oJcOEJQQges Jkv61jYpcAoJ5Aa90Vmh44cQq7N9aLj9eHuvdRhPnznn3Qx21b05ec8wKaxEEgpA6eET1anZQ3khe F8ZH3U9IBijr3PmL3yOO7ipNXv5kZRoioXID2vFNumajbqBW1HHPiZ+Vgl3grIk85zXPs9LXiaAfa QYYfvHPcg==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lN2kz-006DQJ-1m; Fri, 19 Mar 2021 00:12:49 +0000 Received: from angie.orcam.me.uk ([157.25.102.26]) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lN2ks-006DPT-PP for linux-arm-kernel@lists.infradead.org; Fri, 19 Mar 2021 00:12:44 +0000 Received: by angie.orcam.me.uk (Postfix, from userid 500) id 0DF1592009C; Fri, 19 Mar 2021 01:12:38 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by angie.orcam.me.uk (Postfix) with ESMTP id F30ED92009B; Fri, 19 Mar 2021 01:12:38 +0100 (CET) Date: Fri, 19 Mar 2021 01:12:38 +0100 (CET) From: "Maciej W. Rozycki" To: Christoph Hellwig cc: "David S. Miller" , Jens Axboe , Geert Uytterhoeven , Richard Henderson , Ivan Kokshaysky , Matt Turner , Russell King , Thomas Bogendoerfer , Michael Ellerman , linux-ide@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH 04/10] MIPS: disable CONFIG_IDE in sb1250_swarm_defconfig In-Reply-To: <20210318045706.200458-5-hch@lst.de> Message-ID: References: <20210318045706.200458-1-hch@lst.de> <20210318045706.200458-5-hch@lst.de> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210319_001243_017802_B67638C2 X-CRM114-Status: GOOD ( 10.13 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 18 Mar 2021, Christoph Hellwig wrote: > sb1250_swarm_defconfig enables CONFIG_IDE but no actual host controller > driver, so just drop CONFIG_IDE, CONFIG_BLK_DEV_IDECD and > CONFIG_BLK_DEV_IDETAPE as they are useless. Actually BLK_DEV_PLATFORM would handle the SWARM's platform driver as an IDE device, however the driver has supported libata ever since commit 2fef357cf391 ("IDE: Fix platform device registration in Swarm IDE driver (v2)") back in 2008, so this is good to go. We should probably enable PATA_PLATFORM in the defconfig instead. The printed name of the driver could be improved I suppose though: scsi host0: pata_platform ata1: PATA max PIO0 mmio cmd 0x100b3e00 ctl 0x100b7ec0 irq 36 (PIO3 is actually hardwired; it's an odd interface and people reported issues with it, but I have never had any myself be it with IDE or libata). Acked-by: Maciej W. Rozycki Maciej _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel