From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8E04C43462 for ; Wed, 21 Apr 2021 12:28:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B806960233 for ; Wed, 21 Apr 2021 12:28:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239835AbhDUM3U (ORCPT ); Wed, 21 Apr 2021 08:29:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58696 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239808AbhDUM3R (ORCPT ); Wed, 21 Apr 2021 08:29:17 -0400 Received: from angie.orcam.me.uk (angie.orcam.me.uk [IPv6:2001:4190:8020::4]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id ED080C06174A; Wed, 21 Apr 2021 05:28:43 -0700 (PDT) Received: by angie.orcam.me.uk (Postfix, from userid 500) id F02F792009C; Wed, 21 Apr 2021 14:28:41 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by angie.orcam.me.uk (Postfix) with ESMTP id E940492009B; Wed, 21 Apr 2021 14:28:41 +0200 (CEST) Date: Wed, 21 Apr 2021 14:28:41 +0200 (CEST) From: "Maciej W. Rozycki" To: David Laight cc: Joe Perches , Khalid Aziz , "James E.J. Bottomley" , "Martin K. Petersen" , Christoph Hellwig , "linux-scsi@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" Subject: RE: [PATCH v2 1/5] scsi: BusLogic: Fix missing `pr_cont' use In-Reply-To: Message-ID: References: User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 21 Apr 2021, David Laight wrote: > > Update BusLogic driver's messaging system to use `pr_cont' for > > continuation lines, bringing messy output: > > If reasonably possible it is best to avoid use of pr_cont(). I know, however for that the whole driver's messaging system would have to be redesigned. Joe (cc-ed) has offered to do it with the original iteration, however I believe consensus has been it will best be done as a separate follow-up change, while this small fix can be easily backported. > If there are concurrent writes from multiple cpu I believe > the writes still get separated. > (Something has to give...) NB this driver may not see a lot of SMP use as I reckon it's had some portability issues, and in any case the hardware requires port I/O which precludes its use with some of the most recent PCIe systems which do not support PCI I/O cycles anymore. And older systems were often UP. Not that the driver should not be kept in a clean style of course. Maciej