From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6FE85C48BC2 for ; Wed, 23 Jun 2021 23:39:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 490D060FE3 for ; Wed, 23 Jun 2021 23:39:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229949AbhFWXlh (ORCPT ); Wed, 23 Jun 2021 19:41:37 -0400 Received: from angie.orcam.me.uk ([78.133.224.34]:59892 "EHLO angie.orcam.me.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229994AbhFWXlf (ORCPT ); Wed, 23 Jun 2021 19:41:35 -0400 Received: by angie.orcam.me.uk (Postfix, from userid 500) id EE0029200BB; Thu, 24 Jun 2021 01:39:14 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by angie.orcam.me.uk (Postfix) with ESMTP id EA54F92009D; Thu, 24 Jun 2021 01:39:14 +0200 (CEST) Date: Thu, 24 Jun 2021 01:39:14 +0200 (CEST) From: "Maciej W. Rozycki" To: Nikolai Zhubr cc: Arnd Bergmann , Thomas Gleixner , Heiner Kallweit , netdev , the arch/x86 maintainers , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" Subject: Re: Realtek 8139 problem on 486. In-Reply-To: <60D361FF.70905@gmail.com> Message-ID: References: <60B24AC2.9050505@gmail.com> <60B514A0.1020701@gmail.com> <60B560A8.8000800@gmail.com> <49f40dd8-da68-f579-b359-7a7e229565e1@gmail.com> <60B611C6.2000801@gmail.com> <60B65BBB.2040507@gmail.com> <877dipgyrb.ffs@nanos.tec.linutronix.de> <60D1DAC1.9060200@gmail.com> <60D22F1D.1000205@gmail.com> <60D361FF.70905@gmail.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, 23 Jun 2021, Nikolai Zhubr wrote: > > As I said before, I still think we should also merge the 8139 driver patch, > > probably without that loop. It's not great, but I'm much more confident > > I understand what that does and that the patched version is better than > > the current code. > > Yes, the 'poll' approach apparently works stable and does not cause any > measurable performance decrease. But it would need some carefull > cleanup/review, especially WRT locking. Now that all real event handling work > is happening in the poll function, it still has to be protected against the > (potentially also long-running) reset function which in current design can be > called e.g. from a different thread due to tx timeout, and this does not look > good, but it is a bit beyond my capability to arrange it better. Besides, the > idea was to keep the fix simple and avoid a massive rework... The simplest fix is not always the right one. I've now posted a small patch series that adds a PCI IRQ router for the SiS85C497 device. Would you please try it with your system along with the debug patch included below and send me the resulting bootstap log? Maciej --- arch/x86/include/asm/pci_x86.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: linux-macro-ide/arch/x86/include/asm/pci_x86.h =================================================================== --- linux-macro-ide.orig/arch/x86/include/asm/pci_x86.h +++ linux-macro-ide/arch/x86/include/asm/pci_x86.h @@ -7,7 +7,7 @@ #include -#undef DEBUG +#define DEBUG 1 #ifdef DEBUG #define DBG(fmt, ...) printk(fmt, ##__VA_ARGS__)