From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92D5CC433EF for ; Sat, 4 Sep 2021 17:58:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6D29A60F90 for ; Sat, 4 Sep 2021 17:58:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237237AbhIDR7C (ORCPT ); Sat, 4 Sep 2021 13:59:02 -0400 Received: from angie.orcam.me.uk ([78.133.224.34]:33188 "EHLO angie.orcam.me.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237178AbhIDR7C (ORCPT ); Sat, 4 Sep 2021 13:59:02 -0400 Received: by angie.orcam.me.uk (Postfix, from userid 500) id F11A892009C; Sat, 4 Sep 2021 19:57:56 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by angie.orcam.me.uk (Postfix) with ESMTP id E1AEA92009B; Sat, 4 Sep 2021 19:57:56 +0200 (CEST) Date: Sat, 4 Sep 2021 19:57:56 +0200 (CEST) From: "Maciej W. Rozycki" To: Huang Pei cc: Thomas Bogendoerfer , ambrosehua@gmail.com, Bibo Mao , linux-mips@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, Jiaxun Yang , Paul Burton , Li Xuefeng , Yang Tiezhu , Gao Juxin , Huacai Chen , Jinyang He , Steven Rostedt , Jisheng Zhang , Masami Hiramatsu Subject: Re: [PATCH] MIPS: fix local_t operation on MIPS64 In-Reply-To: <20210904151218.10167-1-huangpei@loongson.cn> Message-ID: References: <20210904151218.10167-1-huangpei@loongson.cn> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-arch@vger.kernel.org On Sat, 4 Sep 2021, Huang Pei wrote: > diff --git a/arch/mips/include/asm/llsc.h b/arch/mips/include/asm/llsc.h > index ec09fe5d6d6c..788e26ad7fca 100644 > --- a/arch/mips/include/asm/llsc.h > +++ b/arch/mips/include/asm/llsc.h > @@ -16,11 +16,15 @@ > #define __SC "sc " > #define __INS "ins " > #define __EXT "ext " > +#define __ADDU "addu " > +#define __SUBU "subu " > #elif _MIPS_SZLONG == 64 > #define __LL "lld " > #define __SC "scd " > #define __INS "dins " > #define __EXT "dext " > +#define __ADDU "daddu " > +#define __SUBU "dsubu " Why invent things instead of using standard macros (LONG_ADDU/LONG_SUBU)? Maciej From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F3B5C433FE for ; Sat, 4 Sep 2021 17:58:02 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 8D2B460FA0 for ; Sat, 4 Sep 2021 17:58:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 8D2B460FA0 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=orcam.me.uk Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id AC163900002; Sat, 4 Sep 2021 13:58:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A709A6B0072; Sat, 4 Sep 2021 13:58:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 98632900002; Sat, 4 Sep 2021 13:58:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0030.hostedemail.com [216.40.44.30]) by kanga.kvack.org (Postfix) with ESMTP id 889F06B0071 for ; Sat, 4 Sep 2021 13:58:00 -0400 (EDT) Received: from smtpin02.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 46D9C1853848A for ; Sat, 4 Sep 2021 17:58:00 +0000 (UTC) X-FDA: 78550649520.02.A5A73BA Received: from angie.orcam.me.uk (angie.orcam.me.uk [78.133.224.34]) by imf15.hostedemail.com (Postfix) with ESMTP id 9E235D000099 for ; Sat, 4 Sep 2021 17:57:59 +0000 (UTC) Received: by angie.orcam.me.uk (Postfix, from userid 500) id F11A892009C; Sat, 4 Sep 2021 19:57:56 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by angie.orcam.me.uk (Postfix) with ESMTP id E1AEA92009B; Sat, 4 Sep 2021 19:57:56 +0200 (CEST) Date: Sat, 4 Sep 2021 19:57:56 +0200 (CEST) From: "Maciej W. Rozycki" To: Huang Pei cc: Thomas Bogendoerfer , ambrosehua@gmail.com, Bibo Mao , linux-mips@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, Jiaxun Yang , Paul Burton , Li Xuefeng , Yang Tiezhu , Gao Juxin , Huacai Chen , Jinyang He , Steven Rostedt , Jisheng Zhang , Masami Hiramatsu Subject: Re: [PATCH] MIPS: fix local_t operation on MIPS64 In-Reply-To: <20210904151218.10167-1-huangpei@loongson.cn> Message-ID: References: <20210904151218.10167-1-huangpei@loongson.cn> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Authentication-Results: imf15.hostedemail.com; dkim=none; spf=none (imf15.hostedemail.com: domain of macro@orcam.me.uk has no SPF policy when checking 78.133.224.34) smtp.mailfrom=macro@orcam.me.uk; dmarc=none X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 9E235D000099 X-Stat-Signature: co37a5deyo7j8qcqytbxd5kba8c6j3o4 X-HE-Tag: 1630778279-798637 X-Bogosity: Ham, tests=bogofilter, spamicity=0.265714, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, 4 Sep 2021, Huang Pei wrote: > diff --git a/arch/mips/include/asm/llsc.h b/arch/mips/include/asm/llsc.h > index ec09fe5d6d6c..788e26ad7fca 100644 > --- a/arch/mips/include/asm/llsc.h > +++ b/arch/mips/include/asm/llsc.h > @@ -16,11 +16,15 @@ > #define __SC "sc " > #define __INS "ins " > #define __EXT "ext " > +#define __ADDU "addu " > +#define __SUBU "subu " > #elif _MIPS_SZLONG == 64 > #define __LL "lld " > #define __SC "scd " > #define __INS "dins " > #define __EXT "dext " > +#define __ADDU "daddu " > +#define __SUBU "dsubu " Why invent things instead of using standard macros (LONG_ADDU/LONG_SUBU)? Maciej