From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B32ABC433EF for ; Fri, 10 Sep 2021 23:23:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9A60561206 for ; Fri, 10 Sep 2021 23:23:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234660AbhIJXYh (ORCPT ); Fri, 10 Sep 2021 19:24:37 -0400 Received: from mail.kernel.org ([198.145.29.99]:33482 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234798AbhIJXYc (ORCPT ); Fri, 10 Sep 2021 19:24:32 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 2949961206; Fri, 10 Sep 2021 23:23:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1631316201; bh=N7LKktutD+QwQybp5f/rKrBsVZiJeC/R7umGYSMMqXk=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=TYKH7ZNKWMXywDAwVeL41AEHBwT+2Vzt7M/6twb7POXVBhQz+P2DkIFADYuFtOdGx LF5gd7EKeDKaPExyAi4PbCfFtOpf4PZKeC0CAoYYc7ez0923ROqEZUr7zW85B4ktpa lDlIki6s0Z4rv0McrrYS37v9U87OlK9g27aPge3XQfDC23vaKfSY+DESsMrbkfCJf6 VosSrN7sZEIiDmiae/9ba5j5NXfePWjNrK56ye2MER1IFu1M4Imlq6wZv8foOSJtF8 8QDQKcxjTlAh5c1MqN8Q6IUytTWPH7eBVXeIsK3kgdDK5RHZuOPPn4d6ft5vBuA0me boG9DR4Cs9CZA== Date: Fri, 10 Sep 2021 16:23:20 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s To: Jan Beulich cc: Juergen Gross , Boris Ostrovsky , Stefano Stabellini , lkml , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH 06/12] swiotlb-xen: limit init retries In-Reply-To: <984fa426-2b7b-4b77-5ce8-766619575b7f@suse.com> Message-ID: References: <588b3e6d-2682-160c-468e-44ca4867a570@suse.com> <984fa426-2b7b-4b77-5ce8-766619575b7f@suse.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 7 Sep 2021, Jan Beulich wrote: > Due to the use of max(1024, ...) there's no point retrying (and issuing > bogus log messages) when the number of slabs is already no larger than > this minimum value. > > Signed-off-by: Jan Beulich Reviewed-by: Stefano Stabellini > --- a/drivers/xen/swiotlb-xen.c > +++ b/drivers/xen/swiotlb-xen.c > @@ -207,7 +207,7 @@ retry: > swiotlb_set_max_segment(PAGE_SIZE); > return 0; > error: > - if (repeat--) { > + if (nslabs > 1024 && repeat--) { > /* Min is 2MB */ > nslabs = max(1024UL, ALIGN(nslabs >> 1, IO_TLB_SEGSIZE)); > bytes = nslabs << IO_TLB_SHIFT; > @@ -243,7 +243,7 @@ retry: > rc = xen_swiotlb_fixup(start, nslabs); > if (rc) { > memblock_free(__pa(start), PAGE_ALIGN(bytes)); > - if (repeat--) { > + if (nslabs > 1024 && repeat--) { > /* Min is 2MB */ > nslabs = max(1024UL, ALIGN(nslabs >> 1, IO_TLB_SEGSIZE)); > bytes = nslabs << IO_TLB_SHIFT; > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 834C7C433F5 for ; Fri, 10 Sep 2021 23:23:34 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4F34F61214 for ; Fri, 10 Sep 2021 23:23:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 4F34F61214 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.184850.333628 (Exim 4.92) (envelope-from ) id 1mOprf-0007Kl-NK; Fri, 10 Sep 2021 23:23:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 184850.333628; Fri, 10 Sep 2021 23:23:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mOprf-0007Ke-Jw; Fri, 10 Sep 2021 23:23:23 +0000 Received: by outflank-mailman (input) for mailman id 184850; Fri, 10 Sep 2021 23:23:22 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mOpre-0007KY-On for xen-devel@lists.xenproject.org; Fri, 10 Sep 2021 23:23:22 +0000 Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id d208a4f4-f201-42f6-9efc-e5b3668f1202; Fri, 10 Sep 2021 23:23:22 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 2949961206; Fri, 10 Sep 2021 23:23:21 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d208a4f4-f201-42f6-9efc-e5b3668f1202 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1631316201; bh=N7LKktutD+QwQybp5f/rKrBsVZiJeC/R7umGYSMMqXk=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=TYKH7ZNKWMXywDAwVeL41AEHBwT+2Vzt7M/6twb7POXVBhQz+P2DkIFADYuFtOdGx LF5gd7EKeDKaPExyAi4PbCfFtOpf4PZKeC0CAoYYc7ez0923ROqEZUr7zW85B4ktpa lDlIki6s0Z4rv0McrrYS37v9U87OlK9g27aPge3XQfDC23vaKfSY+DESsMrbkfCJf6 VosSrN7sZEIiDmiae/9ba5j5NXfePWjNrK56ye2MER1IFu1M4Imlq6wZv8foOSJtF8 8QDQKcxjTlAh5c1MqN8Q6IUytTWPH7eBVXeIsK3kgdDK5RHZuOPPn4d6ft5vBuA0me boG9DR4Cs9CZA== Date: Fri, 10 Sep 2021 16:23:20 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s To: Jan Beulich cc: Juergen Gross , Boris Ostrovsky , Stefano Stabellini , lkml , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH 06/12] swiotlb-xen: limit init retries In-Reply-To: <984fa426-2b7b-4b77-5ce8-766619575b7f@suse.com> Message-ID: References: <588b3e6d-2682-160c-468e-44ca4867a570@suse.com> <984fa426-2b7b-4b77-5ce8-766619575b7f@suse.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Tue, 7 Sep 2021, Jan Beulich wrote: > Due to the use of max(1024, ...) there's no point retrying (and issuing > bogus log messages) when the number of slabs is already no larger than > this minimum value. > > Signed-off-by: Jan Beulich Reviewed-by: Stefano Stabellini > --- a/drivers/xen/swiotlb-xen.c > +++ b/drivers/xen/swiotlb-xen.c > @@ -207,7 +207,7 @@ retry: > swiotlb_set_max_segment(PAGE_SIZE); > return 0; > error: > - if (repeat--) { > + if (nslabs > 1024 && repeat--) { > /* Min is 2MB */ > nslabs = max(1024UL, ALIGN(nslabs >> 1, IO_TLB_SEGSIZE)); > bytes = nslabs << IO_TLB_SHIFT; > @@ -243,7 +243,7 @@ retry: > rc = xen_swiotlb_fixup(start, nslabs); > if (rc) { > memblock_free(__pa(start), PAGE_ALIGN(bytes)); > - if (repeat--) { > + if (nslabs > 1024 && repeat--) { > /* Min is 2MB */ > nslabs = max(1024UL, ALIGN(nslabs >> 1, IO_TLB_SEGSIZE)); > bytes = nslabs << IO_TLB_SHIFT; >