From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD0F7C433F5 for ; Fri, 10 Sep 2021 23:26:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A188561211 for ; Fri, 10 Sep 2021 23:26:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234812AbhIJX1w (ORCPT ); Fri, 10 Sep 2021 19:27:52 -0400 Received: from mail.kernel.org ([198.145.29.99]:34734 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233121AbhIJX1q (ORCPT ); Fri, 10 Sep 2021 19:27:46 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 922D4611B0; Fri, 10 Sep 2021 23:26:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1631316394; bh=nWCVWm37Cn4aTHD9fKKBK0iiTuNj5cGbnQ7UNy5fjiA=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=p13Fcm19TN9LmTK4LlFXJYisdlx8j91SHYqgG2d+C217OScazn4CK+Goc+whmNQJa ccx3b/fMa+GAFLShtrkw2wCd2vAY0tVJ+/AqBkqitqoL9L5oLqKutEGWAUNAK+R3Y/ sJqYpnAww5AVQqbFTNJObMcBwqD6gchOiTNTjN98IwZcwwgsltdB9KUR7ykVRaKEAN o9ueydR3zF1hTRSg1zy6p3RmdqXl4lQpCX4HY/6cZ/OXW5AaL4X2m1jBP05g7PMx33 +7J7HWLwwv6rZO1z4o22ZhLOTgTt2k1dFajut6FdFj+OYvmqqJyJqr4D0oscTPpFLh iOJfITNuWNWmw== Date: Fri, 10 Sep 2021 16:26:33 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s To: Jan Beulich cc: Juergen Gross , Boris Ostrovsky , Stefano Stabellini , lkml , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH 08/12] swiotlb-xen: arrange to have buffer info logged In-Reply-To: <2e3c8e68-36b2-4ae9-b829-bf7f75d39d47@suse.com> Message-ID: References: <588b3e6d-2682-160c-468e-44ca4867a570@suse.com> <2e3c8e68-36b2-4ae9-b829-bf7f75d39d47@suse.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 7 Sep 2021, Jan Beulich wrote: > I consider it unhelpful that address and size of the buffer aren't put > in the log file; it makes diagnosing issues needlessly harder. The > majority of callers of swiotlb_init() also passes 1 for the "verbose" > parameter. > > Signed-off-by: Jan Beulich Acked-by: Stefano Stabellini > --- a/drivers/xen/swiotlb-xen.c > +++ b/drivers/xen/swiotlb-xen.c > @@ -253,7 +253,7 @@ retry: > panic("%s (rc:%d)", xen_swiotlb_error(XEN_SWIOTLB_EFIXUP), rc); > } > > - if (swiotlb_init_with_tbl(start, nslabs, false)) > + if (swiotlb_init_with_tbl(start, nslabs, true)) > panic("Cannot allocate SWIOTLB buffer"); > swiotlb_set_max_segment(PAGE_SIZE); > } > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 856BEC433EF for ; Fri, 10 Sep 2021 23:26:47 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4997461211 for ; Fri, 10 Sep 2021 23:26:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 4997461211 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.184863.333650 (Exim 4.92) (envelope-from ) id 1mOpun-00006G-Dz; Fri, 10 Sep 2021 23:26:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 184863.333650; Fri, 10 Sep 2021 23:26:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mOpun-000069-B0; Fri, 10 Sep 2021 23:26:37 +0000 Received: by outflank-mailman (input) for mailman id 184863; Fri, 10 Sep 2021 23:26:36 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mOpum-000063-1w for xen-devel@lists.xenproject.org; Fri, 10 Sep 2021 23:26:36 +0000 Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 89efd266-128e-11ec-b293-12813bfff9fa; Fri, 10 Sep 2021 23:26:35 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 922D4611B0; Fri, 10 Sep 2021 23:26:34 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 89efd266-128e-11ec-b293-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1631316394; bh=nWCVWm37Cn4aTHD9fKKBK0iiTuNj5cGbnQ7UNy5fjiA=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=p13Fcm19TN9LmTK4LlFXJYisdlx8j91SHYqgG2d+C217OScazn4CK+Goc+whmNQJa ccx3b/fMa+GAFLShtrkw2wCd2vAY0tVJ+/AqBkqitqoL9L5oLqKutEGWAUNAK+R3Y/ sJqYpnAww5AVQqbFTNJObMcBwqD6gchOiTNTjN98IwZcwwgsltdB9KUR7ykVRaKEAN o9ueydR3zF1hTRSg1zy6p3RmdqXl4lQpCX4HY/6cZ/OXW5AaL4X2m1jBP05g7PMx33 +7J7HWLwwv6rZO1z4o22ZhLOTgTt2k1dFajut6FdFj+OYvmqqJyJqr4D0oscTPpFLh iOJfITNuWNWmw== Date: Fri, 10 Sep 2021 16:26:33 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s To: Jan Beulich cc: Juergen Gross , Boris Ostrovsky , Stefano Stabellini , lkml , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH 08/12] swiotlb-xen: arrange to have buffer info logged In-Reply-To: <2e3c8e68-36b2-4ae9-b829-bf7f75d39d47@suse.com> Message-ID: References: <588b3e6d-2682-160c-468e-44ca4867a570@suse.com> <2e3c8e68-36b2-4ae9-b829-bf7f75d39d47@suse.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Tue, 7 Sep 2021, Jan Beulich wrote: > I consider it unhelpful that address and size of the buffer aren't put > in the log file; it makes diagnosing issues needlessly harder. The > majority of callers of swiotlb_init() also passes 1 for the "verbose" > parameter. > > Signed-off-by: Jan Beulich Acked-by: Stefano Stabellini > --- a/drivers/xen/swiotlb-xen.c > +++ b/drivers/xen/swiotlb-xen.c > @@ -253,7 +253,7 @@ retry: > panic("%s (rc:%d)", xen_swiotlb_error(XEN_SWIOTLB_EFIXUP), rc); > } > > - if (swiotlb_init_with_tbl(start, nslabs, false)) > + if (swiotlb_init_with_tbl(start, nslabs, true)) > panic("Cannot allocate SWIOTLB buffer"); > swiotlb_set_max_segment(PAGE_SIZE); > } >