From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 750ABC433EF for ; Wed, 22 Sep 2021 22:08:17 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 340A56109E for ; Wed, 22 Sep 2021 22:08:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 340A56109E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.193122.343979 (Exim 4.92) (envelope-from ) id 1mTAPR-0004mn-1S; Wed, 22 Sep 2021 22:08:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 193122.343979; Wed, 22 Sep 2021 22:08:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mTAPQ-0004mg-Ug; Wed, 22 Sep 2021 22:08:08 +0000 Received: by outflank-mailman (input) for mailman id 193122; Wed, 22 Sep 2021 22:08:08 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mTAPP-0004ma-U1 for xen-devel@lists.xenproject.org; Wed, 22 Sep 2021 22:08:07 +0000 Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id b5175511-9645-42b9-9210-8d4af4ef1ef8; Wed, 22 Sep 2021 22:08:07 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 600E66109E; Wed, 22 Sep 2021 22:08:06 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b5175511-9645-42b9-9210-8d4af4ef1ef8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1632348486; bh=QWQVk8O80Iz9b+CDsZQa+wGLp70ISYSJPLI5YvAbbm8=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=s2rmUXcGajM2QzSwiYuQCMQd6mEtF9Arm17dwzqrew1eNTLKK73MJFWfih/Ckyy5e 0MsXsBIJXAMOOyVG5WN439fRp74AUW1lyzHmJg824kyekMEGB0JUWvnGtTaSB/gTq/ xzmSM4iSoE86y4iUQ31dQ3aZkn/bJwGtKddAfjZ7nTa0MXoy3+wOqnX919syQTk3zP 1s0dCERX74IIWJH66A1LBdDexOGzGVJ6Gws4pus2qJE2ECIbyFXDlPuwaoL2SATtKn n4mocKAHCoSDyfZmj6MqWHN08FYDNuQ/sp/NZy5ehCMnP5AOFDjfM+4w8bGuse+7Xw f3m/9nh58z/2w== Date: Wed, 22 Sep 2021 15:08:05 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s To: Rahul Singh cc: xen-devel@lists.xenproject.org, bertrand.marquis@arm.com, andre.przywara@arm.com, Jan Beulich , Paul Durrant Subject: Re: [PATCH v2 03/17] xen/arm: solve compilation error on ARM with ACPI && HAS_PCI In-Reply-To: Message-ID: References: User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="8323329-1011149910-1632348486=:17979" This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-1011149910-1632348486=:17979 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT On Wed, 22 Sep 2021, Rahul Singh wrote: > prelink.o: In function `pcie_aer_get_firmware_first’: > drivers/passthrough/pci.c:1251: undefined reference to `apei_hest_parse' > > Compilation error is observed when ACPI and HAS_PCI is enabled for ARM > architecture. APEI not supported on ARM yet move the code under > CONFIG_X86 flag to gate the code for ARM. > > Signed-off-by: Rahul Singh Acked-by: Stefano Stabellini > --- > Change in v2: Add in code comment "APEI not supported on ARM yet" > --- > xen/drivers/passthrough/pci.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/xen/drivers/passthrough/pci.c b/xen/drivers/passthrough/pci.c > index 8996403161..d774a6154e 100644 > --- a/xen/drivers/passthrough/pci.c > +++ b/xen/drivers/passthrough/pci.c > @@ -1150,7 +1150,8 @@ void __hwdom_init setup_hwdom_pci_devices( > pcidevs_unlock(); > } > > -#ifdef CONFIG_ACPI > +/* APEI not supported on ARM yet. */ > +#if defined(CONFIG_ACPI) && defined(CONFIG_X86) > #include > #include > > -- > 2.17.1 > > --8323329-1011149910-1632348486=:17979--