On Fri, 24 Sep 2021, Wei Chen wrote: > > -----Original Message----- > > From: Stefano Stabellini > > Sent: 2021年9月24日 11:17 > > To: Wei Chen > > Cc: xen-devel@lists.xenproject.org; sstabellini@kernel.org; julien@xen.org; > > Bertrand Marquis > > Subject: Re: [PATCH 32/37] xen/arm: unified entry to parse all NUMA data > > from device tree > > > > On Thu, 23 Sep 2021, Wei Chen wrote: > > > In this API, we scan whole device tree to parse CPU node id, memory > > ^ function ^ the whole > > > > > node id and distance-map. Though early_scan_node will invoke has a > > > handler to process memory nodes. If we want to parse memory node id > > > in this handler, we have to embeded NUMA parse code in this handler. > > ^ embed > > > > > But we still need to scan whole device tree to find CPU NUMA id and > > > distance-map. In this case, we include memory NUMA id parse in this > > > API too. Another benefit is that we have a unique entry for device > > ^ function > > > > > tree NUMA data parse. > > > > Ah, that's the explanation I was asking for earlier! > > > > The question about device_tree_get_meminfo? Yes, it would be nice to reuse process_memory_node if we can, but I understand if we cannot.