From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ACE6AC433EF for ; Tue, 5 Oct 2021 00:57:54 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 68D3F6108F for ; Tue, 5 Oct 2021 00:57:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 68D3F6108F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.201853.356489 (Exim 4.92) (envelope-from ) id 1mXYmB-0001Pc-CS; Tue, 05 Oct 2021 00:57:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 201853.356489; Tue, 05 Oct 2021 00:57:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mXYmB-0001PT-92; Tue, 05 Oct 2021 00:57:47 +0000 Received: by outflank-mailman (input) for mailman id 201853; Tue, 05 Oct 2021 00:57:46 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mXYmA-0001Oo-1E for xen-devel@lists.xenproject.org; Tue, 05 Oct 2021 00:57:46 +0000 Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 40245a20-2577-11ec-bec4-12813bfff9fa; Tue, 05 Oct 2021 00:57:45 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 363696140B; Tue, 5 Oct 2021 00:57:44 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 40245a20-2577-11ec-bec4-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1633395464; bh=PrNXBNszwWDc2/Ya6RS7TEevhzR3nEWnHU7H6WQvUCw=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=OIcrMmmaeaVRe9KJKh7U5UmnsA057Fp2598gFKi60HhSLfLwWl1uvaTHULAWNOyka /VK0HKN5fI39AebI4mRUy5gqgrJC+qeQ4eFFvLK0z58eEvJYy/Ppcr5v/qtplbo61x kYJlGlwhfjQJc3SQK1UsfgXCpq6/DTnpxO0qH5lHJqQGAoh6oFelpGNJ0USq/OQzuN n8mUfQDMILPl85CEN7/1yp61huutFadn+xlNDwJz96WKN6ib8ts2EaWJSTaUmpw+JU tr/ej5sUQdV6z3a8Z9dfZSJ9vZUHRePa40Qqy4FzBA0sb0+UiH8TNHWR/Opd98a33b p36wY4W8jDmPg== Date: Mon, 4 Oct 2021 17:57:43 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s To: Oleksandr Andrushchenko cc: xen-devel@lists.xenproject.org, julien@xen.org, sstabellini@kernel.org, oleksandr_tyshchenko@epam.com, volodymyr_babchuk@epam.com, Artem_Mygaiev@epam.com, roger.pau@citrix.com, jbeulich@suse.com, andrew.cooper3@citrix.com, george.dunlap@citrix.com, paul@xen.org, bertrand.marquis@arm.com, rahul.singh@arm.com, Oleksandr Andrushchenko , Michal Orzel Subject: Re: [PATCH v4 01/11] xen/arm: Fix dev_is_dt macro definition In-Reply-To: <20211004141151.132231-2-andr2000@gmail.com> Message-ID: References: <20211004141151.132231-1-andr2000@gmail.com> <20211004141151.132231-2-andr2000@gmail.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Mon, 4 Oct 2021, Oleksandr Andrushchenko wrote: > From: Oleksandr Andrushchenko > > This macro is not currently used, but still has an error in it: > a missing parenthesis. Fix this, so the macro is properly defined. > > Fixes: 6c5d3075d97e ("xen/arm: Introduce a generic way to describe device") > > Signed-off-by: Oleksandr Andrushchenko > Reviewed-by: Stefano Stabellini > Reviewed-by: Michal Orzel I committed this patch > --- > New in v2 > --- > xen/include/asm-arm/device.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/xen/include/asm-arm/device.h b/xen/include/asm-arm/device.h > index 5ecd5e7bd15e..ebe84ea853cd 100644 > --- a/xen/include/asm-arm/device.h > +++ b/xen/include/asm-arm/device.h > @@ -27,7 +27,7 @@ typedef struct device device_t; > > /* TODO: Correctly implement dev_is_pci when PCI is supported on ARM */ > #define dev_is_pci(dev) ((void)(dev), 0) > -#define dev_is_dt(dev) ((dev->type == DEV_DT) > +#define dev_is_dt(dev) ((dev)->type == DEV_DT) > > enum device_class > { > -- > 2.25.1 >