From: "Maciej W. Rozycki" <macro@orcam.me.uk>
To: Oleksij Rempel <o.rempel@pengutronix.de>
Cc: Marc Kleine-Budde <mkl@pengutronix.de>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
Rob Herring <robh@kernel.org>,
Paul Burton <paulburton@kernel.org>,
linux-kernel@vger.kernel.org, Ralf Baechle <ralf@linux-mips.org>,
linux-mips@vger.kernel.org,
Pengutronix Kernel Team <kernel@pengutronix.de>
Subject: Re: [PATCH v1] MIPS: Malta: fix alignment of the devicetree buffer
Date: Mon, 11 Oct 2021 10:09:08 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.21.2110111004510.12214@angie.orcam.me.uk> (raw)
In-Reply-To: <20211011071553.GA24717@pengutronix.de>
On Mon, 11 Oct 2021, Oleksij Rempel wrote:
> > It's not clear either from this patch description or from the commit
> > referred what the actual *purpose* of the alignment check is and therefore
> > I think it's hard to say which of the two commits needs to be indicated as
> > the offender. Without further data I tend to agree it's 79edff12060f that
> > ought to be referred, being the immediate cause of the regression, as
> > things obviously worked before, for 5+ years.
>
> This patch was already taken. Do I need to do any thing?
No, unless Thomas chimes in, especially since you've posted v2 already (I
hope he's sorted the stable part). Overall we need better change
descriptions though.
Maciej
prev parent reply other threads:[~2021-10-11 8:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-02 7:19 [PATCH v1] MIPS: Malta: fix alignment of the devicetree buffer Oleksij Rempel
2021-09-02 9:03 ` Thomas Bogendoerfer
2021-09-02 10:14 ` Marc Kleine-Budde
2021-10-10 9:58 ` Maciej W. Rozycki
2021-10-11 7:15 ` Oleksij Rempel
2021-10-11 8:09 ` Maciej W. Rozycki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.2110111004510.12214@angie.orcam.me.uk \
--to=macro@orcam.me.uk \
--cc=kernel@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=o.rempel@pengutronix.de \
--cc=paulburton@kernel.org \
--cc=ralf@linux-mips.org \
--cc=robh@kernel.org \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.