From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E86EC433F5 for ; Mon, 10 Jan 2022 12:00:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245132AbiAJMA0 (ORCPT ); Mon, 10 Jan 2022 07:00:26 -0500 Received: from angie.orcam.me.uk ([78.133.224.34]:38782 "EHLO angie.orcam.me.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245221AbiAJMAI (ORCPT ); Mon, 10 Jan 2022 07:00:08 -0500 Received: by angie.orcam.me.uk (Postfix, from userid 500) id CACA692009C; Mon, 10 Jan 2022 13:00:03 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by angie.orcam.me.uk (Postfix) with ESMTP id C4C2292009B; Mon, 10 Jan 2022 12:00:03 +0000 (GMT) Date: Mon, 10 Jan 2022 12:00:03 +0000 (GMT) From: "Maciej W. Rozycki" To: "Martin K. Petersen" cc: Douglas Gilbert , Khalid Aziz , "James E.J. Bottomley" , Christoph Hellwig , Nix , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 3/3] scsi: Set allocation length to 255 for ATA Information VPD page In-Reply-To: Message-ID: References: User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Martin, > > however partitions (of the MS-DOS type) are not recognised with any of > > the disks including one holding the root device, so the system fails > > to mount the root filesystem and therefore does not complete booting: > > My mistake. An unrelated change to the revalidate logic in the last > patch. Fixed and pushed. No worries, I'm glad I helped catch it early. This version boots multi-user. > For your Mylex issue I believe the first patch in the series is all > that's needed: > > 06a471da0937 ("scsi: core: Query VPD size before getting full page") It is. Thanks for sorting out this issue! Maciej