From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E2BF0C433EF for ; Wed, 12 Jan 2022 22:44:00 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 7A7ED83180; Wed, 12 Jan 2022 23:43:58 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=orcam.me.uk Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id A7FD2832DA; Wed, 12 Jan 2022 23:43:56 +0100 (CET) Received: from angie.orcam.me.uk (angie.orcam.me.uk [78.133.224.34]) by phobos.denx.de (Postfix) with ESMTP id B192183180 for ; Wed, 12 Jan 2022 23:43:53 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=orcam.me.uk Authentication-Results: phobos.denx.de; spf=none smtp.mailfrom=macro@orcam.me.uk Received: by angie.orcam.me.uk (Postfix, from userid 500) id 33CBF92009C; Wed, 12 Jan 2022 23:43:53 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by angie.orcam.me.uk (Postfix) with ESMTP id 2545092009B; Wed, 12 Jan 2022 22:43:53 +0000 (GMT) Date: Wed, 12 Jan 2022 22:43:53 +0000 (GMT) From: "Maciej W. Rozycki" To: Tom Rini cc: u-boot@lists.denx.de, Stefan Roese , Simon Glass , =?UTF-8?Q?Pali_Roh=C3=A1r?= , Phil Sutter , Vladimir Oltean , Bin Meng , Tim Harvey , Jim Wilson , David Abdurachmanov Subject: Re: [PATCH v3] pci: Work around PCIe link training failures In-Reply-To: <20220112191911.GB9207@bill-the-cat> Message-ID: References: <20220112191911.GB9207@bill-the-cat> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Wed, 12 Jan 2022, Tom Rini wrote: > > I believe this version has addressed all concerns raised in the review > > thus far. With the nature of a problem better understood now I'm sending > > a corresponding update for Linux as well. > > What as the feedback to your Linux change? Is this essentially the path > forward still? Thanks! There has been no response so far, perhaps due to unfavourable timing, the festive season, etc. I have rebased my original change and posted a regenerated version a bit more than a week ago: and a few of my other resubmissions in the PCI area have been partially reviewed last week. So things have been progressing, but with Linux 5.16 released last Sun we're in the merge window for 5.17 now, so people are surely busy with that. We shall see. NB as I previously noted the Linux change has to be different, because you cannot busy-loop polling a bit in a device register in an OS, unlike in firmware, and therefore the Linux version has to rely on the data link layer active reporting capability, which may not be there in PCIe 2.0 devices. Conceptually the two changes remain similar though, so I guess input from the Linux side will still be valuable. Thank you for your attention to my proposal. Maciej