From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B2ABC433F5 for ; Thu, 31 Mar 2022 07:13:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232101AbiCaHPc (ORCPT ); Thu, 31 Mar 2022 03:15:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43162 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232007AbiCaHOl (ORCPT ); Thu, 31 Mar 2022 03:14:41 -0400 Received: from angie.orcam.me.uk (angie.orcam.me.uk [78.133.224.34]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 3741991AD4 for ; Thu, 31 Mar 2022 00:11:56 -0700 (PDT) Received: by angie.orcam.me.uk (Postfix, from userid 500) id 78A299200B3; Thu, 31 Mar 2022 09:11:55 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by angie.orcam.me.uk (Postfix) with ESMTP id 7570E92009E; Thu, 31 Mar 2022 08:11:55 +0100 (BST) Date: Thu, 31 Mar 2022 08:11:55 +0100 (BST) From: "Maciej W. Rozycki" To: Linus Torvalds cc: Thomas Gleixner , Dmitry Osipenko , Linux Kernel Mailing List , the arch/x86 maintainers Subject: Re: [GIT pull] x86/irq for v5.18-rc1 In-Reply-To: Message-ID: References: <164786042536.122591.4459156564791679956.tglx@xen13> <164786043041.122591.4693682080153649212.tglx@xen13> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 21 Mar 2022, Linus Torvalds wrote: > > - Handle the IRT routing table format in AMI BIOSes correctly > > *Very* minor nit here in the hope of future cleanups: the other x86 > irq routing table structions (Christ, that's a sentence that shouldn't > exist in a sane world) use "__attribute__((packed))" and this one uses > "__packed". I have reviewed and reverified the code for resubmission now and frankly I don't know where this "__packed" artefact has come from. I certainly have "__attribute__((packed))" in all my copies of the change including one I have submitted (though `checkpatch.pl' does want it indeed to be `__packed' instead). Also accessing memory beyond __va(0x100000) does not appear to crash on my 32-bit x86 machine, so it must be something specific to x86-64. Not an excuse for a range overrun of course, but still odd (and as I previously mentioned I find it odd too that this code is ever run for x86-64 in the first place). Finally, following your suggestion I have added verification for a range overrun for the whole table for both the existing $PIR format and the new $IRT format. It isn't a big deal and we shouldn't trust external sources of data. Maciej