From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0ADAC54EE9 for ; Tue, 20 Sep 2022 23:42:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231444AbiITXmo (ORCPT ); Tue, 20 Sep 2022 19:42:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39494 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231468AbiITXmW (ORCPT ); Tue, 20 Sep 2022 19:42:22 -0400 Received: from angie.orcam.me.uk (angie.orcam.me.uk [IPv6:2001:4190:8020::34]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 1D8364DB21; Tue, 20 Sep 2022 16:40:48 -0700 (PDT) Received: by angie.orcam.me.uk (Postfix, from userid 500) id 3B2399200B4; Wed, 21 Sep 2022 01:35:47 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by angie.orcam.me.uk (Postfix) with ESMTP id 3517392009B; Wed, 21 Sep 2022 00:35:47 +0100 (BST) Date: Wed, 21 Sep 2022 00:35:47 +0100 (BST) From: "Maciej W. Rozycki" To: Jiri Slaby cc: Greg Kroah-Hartman , Josh Triplett , Anders Blomdell , linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH 1/2] serial: 8250: Let drivers request full 16550A feature probing In-Reply-To: Message-ID: References: <8fa701a1-3f34-9152-daf6-1618dd0e7727@kernel.org> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 19 Sep 2022, Jiri Slaby wrote: > > > Why __u64 and not u64? > > > > For consistency as there's `__u32' used elsewhere in this file. It's not > > clear to me what our rules WRT the use of `s*'/`u*' vs `__s*'/`__u*' are. > > I don't think we have it mentioned under Documentation/. Please clarify > > if you know and I can update the change accordingly. > > The rule is, AFAICT, use __u*/__s* in user (uapi) headers. Everywhere else, > use u*/s*. Fair enough, that's consistent with ISO C's designation of identifiers whose names start with an underscore as reserved (for system use, etc.). Maciej