From: Paul Walmsley <paul.walmsley@sifive.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] clk: sifive: fu540-prci: align primary DT match string to the DT bindings
Date: Fri, 31 May 2019 02:55:34 -0700 (PDT) [thread overview]
Message-ID: <alpine.DEB.2.21.9999.1905310250200.31862@viisi.sifive.com> (raw)
In-Reply-To: <CAEUhbmV68UuHU+Ksj1KW1ucxj3mhgZEQQt2ANkDW=AgC0TNGEA@mail.gmail.com>
On Thu, 30 May 2019, Bin Meng wrote:
> On Sun, May 26, 2019 at 5:13 PM Paul Walmsley <paul.walmsley@sifive.com> wrote:
>
> > diff --git a/drivers/clk/sifive/fu540-prci.c b/drivers/clk/sifive/fu540-prci.c
> > index 2d47ebc6b1..d79d1a5351 100644
> > --- a/drivers/clk/sifive/fu540-prci.c
> > +++ b/drivers/clk/sifive/fu540-prci.c
> > @@ -589,7 +589,7 @@ static struct clk_ops sifive_fu540_prci_ops = {
> > };
> >
> > static const struct udevice_id sifive_fu540_prci_ids[] = {
> > - { .compatible = "sifive,fu540-c000-prci0" },
> > + { .compatible = "sifive,fu540-c000-prci" },
>
> Can we keep the previous compatible string for compatibility reason?
> U-Boot is now reusing the DT that FSBL passes.
Are there any FSBLs that pass "sifive,fu540-c000-prci0" ? I am not aware
of any.
SiFive FSBLs have only ever used "sifive,aloeprci0" (or
"sifive,ux00prci0") and those will soon be deprecated.
It would be good if the U-Boot maintainers would reject any DT compatible
strings that haven't been committed upstream into the Linux kernel DT
binding repository. Otherwise I foresee this kind of mess increasing if
others decide to invent their own compatible strings.
- Paul
next prev parent reply other threads:[~2019-05-31 9:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-26 9:13 [U-Boot] [PATCH] clk: sifive: fu540-prci: align primary DT match string to the DT bindings Paul Walmsley
2019-05-29 22:29 ` Atish Patra
2019-05-30 1:18 ` Bin Meng
2019-05-30 5:06 ` Atish Patra
2019-05-30 5:48 ` Bin Meng
2019-05-30 18:30 ` Atish Patra
2019-05-31 9:55 ` Paul Walmsley [this message]
2019-06-07 5:45 ` Paul Walmsley
2019-06-07 8:35 ` Bin Meng
2019-07-19 15:28 ` Paul Walmsley
2019-07-23 6:44 ` Rick Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.9999.1905310250200.31862@viisi.sifive.com \
--to=paul.walmsley@sifive.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.