From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B33BC433DF for ; Thu, 13 Aug 2020 16:47:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 64BE02078D for ; Thu, 13 Aug 2020 16:47:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726518AbgHMQrb (ORCPT ); Thu, 13 Aug 2020 12:47:31 -0400 Received: from gentwo.org ([3.19.106.255]:35912 "EHLO gentwo.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726131AbgHMQra (ORCPT ); Thu, 13 Aug 2020 12:47:30 -0400 Received: by gentwo.org (Postfix, from userid 1002) id 6979B3F1CD; Thu, 13 Aug 2020 16:47:30 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by gentwo.org (Postfix) with ESMTP id 675B53F1CC; Thu, 13 Aug 2020 16:47:30 +0000 (UTC) Date: Thu, 13 Aug 2020 16:47:30 +0000 (UTC) From: Christopher Lameter X-X-Sender: cl@www.lameter.com To: Abel Wu cc: Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , hewenliang4@huawei.com, hushiyuan@huawei.com, "open list:SLAB ALLOCATOR" , open list Subject: Re: [PATCH] mm/slub: branch optimization in free slowpath In-Reply-To: <20200813101812.1617-1-wuyun.wu@huawei.com> Message-ID: References: <20200813101812.1617-1-wuyun.wu@huawei.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 13 Aug 2020, wuyun.wu@huawei.com wrote: > The two conditions are mutually exclusive and gcc compiler will > optimise this into if-else-like pattern. Given that the majority > of free_slowpath is free_frozen, let's provide some hint to the > compilers. Acked-by: Christoph Lameter From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D873DC433E1 for ; Thu, 13 Aug 2020 16:47:32 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 702112087C for ; Thu, 13 Aug 2020 16:47:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 702112087C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id EA7406B0028; Thu, 13 Aug 2020 12:47:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E59116B002A; Thu, 13 Aug 2020 12:47:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D94FB6B002F; Thu, 13 Aug 2020 12:47:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0230.hostedemail.com [216.40.44.230]) by kanga.kvack.org (Postfix) with ESMTP id C31D26B0028 for ; Thu, 13 Aug 2020 12:47:31 -0400 (EDT) Received: from smtpin22.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 7CD55824556B for ; Thu, 13 Aug 2020 16:47:31 +0000 (UTC) X-FDA: 77146126302.22.plate36_331312d26ff5 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin22.hostedemail.com (Postfix) with ESMTP id 4AEBD18038E67 for ; Thu, 13 Aug 2020 16:47:31 +0000 (UTC) X-HE-Tag: plate36_331312d26ff5 X-Filterd-Recvd-Size: 1571 Received: from gentwo.org (gentwo.org [3.19.106.255]) by imf10.hostedemail.com (Postfix) with ESMTP for ; Thu, 13 Aug 2020 16:47:30 +0000 (UTC) Received: by gentwo.org (Postfix, from userid 1002) id 6979B3F1CD; Thu, 13 Aug 2020 16:47:30 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by gentwo.org (Postfix) with ESMTP id 675B53F1CC; Thu, 13 Aug 2020 16:47:30 +0000 (UTC) Date: Thu, 13 Aug 2020 16:47:30 +0000 (UTC) From: Christopher Lameter X-X-Sender: cl@www.lameter.com To: Abel Wu cc: Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , hewenliang4@huawei.com, hushiyuan@huawei.com, "open list:SLAB ALLOCATOR" , open list Subject: Re: [PATCH] mm/slub: branch optimization in free slowpath In-Reply-To: <20200813101812.1617-1-wuyun.wu@huawei.com> Message-ID: References: <20200813101812.1617-1-wuyun.wu@huawei.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Rspamd-Queue-Id: 4AEBD18038E67 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam04 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 13 Aug 2020, wuyun.wu@huawei.com wrote: > The two conditions are mutually exclusive and gcc compiler will > optimise this into if-else-like pattern. Given that the majority > of free_slowpath is free_frozen, let's provide some hint to the > compilers. Acked-by: Christoph Lameter