From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7CFBC43461 for ; Thu, 3 Sep 2020 14:56:30 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 53DFD20658 for ; Thu, 3 Sep 2020 14:56:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 53DFD20658 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C6FE76EA04; Thu, 3 Sep 2020 14:56:29 +0000 (UTC) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by gabe.freedesktop.org (Postfix) with ESMTPS id AD97E6EA04 for ; Thu, 3 Sep 2020 14:56:27 +0000 (UTC) IronPort-SDR: 88BpvAGchwYaW+i8vzBnD9MX+VLpKspzPdq676GMtvvS45YZXuZZIecLsvByl+/jwc3pDyZzhO WCNrQ0neKydw== X-IronPort-AV: E=McAfee;i="6000,8403,9733"; a="137636631" X-IronPort-AV: E=Sophos;i="5.76,387,1592895600"; d="scan'208";a="137636631" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Sep 2020 07:56:27 -0700 IronPort-SDR: GA773SBC+Lx8yPCK4WrQ16nxmOqsRWo6K5e7jSSRFZlEQyuqX0cXQ/sEcXVlPWYcO96AM1b8Hi kvhn7RPl+KWQ== X-IronPort-AV: E=Sophos;i="5.76,387,1592895600"; d="scan'208";a="446931996" Received: from eliteleevi.tm.intel.com ([10.237.54.20]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Sep 2020 07:56:25 -0700 Date: Thu, 3 Sep 2020 17:55:09 +0300 (EEST) From: Kai Vehmanen X-X-Sender: kvehmane@eliteleevi.tm.intel.com To: =?ISO-8859-15?Q?Ville_Syrj=E4l=E4?= In-Reply-To: <20200903134755.GV6112@intel.com> Message-ID: References: <20200901151036.1312357-1-kai.vehmanen@linux.intel.com> <20200903134755.GV6112@intel.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7 02160 Espoo MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="-318106570-1108801853-1599144912=:3186" Subject: Re: [Intel-gfx] [PATCH] drm/i915: fix regression leading to display audio probe failure on GLK X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. ---318106570-1108801853-1599144912=:3186 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8BIT Hey, On Thu, 3 Sep 2020, Ville Syrjälä wrote: > On Tue, Sep 01, 2020 at 06:10:36PM +0300, Kai Vehmanen wrote: >> In commit 4f0b4352bd26 ("drm/i915: Extract cdclk requirements checking >> to separate function") the order of force_min_cdclk_changed check and >> intel_modeset_checks(), was reversed. This broke the mechanism to > > Amended the commit msg with a bit more details: > "[vsyrjala: It also broke the ability of planes to bump up the cdclk > and thus could lead to underruns when eg. flipping from 32bpp to > 64bpp framebuffer. To be clear, we still compute the new cdclk ack on that, thanks! > The "Fixes" line was also a bit wrong: )" vs ") at the end. Took > me a while to figure out what dim was complaining about :) > > Pushed to dinq. Thanks! Uh, sorry about that. I actually fixed that in some (?) version due to checkpatch warnings, but apparently it slipped though. Sorry about that, took me a while to figure it out, as well :) Br, Kai ---318106570-1108801853-1599144912=:3186 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ---318106570-1108801853-1599144912=:3186--