From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07124C433E2 for ; Sat, 12 Sep 2020 14:46:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C78E320855 for ; Sat, 12 Sep 2020 14:46:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725924AbgILOqN (ORCPT ); Sat, 12 Sep 2020 10:46:13 -0400 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:57675 "EHLO mail3-relais-sop.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725925AbgILOnU (ORCPT ); Sat, 12 Sep 2020 10:43:20 -0400 X-IronPort-AV: E=Sophos;i="5.76,359,1592863200"; d="scan'208";a="358800815" Received: from abo-173-121-68.mrs.modulonet.fr (HELO hadrien) ([85.68.121.173]) by mail3-relais-sop.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Sep 2020 16:43:13 +0200 Date: Sat, 12 Sep 2020 16:43:13 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: Denis Efremov cc: cocci@systeme.lip6.fr, linux-kernel@vger.kernel.org, Kees Cook , "Gustavo A . R . Silva" Subject: Re: [PATCH v2] coccinelle: misc: add flexible_array.cocci script In-Reply-To: <20200809212655.58457-1-efremov@linux.com> Message-ID: References: <20200806220342.25426-1-efremov@linux.com> <20200809212655.58457-1-efremov@linux.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 10 Aug 2020, Denis Efremov wrote: > Commit 68e4cd17e218 ("docs: deprecated.rst: Add zero-length and one-element > arrays") marks one-element and zero-length arrays as deprecated. Kernel > code should always use "flexible array members" instead. > > The script warns about one-element and zero-length arrays in structs. > > Cc: Kees Cook > Cc: Gustavo A. R. Silva > Signed-off-by: Denis Efremov > --- > Changes in v2: > - all uapi headers are now filtered-out. Unfortunately, coccinelle > doesn't provide structure names in Location.current_element. > For structures the field is always "something_else". Thus, there is > no easy way to create a list of existing structures in uapi headers > and suppress the warning only for them, but not for the newly added > uapi structures. > - The pattern doesn't require 2+ fields in a structure/union anymore. > Now it also checks single field structures/unions. > - The pattern simplified and now uses disjuction in array elements > (Thanks, Markus) > - Unions are removed from patch mode > - one-element arrays are removed from patch mode. Correct patch may > involve turning the array to a simple field instead of a flexible > array. > > On the current master branch, the rule generates: > - context: https://gist.github.com/evdenis/e2b4323491f9eff35376372df07f723c > - patch: https://gist.github.com/evdenis/46081da9d68ecefd07edc3769cebcf32 > > scripts/coccinelle/misc/flexible_array.cocci | 88 ++++++++++++++++++++ > 1 file changed, 88 insertions(+) > create mode 100644 scripts/coccinelle/misc/flexible_array.cocci > > diff --git a/scripts/coccinelle/misc/flexible_array.cocci b/scripts/coccinelle/misc/flexible_array.cocci > new file mode 100644 > index 000000000000..bf6dcda1783e > --- /dev/null > +++ b/scripts/coccinelle/misc/flexible_array.cocci > @@ -0,0 +1,88 @@ > +// SPDX-License-Identifier: GPL-2.0-only > +/// > +/// Zero-length and one-element arrays are deprecated, see > +/// Documentation/process/deprecated.rst > +/// Flexible-array members should be used instead. > +/// > +// > +// Confidence: High > +// Copyright: (C) 2020 Denis Efremov ISPRAS. > +// Comments: > +// Options: --no-includes --include-headers > + > +virtual context > +virtual report > +virtual org > +virtual patch > + > +@initialize:python@ > +@@ > +def relevant(positions): > + for p in positions: > + if "uapi" in p.file: > + return False > + return True > + > +@r depends on !patch@ > +identifier name, array; > +type T; > +position p : script:python() { relevant(p) }; > +@@ > + > +( > + struct name { > + ... > +* T array@p[\(0\|1\)]; > + }; > +| > + struct { > + ... > +* T array@p[\(0\|1\)]; > + }; > +| > + union name { > + ... > +* T array@p[\(0\|1\)]; > + }; > +| > + union { > + ... > +* T array@p[\(0\|1\)]; > + }; > +) > + > +@depends on patch exists@ exists is not necessary here. There are not multiple control-flow paths through a structure declaration. > +identifier name, array; > +type T; > +position p : script:python() { relevant(p) }; > +@@ > + > +( > + struct name { > + ... > + T array@p[ > +- 0 > + ]; > + }; > +| > + struct { > + ... > + T array@p[ > +- 0 > + ]; > + }; > +) > + > +@script: python depends on report@ > +p << r.p; > +@@ > + > +msg = "WARNING: use flexible-array member instead" > +coccilib.report.print_report(p[0], msg) > + > +@script: python depends on org@ > +p << r.p; > +@@ > + > +msg = "WARNING: use flexible-array member instead" > +coccilib.org.print_todo(p, msg) This should be coccilib.org.print_todo(p[0], msg) julia From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE0B9C43461 for ; Sat, 12 Sep 2020 14:43:41 +0000 (UTC) Received: from isis.lip6.fr (isis.lip6.fr [132.227.60.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 000AE20855 for ; Sat, 12 Sep 2020 14:43:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 000AE20855 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=inria.fr Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=cocci-bounces@systeme.lip6.fr Received: from systeme.lip6.fr (systeme.lip6.fr [132.227.104.7]) by isis.lip6.fr (8.15.2/8.15.2) with ESMTP id 08CEhHcR019932; Sat, 12 Sep 2020 16:43:17 +0200 (CEST) Received: from systeme.lip6.fr (systeme.lip6.fr [127.0.0.1]) by systeme.lip6.fr (Postfix) with ESMTP id 18DCB7595; Sat, 12 Sep 2020 16:43:17 +0200 (CEST) Received: from isis.lip6.fr (isis.lip6.fr [132.227.60.2]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by systeme.lip6.fr (Postfix) with ESMTPS id 1A8474316 for ; Sat, 12 Sep 2020 16:43:15 +0200 (CEST) Received: from mail3-relais-sop.national.inria.fr (mail3-relais-sop.national.inria.fr [192.134.164.104]) by isis.lip6.fr (8.15.2/8.15.2) with ESMTP id 08CEhEqF019812 for ; Sat, 12 Sep 2020 16:43:14 +0200 (CEST) X-IronPort-AV: E=Sophos;i="5.76,359,1592863200"; d="scan'208";a="358800815" Received: from abo-173-121-68.mrs.modulonet.fr (HELO hadrien) ([85.68.121.173]) by mail3-relais-sop.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Sep 2020 16:43:13 +0200 Date: Sat, 12 Sep 2020 16:43:13 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: Denis Efremov In-Reply-To: <20200809212655.58457-1-efremov@linux.com> Message-ID: References: <20200806220342.25426-1-efremov@linux.com> <20200809212655.58457-1-efremov@linux.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 X-Greylist: Sender IP whitelisted, Sender e-mail whitelisted, not delayed by milter-greylist-4.4.3 (isis.lip6.fr [132.227.60.2]); Sat, 12 Sep 2020 16:43:17 +0200 (CEST) X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.4.3 (isis.lip6.fr [132.227.60.2]); Sat, 12 Sep 2020 16:43:14 +0200 (CEST) X-Scanned-By: MIMEDefang 2.78 on 132.227.60.2 X-Scanned-By: MIMEDefang 2.78 on 132.227.60.2 Cc: "Gustavo A . R . Silva" , cocci@systeme.lip6.fr, Kees Cook , linux-kernel@vger.kernel.org Subject: Re: [Cocci] [PATCH v2] coccinelle: misc: add flexible_array.cocci script X-BeenThere: cocci@systeme.lip6.fr X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: cocci-bounces@systeme.lip6.fr Errors-To: cocci-bounces@systeme.lip6.fr On Mon, 10 Aug 2020, Denis Efremov wrote: > Commit 68e4cd17e218 ("docs: deprecated.rst: Add zero-length and one-element > arrays") marks one-element and zero-length arrays as deprecated. Kernel > code should always use "flexible array members" instead. > > The script warns about one-element and zero-length arrays in structs. > > Cc: Kees Cook > Cc: Gustavo A. R. Silva > Signed-off-by: Denis Efremov > --- > Changes in v2: > - all uapi headers are now filtered-out. Unfortunately, coccinelle > doesn't provide structure names in Location.current_element. > For structures the field is always "something_else". Thus, there is > no easy way to create a list of existing structures in uapi headers > and suppress the warning only for them, but not for the newly added > uapi structures. > - The pattern doesn't require 2+ fields in a structure/union anymore. > Now it also checks single field structures/unions. > - The pattern simplified and now uses disjuction in array elements > (Thanks, Markus) > - Unions are removed from patch mode > - one-element arrays are removed from patch mode. Correct patch may > involve turning the array to a simple field instead of a flexible > array. > > On the current master branch, the rule generates: > - context: https://gist.github.com/evdenis/e2b4323491f9eff35376372df07f723c > - patch: https://gist.github.com/evdenis/46081da9d68ecefd07edc3769cebcf32 > > scripts/coccinelle/misc/flexible_array.cocci | 88 ++++++++++++++++++++ > 1 file changed, 88 insertions(+) > create mode 100644 scripts/coccinelle/misc/flexible_array.cocci > > diff --git a/scripts/coccinelle/misc/flexible_array.cocci b/scripts/coccinelle/misc/flexible_array.cocci > new file mode 100644 > index 000000000000..bf6dcda1783e > --- /dev/null > +++ b/scripts/coccinelle/misc/flexible_array.cocci > @@ -0,0 +1,88 @@ > +// SPDX-License-Identifier: GPL-2.0-only > +/// > +/// Zero-length and one-element arrays are deprecated, see > +/// Documentation/process/deprecated.rst > +/// Flexible-array members should be used instead. > +/// > +// > +// Confidence: High > +// Copyright: (C) 2020 Denis Efremov ISPRAS. > +// Comments: > +// Options: --no-includes --include-headers > + > +virtual context > +virtual report > +virtual org > +virtual patch > + > +@initialize:python@ > +@@ > +def relevant(positions): > + for p in positions: > + if "uapi" in p.file: > + return False > + return True > + > +@r depends on !patch@ > +identifier name, array; > +type T; > +position p : script:python() { relevant(p) }; > +@@ > + > +( > + struct name { > + ... > +* T array@p[\(0\|1\)]; > + }; > +| > + struct { > + ... > +* T array@p[\(0\|1\)]; > + }; > +| > + union name { > + ... > +* T array@p[\(0\|1\)]; > + }; > +| > + union { > + ... > +* T array@p[\(0\|1\)]; > + }; > +) > + > +@depends on patch exists@ exists is not necessary here. There are not multiple control-flow paths through a structure declaration. > +identifier name, array; > +type T; > +position p : script:python() { relevant(p) }; > +@@ > + > +( > + struct name { > + ... > + T array@p[ > +- 0 > + ]; > + }; > +| > + struct { > + ... > + T array@p[ > +- 0 > + ]; > + }; > +) > + > +@script: python depends on report@ > +p << r.p; > +@@ > + > +msg = "WARNING: use flexible-array member instead" > +coccilib.report.print_report(p[0], msg) > + > +@script: python depends on org@ > +p << r.p; > +@@ > + > +msg = "WARNING: use flexible-array member instead" > +coccilib.org.print_todo(p, msg) This should be coccilib.org.print_todo(p[0], msg) julia _______________________________________________ Cocci mailing list Cocci@systeme.lip6.fr https://systeme.lip6.fr/mailman/listinfo/cocci